From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7D4C2B9F2 for ; Sun, 23 May 2021 00:07:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1587F610A2 for ; Sun, 23 May 2021 00:07:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231476AbhEWAIY convert rfc822-to-8bit (ORCPT ); Sat, 22 May 2021 20:08:24 -0400 Received: from foss.arm.com ([217.140.110.172]:35646 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231479AbhEWAIY (ORCPT ); Sat, 22 May 2021 20:08:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59FD81042; Sat, 22 May 2021 17:06:58 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78D1A3F73B; Sat, 22 May 2021 17:06:56 -0700 (PDT) Date: Sun, 23 May 2021 01:06:43 +0100 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Icenowy Zheng , Samuel Holland , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v6 05/17] rtc: sun6i: Add Allwinner H616 support Message-ID: <20210523010643.7fdfd419@slackpad.fritz.box> In-Reply-To: <10265315.EKgO2cQaHd@kista> References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-6-andre.przywara@arm.com> <10265315.EKgO2cQaHd@kista> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Sat, 22 May 2021 09:29:26 +0200 Jernej Škrabec wrote: Hi, > Dne sreda, 19. maj 2021 ob 12:41:40 CEST je Andre Przywara napisal(a): > > The H616 RTC changes its day storage to the newly introduced linear day > > scheme, so pair the new compatible string with this feature flag. > > So far the clock parts seem to be the same as the H6, so combine the > > compatible string with the existing H6 support bits. > > There is one more difference - H616 alarm value is now broken down to days, > hours, minutes and seconds. That's a good point, that actually requires adjusting the driver in this respect as well. And contrary to what the manual says ("Counter Register will down count to zero"), and the previous RTCs do, those alarm registers now need to be set to the actual wakeup time, not the time left before wakeup. Will fix the driver accordingly. Thanks for the heads up! Cheers, Andre > > Best regards, > Jernej > > > > > Signed-off-by: Andre Przywara > > --- > > drivers/rtc/rtc-sun6i.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > > index 0228e9dfd969..ec0cd0ee539a 100644 > > --- a/drivers/rtc/rtc-sun6i.c > > +++ b/drivers/rtc/rtc-sun6i.c > > @@ -382,6 +382,8 @@ static void __init sun50i_h6_rtc_clk_init(struct > device_node *node) > > } > > CLK_OF_DECLARE_DRIVER(sun50i_h6_rtc_clk, "allwinner,sun50i-h6-rtc", > > sun50i_h6_rtc_clk_init); > > +CLK_OF_DECLARE_DRIVER(sun50i_h616_rtc_clk, "allwinner,sun50i-h616-rtc", > > + sun50i_h6_rtc_clk_init); > > > > /* > > * The R40 user manual is self-conflicting on whether the prescaler is > > @@ -773,6 +775,8 @@ static const struct of_device_id sun6i_rtc_dt_ids[] = { > > { .compatible = "allwinner,sun8i-v3-rtc" }, > > { .compatible = "allwinner,sun50i-h5-rtc" }, > > { .compatible = "allwinner,sun50i-h6-rtc" }, > > + { .compatible = "allwinner,sun50i-h616-rtc", > > + .data = (void *)RTC_LINEAR_DAY }, > > { /* sentinel */ }, > > }; > > MODULE_DEVICE_TABLE(of, sun6i_rtc_dt_ids); > > -- > > 2.17.5 > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E592C2B9F2 for ; Sun, 23 May 2021 00:09:19 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE8E8610A2 for ; Sun, 23 May 2021 00:09:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE8E8610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lo025/MbfvKhoJk721WvjOO5Za8pIZLRaZQ+/lTiq/Q=; b=hG4SotHqu4CATYKOTNTc9UtlyI tCI+5ZIfY1LoW32MxuqttPnasefEfdiNdM/29rYgfEAuewsyubX5Wbk+ogknEJYVl6AyJqONliLiL wbn/S9Z6cllcCRKyZ9+hf9Kw9DwgTPF6jfgKoMioh+BzQ8jXYvZ4cJaU5Gxz1qDiSJK+5bvqlc9ch rVego6y7291Ao+wCoH6+eXaz0Wrf6njIqoiPwU2ZnWQpTsxWvMYG0k6Pn/qjZnWYHcQUj+CmV3rXA PqpW9r9oWWmSDQchLjZZni2PajilMtWAO4FzQigJN+jHNB+U/cZdIuSUDJYiJlQf5vWHodjJvVsFc 8G2YP/WA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkbe9-003MAM-5S; Sun, 23 May 2021 00:07:10 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkbe3-003MA7-6Y for linux-arm-kernel@desiato.infradead.org; Sun, 23 May 2021 00:07:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=USuHsWwf25SGRK2EnaMr3OX9QczsRD+/ePgxAWw+StI=; b=QwfEk82kSkx4gAiR6jdgbVerEd xNhs1mmGGEixoFC0YQTUyk9Hdg+JO4zf3lfySyV9ZvRFy+myxB16qQoxd+0c88cHCf1i3P1MCo1tf g8QxYVZbY2tZ9QWraYzDqJifNihMWX5TabztmLS4a2mQYMdfjzeYQhsIUJIaYtx/4pq7XcEDIUi9P 922XzTLIWGxM47pzjWmVSCReKrePFOYLi5NicPdU/wv3Dg0/TH4Ba1KJ+MxLcybi0m88nRXpeGeFi JVTmlZ6yuIiKZDzEGmSjOZpaaeLKm3Qx+M5WXX1WrHcZ6c75ou22gLMyQZ76qiyLCynKyhuGNNREg MPiSbd9w==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lkbe0-000Fbc-DK for linux-arm-kernel@lists.infradead.org; Sun, 23 May 2021 00:07:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59FD81042; Sat, 22 May 2021 17:06:58 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78D1A3F73B; Sat, 22 May 2021 17:06:56 -0700 (PDT) Date: Sun, 23 May 2021 01:06:43 +0100 From: Andre Przywara To: Jernej =?UTF-8?B?xaBrcmFiZWM=?= Cc: Maxime Ripard , Chen-Yu Tsai , Rob Herring , Icenowy Zheng , Samuel Holland , Ondrej Jirman , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v6 05/17] rtc: sun6i: Add Allwinner H616 support Message-ID: <20210523010643.7fdfd419@slackpad.fritz.box> In-Reply-To: <10265315.EKgO2cQaHd@kista> References: <20210519104152.21119-1-andre.przywara@arm.com> <20210519104152.21119-6-andre.przywara@arm.com> <10265315.EKgO2cQaHd@kista> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210522_170700_519102_11948805 X-CRM114-Status: GOOD ( 24.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCAyMiBNYXkgMjAyMSAwOToyOToyNiArMDIwMApKZXJuZWogxaBrcmFiZWMgPGplcm5l ai5za3JhYmVjQGdtYWlsLmNvbT4gd3JvdGU6CgpIaSwKCj4gRG5lIHNyZWRhLCAxOS4gbWFqIDIw MjEgb2IgMTI6NDE6NDAgQ0VTVCBqZSBBbmRyZSBQcnp5d2FyYSBuYXBpc2FsKGEpOgo+ID4gVGhl IEg2MTYgUlRDIGNoYW5nZXMgaXRzIGRheSBzdG9yYWdlIHRvIHRoZSBuZXdseSBpbnRyb2R1Y2Vk IGxpbmVhciBkYXkKPiA+IHNjaGVtZSwgc28gcGFpciB0aGUgbmV3IGNvbXBhdGlibGUgc3RyaW5n IHdpdGggdGhpcyBmZWF0dXJlIGZsYWcuCj4gPiBTbyBmYXIgdGhlIGNsb2NrIHBhcnRzIHNlZW0g dG8gYmUgdGhlIHNhbWUgYXMgdGhlIEg2LCBzbyBjb21iaW5lIHRoZQo+ID4gY29tcGF0aWJsZSBz dHJpbmcgd2l0aCB0aGUgZXhpc3RpbmcgSDYgc3VwcG9ydCBiaXRzLiAgCj4gCj4gVGhlcmUgaXMg b25lIG1vcmUgZGlmZmVyZW5jZSAtIEg2MTYgYWxhcm0gdmFsdWUgaXMgbm93IGJyb2tlbiBkb3du IHRvIGRheXMsIAo+IGhvdXJzLCBtaW51dGVzIGFuZCBzZWNvbmRzLgoKVGhhdCdzIGEgZ29vZCBw b2ludCwgdGhhdCBhY3R1YWxseSByZXF1aXJlcyBhZGp1c3RpbmcgdGhlIGRyaXZlciBpbgp0aGlz IHJlc3BlY3QgYXMgd2VsbC4gQW5kIGNvbnRyYXJ5IHRvIHdoYXQgdGhlIG1hbnVhbCBzYXlzICgi Q291bnRlcgpSZWdpc3RlciB3aWxsIGRvd24gY291bnQgdG8gemVybyIpLCBhbmQgdGhlIHByZXZp b3VzIFJUQ3MgZG8sIHRob3NlIGFsYXJtCnJlZ2lzdGVycyBub3cgbmVlZCB0byBiZSBzZXQgdG8g dGhlIGFjdHVhbCB3YWtldXAgdGltZSwgbm90IHRoZSB0aW1lCmxlZnQgYmVmb3JlIHdha2V1cC4K V2lsbCBmaXggdGhlIGRyaXZlciBhY2NvcmRpbmdseS4KClRoYW5rcyBmb3IgdGhlIGhlYWRzIHVw IQoKQ2hlZXJzLApBbmRyZQoKPiAKPiBCZXN0IHJlZ2FyZHMsCj4gSmVybmVqCj4gCj4gPiAKPiA+ IFNpZ25lZC1vZmYtYnk6IEFuZHJlIFByenl3YXJhIDxhbmRyZS5wcnp5d2FyYUBhcm0uY29tPgo+ ID4gLS0tCj4gPiAgZHJpdmVycy9ydGMvcnRjLXN1bjZpLmMgfCA0ICsrKysKPiA+ICAxIGZpbGUg Y2hhbmdlZCwgNCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3J0 Yy9ydGMtc3VuNmkuYyBiL2RyaXZlcnMvcnRjL3J0Yy1zdW42aS5jCj4gPiBpbmRleCAwMjI4ZTlk ZmQ5NjkuLmVjMGNkMGVlNTM5YSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvcnRjL3J0Yy1zdW42 aS5jCj4gPiArKysgYi9kcml2ZXJzL3J0Yy9ydGMtc3VuNmkuYwo+ID4gQEAgLTM4Miw2ICszODIs OCBAQCBzdGF0aWMgdm9pZCBfX2luaXQgc3VuNTBpX2g2X3J0Y19jbGtfaW5pdChzdHJ1Y3QgICAK PiBkZXZpY2Vfbm9kZSAqbm9kZSkKPiA+ICB9Cj4gPiAgQ0xLX09GX0RFQ0xBUkVfRFJJVkVSKHN1 bjUwaV9oNl9ydGNfY2xrLCAiYWxsd2lubmVyLHN1bjUwaS1oNi1ydGMiLAo+ID4gIAkJICAgICAg c3VuNTBpX2g2X3J0Y19jbGtfaW5pdCk7Cj4gPiArQ0xLX09GX0RFQ0xBUkVfRFJJVkVSKHN1bjUw aV9oNjE2X3J0Y19jbGssICJhbGx3aW5uZXIsc3VuNTBpLWg2MTYtcnRjIiwKPiA+ICsJCSAgICAg IHN1bjUwaV9oNl9ydGNfY2xrX2luaXQpOwo+ID4gIAo+ID4gIC8qCj4gPiAgICogVGhlIFI0MCB1 c2VyIG1hbnVhbCBpcyBzZWxmLWNvbmZsaWN0aW5nIG9uIHdoZXRoZXIgdGhlIHByZXNjYWxlciBp cwo+ID4gQEAgLTc3Myw2ICs3NzUsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9p ZCBzdW42aV9ydGNfZHRfaWRzW10gPSB7Cj4gPiAgCXsgLmNvbXBhdGlibGUgPSAiYWxsd2lubmVy LHN1bjhpLXYzLXJ0YyIgfSwKPiA+ICAJeyAuY29tcGF0aWJsZSA9ICJhbGx3aW5uZXIsc3VuNTBp LWg1LXJ0YyIgfSwKPiA+ICAJeyAuY29tcGF0aWJsZSA9ICJhbGx3aW5uZXIsc3VuNTBpLWg2LXJ0 YyIgfSwKPiA+ICsJeyAuY29tcGF0aWJsZSA9ICJhbGx3aW5uZXIsc3VuNTBpLWg2MTYtcnRjIiwK PiA+ICsJCS5kYXRhID0gKHZvaWQgKilSVENfTElORUFSX0RBWSB9LAo+ID4gIAl7IC8qIHNlbnRp bmVsICovIH0sCj4gPiAgfTsKPiA+ICBNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBzdW42aV9ydGNf ZHRfaWRzKTsKPiA+IC0tIAo+ID4gMi4xNy41Cj4gPiAKPiA+ICAgCj4gCj4gCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=