From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Nikola Milosavljević" <mnidza@outlook.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Peter Geis" <pgwipeout@gmail.com>,
"Nicolas Chauvet" <kwizart@gmail.com>,
"Viresh Kumar" <vireshk@kernel.org>,
"Stephen Boyd" <sboyd@kernel.org>,
"Matt Merhar" <mattmerhar@protonmail.com>,
"Paul Fertser" <fercerpav@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
"Mikko Perttunen" <mperttunen@nvidia.com>
Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
linux-clk@vger.kernel.org
Subject: [PATCH v2 10/14] memory: tegra20-emc: Use devm_tegra_core_dev_init_opp_table()
Date: Mon, 24 May 2021 02:13:31 +0300 [thread overview]
Message-ID: <20210523231335.8238-11-digetx@gmail.com> (raw)
In-Reply-To: <20210523231335.8238-1-digetx@gmail.com>
Use common devm_tegra_core_dev_init_opp_table() helper for the OPP table
initialization.
Tested-by: Paul Fertser <fercerpav@gmail.com> # PAZ00 T20
Tested-by: Nicolas Chauvet <kwizart@gmail.com> # PAZ00 T20
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/memory/tegra/tegra20-emc.c | 48 +++---------------------------
1 file changed, 4 insertions(+), 44 deletions(-)
diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index da8a0da8da79..a534197a5fb2 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -908,49 +908,6 @@ static int tegra_emc_interconnect_init(struct tegra_emc *emc)
return err;
}
-static int tegra_emc_opp_table_init(struct tegra_emc *emc)
-{
- u32 hw_version = BIT(tegra_sku_info.soc_process_id);
- struct opp_table *hw_opp_table;
- int err;
-
- hw_opp_table = dev_pm_opp_set_supported_hw(emc->dev, &hw_version, 1);
- err = PTR_ERR_OR_ZERO(hw_opp_table);
- if (err) {
- dev_err(emc->dev, "failed to set OPP supported HW: %d\n", err);
- return err;
- }
-
- err = dev_pm_opp_of_add_table(emc->dev);
- if (err) {
- if (err == -ENODEV)
- dev_err(emc->dev, "OPP table not found, please update your device tree\n");
- else
- dev_err(emc->dev, "failed to add OPP table: %d\n", err);
-
- goto put_hw_table;
- }
-
- dev_info_once(emc->dev, "OPP HW ver. 0x%x, current clock rate %lu MHz\n",
- hw_version, clk_get_rate(emc->clk) / 1000000);
-
- /* first dummy rate-set initializes voltage state */
- err = dev_pm_opp_set_rate(emc->dev, clk_get_rate(emc->clk));
- if (err) {
- dev_err(emc->dev, "failed to initialize OPP clock: %d\n", err);
- goto remove_table;
- }
-
- return 0;
-
-remove_table:
- dev_pm_opp_of_remove_table(emc->dev);
-put_hw_table:
- dev_pm_opp_put_supported_hw(hw_opp_table);
-
- return err;
-}
-
static void devm_tegra_emc_unset_callback(void *data)
{
tegra20_clk_set_emc_round_callback(NULL, NULL);
@@ -1077,6 +1034,7 @@ static int tegra_emc_devfreq_init(struct tegra_emc *emc)
static int tegra_emc_probe(struct platform_device *pdev)
{
+ struct tegra_core_opp_params opp_params = {};
struct device_node *np;
struct tegra_emc *emc;
int irq, err;
@@ -1122,7 +1080,9 @@ static int tegra_emc_probe(struct platform_device *pdev)
if (err)
return err;
- err = tegra_emc_opp_table_init(emc);
+ opp_params.init_state = true;
+
+ err = devm_tegra_core_dev_init_opp_table(&pdev->dev, &opp_params);
if (err)
return err;
--
2.30.2
next prev parent reply other threads:[~2021-05-23 23:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 23:13 [PATCH v2 00/14] NVIDIA Tegra memory and power management changes for 5.14 Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 01/14] regulator: core: Add regulator_sync_voltage_rdev() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 02/14] regulator: core: Detach coupled regulator before coupling count is dropped Dmitry Osipenko
2021-05-24 10:20 ` Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 03/14] soc/tegra: regulators: Bump voltages on system reboot Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 04/14] soc/tegra: Add stub for soc_is_tegra() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 05/14] soc/tegra: Add devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 06/14] soc/tegra: fuse: Add stubs needed for compile-testing Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 07/14] clk: tegra: " Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 08/14] memory: tegra: Fix compilation warnings on 64bit platforms Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 09/14] memory: tegra: Enable compile testing for all drivers Dmitry Osipenko
2021-05-24 5:26 ` kernel test robot
2021-05-23 23:13 ` Dmitry Osipenko [this message]
2021-05-23 23:13 ` [PATCH v2 11/14] memory: tegra30-emc: Use devm_tegra_core_dev_init_opp_table() Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 12/14] dt-bindings: soc: tegra-pmc: Document core power domain Dmitry Osipenko
2021-05-24 17:02 ` Ulf Hansson
2021-05-23 23:13 ` [PATCH v2 13/14] soc/tegra: pmc: Add " Dmitry Osipenko
2021-05-24 17:04 ` Ulf Hansson
2021-05-24 20:23 ` Dmitry Osipenko
2021-05-31 13:17 ` Ulf Hansson
2021-05-31 20:07 ` Dmitry Osipenko
2021-06-01 10:19 ` Ulf Hansson
2021-06-01 15:48 ` Dmitry Osipenko
2021-05-24 20:25 ` Dmitry Osipenko
2021-05-23 23:13 ` [PATCH v2 14/14] soc/tegra: regulators: Support core domain state syncing Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523231335.8238-11-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fercerpav@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kwizart@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mnidza@outlook.com \
--cc=mperttunen@nvidia.com \
--cc=nathan@kernel.org \
--cc=pgwipeout@gmail.com \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.