All of lore.kernel.org
 help / color / mirror / Atom feed
From: Douglas Gilbert <dgilbert@interlog.com>
To: linux-scsi@vger.kernel.org
Cc: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, hare@suse.de
Subject: [PATCH v19 43/45] sg: no_dxfer: move to/from kernel buffers
Date: Sun, 23 May 2021 21:01:45 -0400	[thread overview]
Message-ID: <20210524010147.94845-44-dgilbert@interlog.com> (raw)
In-Reply-To: <20210524010147.94845-1-dgilbert@interlog.com>

When the NO_DXFER flag is use on a command/request, the data-in
and data-out buffers (if present) should not be ignored. Add
sg_rq_map_kern() function to handle this. Uses a single bio with
multiple bvec_s usually each holding multiple pages, if necessary.
The driver default element size is 32 KiB so if PAGE_SIZE is 4096
then get_order()==3 .

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
---
 drivers/scsi/sg.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
index 20ebaebe4a9b..444116b10ea2 100644
--- a/drivers/scsi/sg.c
+++ b/drivers/scsi/sg.c
@@ -2802,6 +2802,59 @@ exit_sg(void)
 	idr_destroy(&sg_index_idr);
 }
 
+static struct bio *
+sg_mk_kern_bio(int bvec_cnt)
+{
+	struct bio *biop;
+
+	if (bvec_cnt > BIO_MAX_VECS)
+		return NULL;
+	biop = bio_alloc(GFP_ATOMIC, bvec_cnt);
+	if (!biop)
+		return NULL;
+	biop->bi_end_io = bio_put;
+	return biop;
+}
+
+/*
+ * Setup to move data between kernel buffers managed by this driver and a SCSI device. Note that
+ * there is no corresponding 'unmap' call as is required by blk_rq_map_user() . Uses a single
+ * bio with an expanded appended bvec if necessary.
+ */
+static int
+sg_rq_map_kern(struct sg_request *srp, struct request_queue *q, struct request *rqq, int rw_ind)
+{
+	struct sg_scatter_hold *schp = &srp->sgat_h;
+	struct bio *bio;
+	int k, ln;
+	int op_flags = 0;
+	int num_sgat = schp->num_sgat;
+	int dlen = schp->dlen;
+	int pg_sz = 1 << (PAGE_SHIFT + schp->page_order);
+
+	SG_LOG(4, srp->parentfp, "%s: dlen=%d, pg_sz=%d\n", __func__, dlen, pg_sz);
+	if (num_sgat <= 0)
+		return 0;
+	if (rw_ind == WRITE)
+		op_flags = REQ_SYNC | REQ_IDLE;
+	bio = sg_mk_kern_bio(num_sgat);
+	if (!bio)
+		return -ENOMEM;
+	bio->bi_opf = req_op(rqq) | op_flags;
+
+	for (k = 0; k < num_sgat && dlen > 0; ++k, dlen -= ln) {
+		ln = min_t(int, dlen, pg_sz);
+		if (bio_add_pc_page(q, bio, schp->pages[k], ln, 0) < ln) {
+			bio_put(bio);
+			return -EINVAL;
+		}
+	}
+	/* used blk_rq_append_bio() before but this is simpler */
+	blk_rq_bio_prep(rqq, bio, num_sgat);
+	rqq->nr_phys_segments = (1 << schp->page_order) * num_sgat;
+	return 0;
+}
+
 static inline void
 sg_set_map_data(const struct sg_scatter_hold *schp, bool up_valid,
 		struct rq_map_data *mdp)
@@ -2962,6 +3015,8 @@ sg_start_req(struct sg_request *srp, struct sg_comm_wr_t *cwrp, int dxfer_dir)
 		if (IS_ENABLED(CONFIG_SCSI_PROC_FS) && res)
 			SG_LOG(1, sfp, "%s: blk_rq_map_user() res=%d\n",
 			       __func__, res);
+	} else {	/* transfer data to/from kernel buffers */
+		res = sg_rq_map_kern(srp, q, rqq, r0w);
 	}
 fini:
 	if (unlikely(res)) {		/* failure, free up resources */
-- 
2.25.1


  parent reply	other threads:[~2021-05-24  1:03 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24  1:01 [PATCH v19 00/45] sg: add v4 interface Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 01/45] sg: move functions around Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 02/45] sg: remove typedefs, type+formatting cleanup Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 03/45] sg: sg_log and is_enabled Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 04/45] sg: rework sg_poll(), minor changes Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 05/45] sg: bitops in sg_device Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 06/45] sg: make open count an atomic Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 07/45] sg: move header to uapi section Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 08/45] sg: speed sg_poll and sg_get_num_waiting Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 09/45] sg: sg_allow_if_err_recovery and renames Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 10/45] sg: improve naming Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 11/45] sg: change rwlock to spinlock Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 12/45] sg: ioctl handling Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 13/45] sg: split sg_read Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 14/45] sg: sg_common_write add structure for arguments Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 15/45] sg: rework sg_vma_fault Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 16/45] sg: rework sg_mmap Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 17/45] sg: replace sg_allow_access Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 18/45] sg: rework scatter gather handling Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 19/45] sg: introduce request state machine Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 20/45] sg: sg_find_srp_by_id Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 21/45] sg: sg_fill_request_element Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 22/45] sg: printk change %p to %pK Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 23/45] sg: xarray for fds in device Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 24/45] sg: xarray for reqs in fd Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 25/45] sg: replace rq array with xarray Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 26/45] sg: sense buffer rework Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 27/45] sg: add sg v4 interface support Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 28/45] sg: rework debug info Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 29/45] sg: add 8 byte SCSI LUN to sg_scsi_id Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 30/45] sg: expand sg_comm_wr_t Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 31/45] sg: add sg_iosubmit_v3 and sg_ioreceive_v3 ioctls Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 32/45] sg: add some __must_hold macros Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 33/45] sg: move procfs objects to avoid forward decls Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 34/45] sg: protect multiple receivers Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 35/45] sg: first debugfs support Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 36/45] sg: rework mmap support Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 37/45] sg: defang allow_dio Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 38/45] sg: warn v3 write system call users Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 39/45] sg: add mmap_sz tracking Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 40/45] sg: remove rcv_done request state Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 41/45] sg: track lowest inactive and await indexes Douglas Gilbert
2021-05-24  1:01 ` [PATCH v19 42/45] sg: remove unit attention check for device changed Douglas Gilbert
2021-05-24  1:01 ` Douglas Gilbert [this message]
2021-05-24  1:01 ` [PATCH v19 44/45] sg: add blk_poll support Douglas Gilbert
2021-05-25  8:36   ` Hannes Reinecke
2021-05-24  1:01 ` [PATCH v19 45/45] sg: bump version to 4.0.12 Douglas Gilbert
2021-05-25  8:36   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524010147.94845-44-dgilbert@interlog.com \
    --to=dgilbert@interlog.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.