From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F70C04FF3 for ; Mon, 24 May 2021 14:37:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FC2B61370 for ; Mon, 24 May 2021 14:37:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232844AbhEXOi0 (ORCPT ); Mon, 24 May 2021 10:38:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:50652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232662AbhEXOi0 (ORCPT ); Mon, 24 May 2021 10:38:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0AFDE6113B; Mon, 24 May 2021 14:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621867018; bh=7T5VX2eQcaYMrUtpjWz5Rw7UAowD4vaCkcvMGSv9CLY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lYQYVFCL8VKYYj+I7P5lXR/fEWcKfESZSYswCk6cBqi2dVqV4FDeJ01CaPmYR0c5p 475s+QM2SYE06LeHVprIlr/bmRwkPz55tk9npPU3WcKSezVxcl7/Xezyia8NEt5tVB +Xne0S/GIk+n0H7BgpVU83wrUMObmMXOvDCJBHtSO7SB7Ui9+nLP0M35+fQH/iSQBI SO2UvJ8/ljhSqTYKyaTeo9o63VBErtNr/azqKvzXoq0S7m0Bfe1mUwPI4uSwkbh9ze FmUGXl80AU48ijvowJbmCAxSmUlC/1cromjnyX0bSVuLuHDlRnXMiUUeqEv/FUjmMc Va3JCe1EynV2g== Date: Mon, 24 May 2021 16:36:51 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Marc Zyngier Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Remi Pommarel , Xogium , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/42] PCI: aardvark: Change name of INTx irq_chip to advk-INT Message-ID: <20210524163651.430e5497@thinkpad> In-Reply-To: <87im3uq5bx.wl-maz@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> <20210506153153.30454-16-pali@kernel.org> <87im3uq5bx.wl-maz@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 07 May 2021 10:08:18 +0100 Marc Zyngier wrote: > On Thu, 06 May 2021 16:31:26 +0100, > Pali Roh=C3=A1r wrote: > >=20 > > This name is visible in /proc/interrupts file and for better reading it > > should have at most 8 characters. Also there is no need to allocate this > > name dynamically, since there is only one PCIe controller on Armada 37x= x. > > This aligns with how the MSI irq_chip in this driver names it's interru= pt > > ("advk-MSI"). =20 >=20 > And *because* the name is visible in /proc/interrupts, it has become > an ABI, and cannot be changed anymore. >=20 > We had the exact same issue with Tegra this merge window as I > accidentally changed "Tegra" to "tegra", resulting in userspace > programs failing find stuff in /proc/interrupts. >=20 > Please keep the name as is, no matter how ugly it is. Hmm, I am 99% sure that for the A3720 platform this ABI change would not affect anybody. And it does make the driver's irq names confusing. Can't we really do anything here? Note that there were suggestions from some people to completely remove this driver due to the many problems it has which Pali is trying to solve. But if the driver was removed and then later introduced again without these problems, the new version would use the "advk-INT" IRQ name... Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C72C04FF3 for ; Mon, 24 May 2021 18:41:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 843816140F for ; Mon, 24 May 2021 18:41:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 843816140F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UjBzQhvMTYAKcTy0pD9+qkY+ukAgMdqoA+ju4k7Ntnw=; b=NqR3IU4766G8He FohrYywRqaMbKR53shVB2HKINJfHIZ7Fq4GGzxhhtdKWN5cPmBE+cdRycs2u9B8fdOJOjsc2+ETXM wdGCckDujaWWbVbA9+48DdY2L30WLDT0IJFwxxzlF8acqPNjA81aSXF+1QNkkQjZ4P6SgxIpPxr6u +/AoNui6KBwsb9yMTKccpgCG/xqw0GZL0BT0GivjVtjapioFl5Nd6kcwB7dKc1FXLqBrc/rAWQT68 V3SFGzqbk3aaNoeNBs6mTuWN1W69pEadYkHAG7LlhEYRcAd5nu4k4cpd8frDEoUYd8vwDuP2YpJJF UcA5R+DajRVQ/0/pgjUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llFTN-001VEQ-98; Mon, 24 May 2021 18:38:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1llBhT-000ztU-Pb for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 14:37:01 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0AFDE6113B; Mon, 24 May 2021 14:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621867018; bh=7T5VX2eQcaYMrUtpjWz5Rw7UAowD4vaCkcvMGSv9CLY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lYQYVFCL8VKYYj+I7P5lXR/fEWcKfESZSYswCk6cBqi2dVqV4FDeJ01CaPmYR0c5p 475s+QM2SYE06LeHVprIlr/bmRwkPz55tk9npPU3WcKSezVxcl7/Xezyia8NEt5tVB +Xne0S/GIk+n0H7BgpVU83wrUMObmMXOvDCJBHtSO7SB7Ui9+nLP0M35+fQH/iSQBI SO2UvJ8/ljhSqTYKyaTeo9o63VBErtNr/azqKvzXoq0S7m0Bfe1mUwPI4uSwkbh9ze FmUGXl80AU48ijvowJbmCAxSmUlC/1cromjnyX0bSVuLuHDlRnXMiUUeqEv/FUjmMc Va3JCe1EynV2g== Date: Mon, 24 May 2021 16:36:51 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Marc Zyngier Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Remi Pommarel , Xogium , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/42] PCI: aardvark: Change name of INTx irq_chip to advk-INT Message-ID: <20210524163651.430e5497@thinkpad> In-Reply-To: <87im3uq5bx.wl-maz@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> <20210506153153.30454-16-pali@kernel.org> <87im3uq5bx.wl-maz@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_073659_877367_ADB0609D X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwNyBNYXkgMjAyMSAxMDowODoxOCArMDEwMApNYXJjIFp5bmdpZXIgPG1hekBrZXJu ZWwub3JnPiB3cm90ZToKCj4gT24gVGh1LCAwNiBNYXkgMjAyMSAxNjozMToyNiArMDEwMCwKPiBQ YWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+IAo+ID4gVGhpcyBuYW1lIGlz IHZpc2libGUgaW4gL3Byb2MvaW50ZXJydXB0cyBmaWxlIGFuZCBmb3IgYmV0dGVyIHJlYWRpbmcg aXQKPiA+IHNob3VsZCBoYXZlIGF0IG1vc3QgOCBjaGFyYWN0ZXJzLiBBbHNvIHRoZXJlIGlzIG5v IG5lZWQgdG8gYWxsb2NhdGUgdGhpcwo+ID4gbmFtZSBkeW5hbWljYWxseSwgc2luY2UgdGhlcmUg aXMgb25seSBvbmUgUENJZSBjb250cm9sbGVyIG9uIEFybWFkYSAzN3h4Lgo+ID4gVGhpcyBhbGln bnMgd2l0aCBob3cgdGhlIE1TSSBpcnFfY2hpcCBpbiB0aGlzIGRyaXZlciBuYW1lcyBpdCdzIGlu dGVycnVwdAo+ID4gKCJhZHZrLU1TSSIpLiAgCj4gCj4gQW5kICpiZWNhdXNlKiB0aGUgbmFtZSBp cyB2aXNpYmxlIGluIC9wcm9jL2ludGVycnVwdHMsIGl0IGhhcyBiZWNvbWUKPiBhbiBBQkksIGFu ZCBjYW5ub3QgYmUgY2hhbmdlZCBhbnltb3JlLgo+IAo+IFdlIGhhZCB0aGUgZXhhY3Qgc2FtZSBp c3N1ZSB3aXRoIFRlZ3JhIHRoaXMgbWVyZ2Ugd2luZG93IGFzIEkKPiBhY2NpZGVudGFsbHkgY2hh bmdlZCAiVGVncmEiIHRvICJ0ZWdyYSIsIHJlc3VsdGluZyBpbiB1c2Vyc3BhY2UKPiBwcm9ncmFt cyBmYWlsaW5nIGZpbmQgc3R1ZmYgaW4gL3Byb2MvaW50ZXJydXB0cy4KPiAKPiBQbGVhc2Uga2Vl cCB0aGUgbmFtZSBhcyBpcywgbm8gbWF0dGVyIGhvdyB1Z2x5IGl0IGlzLgoKSG1tLCBJIGFtIDk5 JSBzdXJlIHRoYXQgZm9yIHRoZSBBMzcyMCBwbGF0Zm9ybSB0aGlzIEFCSSBjaGFuZ2Ugd291bGQg bm90CmFmZmVjdCBhbnlib2R5LiBBbmQgaXQgZG9lcyBtYWtlIHRoZSBkcml2ZXIncyBpcnEgbmFt ZXMgY29uZnVzaW5nLgpDYW4ndCB3ZSByZWFsbHkgZG8gYW55dGhpbmcgaGVyZT8KCk5vdGUgdGhh dCB0aGVyZSB3ZXJlIHN1Z2dlc3Rpb25zIGZyb20gc29tZSBwZW9wbGUgdG8gY29tcGxldGVseSBy ZW1vdmUKdGhpcyBkcml2ZXIgZHVlIHRvIHRoZSBtYW55IHByb2JsZW1zIGl0IGhhcyB3aGljaCBQ YWxpIGlzIHRyeWluZyB0bwpzb2x2ZS4gQnV0IGlmIHRoZSBkcml2ZXIgd2FzIHJlbW92ZWQgYW5k IHRoZW4gbGF0ZXIgaW50cm9kdWNlZCBhZ2Fpbgp3aXRob3V0IHRoZXNlIHByb2JsZW1zLCB0aGUg bmV3IHZlcnNpb24gd291bGQgdXNlIHRoZSAiYWR2ay1JTlQiIElSUQpuYW1lLi4uCgpNYXJlawoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=