From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFA2EC2B9F7 for ; Wed, 26 May 2021 04:50:36 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE7D3613AD for ; Wed, 26 May 2021 04:50:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE7D3613AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-Q_AzCH4DMHG6UaiIOnPFlg-1; Wed, 26 May 2021 00:50:30 -0400 X-MC-Unique: Q_AzCH4DMHG6UaiIOnPFlg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4DEB6180FD62; Wed, 26 May 2021 04:50:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0ED5C5D9D0; Wed, 26 May 2021 04:50:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 773BB1801029; Wed, 26 May 2021 04:50:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 14Q4oGW4003867 for ; Wed, 26 May 2021 00:50:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id E63B1BDC5F; Wed, 26 May 2021 04:50:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E10CAFC758 for ; Wed, 26 May 2021 04:50:13 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 57FF28007AC for ; Wed, 26 May 2021 04:50:13 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-7W5EAw5qOSevLfiaZHIo7g-1; Wed, 26 May 2021 00:49:48 -0400 X-MC-Unique: 7W5EAw5qOSevLfiaZHIo7g-1 Received: by verein.lst.de (Postfix, from userid 2407) id 3ADA76736F; Wed, 26 May 2021 06:49:44 +0200 (CEST) Date: Wed, 26 May 2021 06:49:43 +0200 From: Christoph Hellwig To: Ulf Hansson Message-ID: <20210526044943.GA28551@lst.de> References: <20210521055116.1053587-1-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: nvdimm@lists.linux.dev, linux-m68k@vger.kernel.org, Mike Snitzer , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, Joshua Morris , linux-s390@vger.kernel.org, Dave Jiang , Maxim Levitsky , Vishal Verma , Christoph Hellwig , Christian Borntraeger , Geert Uytterhoeven , Matias Bjorling , Nitin Gupta , Vasily Gorbik , linux-xtensa@linux-xtensa.org, Alex Dubov , Heiko Carstens , Coly Li , linux-block , linux-bcache@vger.kernel.org, drbd-dev@tron.linbit.com, Philip Kelleher , Dan Williams , Jens Axboe , Chris Zankel , linux-raid@vger.kernel.org, Max Filippov , linux-mmc , Philipp Reisner , Jim Paris , Minchan Kim , Lars Ellenberg , linuxppc-dev Subject: Re: [dm-devel] simplify gendisk and request_queue allocation for bio based drivers X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > Hi all, > > > > this series is the first part of cleaning up lifetimes and allocation of > > the gendisk and request_queue structure. It adds a new interface to > > allocate the disk and queue together for bio based drivers, and a helper > > for cleanup/free them when a driver is unloaded or a device is removed. > > May I ask what else you have in the pipe for the next steps? > > The reason why I ask is that I am looking into some issues related to > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card > removal. In the short run not much more than superficial cleanups. Eventually I want bio based drivers to not require a separate request_queue, leaving that purely as a data structure for blk-mq based drivers. But it will take a while until we get there, so it should not block any fixes. For hot unplug handling it might be worth to take a look at nvme, as it is tested a lot for that case. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BED1C2B9F7 for ; Wed, 26 May 2021 04:49:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03035613BA for ; Wed, 26 May 2021 04:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229522AbhEZEvU (ORCPT ); Wed, 26 May 2021 00:51:20 -0400 Received: from verein.lst.de ([213.95.11.211]:33194 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbhEZEvU (ORCPT ); Wed, 26 May 2021 00:51:20 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3ADA76736F; Wed, 26 May 2021 06:49:44 +0200 (CEST) Date: Wed, 26 May 2021 06:49:43 +0200 From: Christoph Hellwig To: Ulf Hansson Cc: Christoph Hellwig , Jens Axboe , Geert Uytterhoeven , Chris Zankel , Max Filippov , Philipp Reisner , Lars Ellenberg , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Matias Bjorling , Coly Li , Mike Snitzer , Song Liu , Maxim Levitsky , Alex Dubov , Dan Williams , Vishal Verma , Dave Jiang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-block , dm-devel@redhat.com, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc , nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: simplify gendisk and request_queue allocation for bio based drivers Message-ID: <20210526044943.GA28551@lst.de> References: <20210521055116.1053587-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > Hi all, > > > > this series is the first part of cleaning up lifetimes and allocation of > > the gendisk and request_queue structure. It adds a new interface to > > allocate the disk and queue together for bio based drivers, and a helper > > for cleanup/free them when a driver is unloaded or a device is removed. > > May I ask what else you have in the pipe for the next steps? > > The reason why I ask is that I am looking into some issues related to > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card > removal. In the short run not much more than superficial cleanups. Eventually I want bio based drivers to not require a separate request_queue, leaving that purely as a data structure for blk-mq based drivers. But it will take a while until we get there, so it should not block any fixes. For hot unplug handling it might be worth to take a look at nvme, as it is tested a lot for that case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45EF8C2B9F7 for ; Wed, 26 May 2021 04:52:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7DFD60FF0 for ; Wed, 26 May 2021 04:52:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7DFD60FF0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LFqgdCPLmPlZzajY4f+v1QjN8v4peKv7dpwAXZi5I6Y=; b=i4cF+uXyIxiA62 +cUUyOVOc0biMuMnar5ITJHz+rfgvSB2gUD5EJI/2rPVmjVBr7xRU+vtXZ7PhPvH/T+8bZXJWG7Ww 3ssRMJZzOdDS7esSAx6uFQmk2wPW7k7N/Q140yu8PcHq1HZ8BllmxutxIVotlpM0C5qnNX1id79+J +lK0+GwLUxyFPL1pb2NlSjT1ZqrBYkp9UwD1CoRMrMuQfs1l3aTt9++xWGaijlRuk1JKFX1zqMxUs tCCShOh5Np8SF9J934A5HNb0+xyIWXSuCsy0Yfq4K3rXXKB2UyRrU6syKk5ahxeFGKLOnboRbx6CR yJ/s8b25uGr6PlpcckAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lllX7-00AzdH-Hw; Wed, 26 May 2021 04:52:41 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lllUN-00Aylf-Lf for linux-nvme@lists.infradead.org; Wed, 26 May 2021 04:49:53 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3ADA76736F; Wed, 26 May 2021 06:49:44 +0200 (CEST) Date: Wed, 26 May 2021 06:49:43 +0200 From: Christoph Hellwig To: Ulf Hansson Cc: Christoph Hellwig , Jens Axboe , Geert Uytterhoeven , Chris Zankel , Max Filippov , Philipp Reisner , Lars Ellenberg , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Matias Bjorling , Coly Li , Mike Snitzer , Song Liu , Maxim Levitsky , Alex Dubov , Dan Williams , Vishal Verma , Dave Jiang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-block , dm-devel@redhat.com, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev , linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc , nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: simplify gendisk and request_queue allocation for bio based drivers Message-ID: <20210526044943.GA28551@lst.de> References: <20210521055116.1053587-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_214951_883866_9CC44BFD X-CRM114-Status: GOOD ( 22.23 ) X-Mailman-Approved-At: Tue, 25 May 2021 21:52:30 -0700 X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > Hi all, > > > > this series is the first part of cleaning up lifetimes and allocation of > > the gendisk and request_queue structure. It adds a new interface to > > allocate the disk and queue together for bio based drivers, and a helper > > for cleanup/free them when a driver is unloaded or a device is removed. > > May I ask what else you have in the pipe for the next steps? > > The reason why I ask is that I am looking into some issues related to > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card > removal. In the short run not much more than superficial cleanups. Eventually I want bio based drivers to not require a separate request_queue, leaving that purely as a data structure for blk-mq based drivers. But it will take a while until we get there, so it should not block any fixes. For hot unplug handling it might be worth to take a look at nvme, as it is tested a lot for that case. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B6BC2B9F7 for ; Wed, 26 May 2021 04:50:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90B5F613AB for ; Wed, 26 May 2021 04:50:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90B5F613AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FqdmZ74lxz302c for ; Wed, 26 May 2021 14:50:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Fqdm06pDkz2yXl for ; Wed, 26 May 2021 14:49:51 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 3ADA76736F; Wed, 26 May 2021 06:49:44 +0200 (CEST) Date: Wed, 26 May 2021 06:49:43 +0200 From: Christoph Hellwig To: Ulf Hansson Subject: Re: simplify gendisk and request_queue allocation for bio based drivers Message-ID: <20210526044943.GA28551@lst.de> References: <20210521055116.1053587-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Mike Snitzer , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, linux-bcache@vger.kernel.org, Joshua Morris , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, Dave Jiang , Maxim Levitsky , Vishal Verma , Christoph Hellwig , Christian Borntraeger , Geert Uytterhoeven , Matias Bjorling , Nitin Gupta , Vasily Gorbik , linux-xtensa@linux-xtensa.org, Alex Dubov , Heiko Carstens , Coly Li , linux-block , linux-m68k@lists.linux-m68k.org, Philip Kelleher , Dan Williams , Jens Axboe , Chris Zankel , linux-raid@vger.kernel.org, Max Filippov , linux-mmc , Philipp Reisner , Jim Paris , Minchan Kim , Lars Ellenberg , linuxppc-dev Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > Hi all, > > > > this series is the first part of cleaning up lifetimes and allocation of > > the gendisk and request_queue structure. It adds a new interface to > > allocate the disk and queue together for bio based drivers, and a helper > > for cleanup/free them when a driver is unloaded or a device is removed. > > May I ask what else you have in the pipe for the next steps? > > The reason why I ask is that I am looking into some issues related to > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card > removal. In the short run not much more than superficial cleanups. Eventually I want bio based drivers to not require a separate request_queue, leaving that purely as a data structure for blk-mq based drivers. But it will take a while until we get there, so it should not block any fixes. For hot unplug handling it might be worth to take a look at nvme, as it is tested a lot for that case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 6829F4202B2 for ; Wed, 26 May 2021 06:49:47 +0200 (CEST) Date: Wed, 26 May 2021 06:49:43 +0200 From: Christoph Hellwig To: Ulf Hansson Message-ID: <20210526044943.GA28551@lst.de> References: <20210521055116.1053587-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: nvdimm@lists.linux.dev, Mike Snitzer , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, linux-bcache@vger.kernel.org, Joshua Morris , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, Dave Jiang , Maxim Levitsky , Vishal Verma , Christoph Hellwig , Christian Borntraeger , Geert Uytterhoeven , Matias Bjorling , Nitin Gupta , Vasily Gorbik , linux-xtensa@linux-xtensa.org, Alex Dubov , Heiko Carstens , Coly Li , linux-block , linux-m68k@lists.linux-m68k.org, Philip Kelleher , Dan Williams , Jens Axboe , Chris Zankel , linux-raid@vger.kernel.org, Max Filippov , linux-mmc , Philipp Reisner , Jim Paris , Minchan Kim , Lars Ellenberg , linuxppc-dev Subject: Re: [Drbd-dev] simplify gendisk and request_queue allocation for bio based drivers List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > Hi all, > > > > this series is the first part of cleaning up lifetimes and allocation of > > the gendisk and request_queue structure. It adds a new interface to > > allocate the disk and queue together for bio based drivers, and a helper > > for cleanup/free them when a driver is unloaded or a device is removed. > > May I ask what else you have in the pipe for the next steps? > > The reason why I ask is that I am looking into some issues related to > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card > removal. In the short run not much more than superficial cleanups. Eventually I want bio based drivers to not require a separate request_queue, leaving that purely as a data structure for blk-mq based drivers. But it will take a while until we get there, so it should not block any fixes. For hot unplug handling it might be worth to take a look at nvme, as it is tested a lot for that case.