Re: [iio:togreg 150/168] drivers/iio/gyro/adis16260.c:9:1: iwyu: warning: superfluous #include <linux/mutex.h>

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

[-- Attachment #1: Type: text/plain, Size: 4038 bytes --]

On Wed, 26 May 2021 15:33:50 +0800
kernel test robot <rong.a.chen@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> head:   301f7eba67df8868cb22b0ba2af0fc0cdfe70d8a
> commit: 8f8a0d9a9a5b767c7ad79ceb354b1d4bb6eb708b [150/168] iio: adis16260: make use of adis lock helpers
> config: x86_64-randconfig-b001-20210526 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         # apt-get install iwyu # include-what-you-use
>         # https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=8f8a0d9a9a5b767c7ad79ceb354b1d4bb6eb708b
>         git remote add iio https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
>         git fetch --no-tags iio togreg
>         git checkout 8f8a0d9a9a5b767c7ad79ceb354b1d4bb6eb708b
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross C=1 CHECK=iwyu ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> 
> iwyu warnings: (new ones prefixed by >>)
>    drivers/iio/gyro/adis16260.c:18:1: iwyu: warning: superfluous #include <linux/iio/buffer.h>
>    drivers/iio/gyro/adis16260.c:17:1: iwyu: warning: superfluous #include <linux/iio/sysfs.h>
>    drivers/iio/gyro/adis16260.c:8:1: iwyu: warning: superfluous #include <linux/interrupt.h>
> >> drivers/iio/gyro/adis16260.c:9:1: iwyu: warning: superfluous #include <linux/mutex.h>  
>    drivers/iio/gyro/adis16260.c:13:1: iwyu: warning: superfluous #include <linux/sysfs.h>

Thanks.  First time I'd seen this particular checker.  I'll do a sweep and see if it
is practical to clean these out of IIO so we don't waste time on them in future.

Jonathan

> 
> vim +9 drivers/iio/gyro/adis16260.c
> 
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  @9  #include <linux/mutex.h>
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  10  #include <linux/device.h>
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  11  #include <linux/kernel.h>
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  12  #include <linux/spi/spi.h>
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  13  #include <linux/sysfs.h>
> 99c978529a4013 drivers/staging/iio/gyro/adis16260_core.c Paul Gortmaker     2011-07-03  14  #include <linux/module.h>
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  15  
> 06458e277eac2b drivers/staging/iio/gyro/adis16260_core.c Jonathan Cameron   2012-04-25  16  #include <linux/iio/iio.h>
> 06458e277eac2b drivers/staging/iio/gyro/adis16260_core.c Jonathan Cameron   2012-04-25  17  #include <linux/iio/sysfs.h>
> 06458e277eac2b drivers/staging/iio/gyro/adis16260_core.c Jonathan Cameron   2012-04-25 @18  #include <linux/iio/buffer.h>
> 988c79a95e30da drivers/staging/iio/gyro/adis16260_core.c Lars-Peter Clausen 2013-07-17  19  #include <linux/iio/imu/adis.h>
> 089a41985c6c7e drivers/staging/iio/gyro/adis16260_core.c Barry Song         2010-05-12  20  
> 
> :::::: The code at line 9 was first introduced by commit
> :::::: 089a41985c6c7e69c8fe043c0dd397da628254f5 staging: iio: adis16260 digital gyro driver
> 
> :::::: TO: Barry Song <Barry.Song@analog.com>
> :::::: CC: Greg Kroah-Hartman <gregkh@suse.de>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
>