From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46F9DC47082 for ; Wed, 26 May 2021 16:58:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FE69613D7 for ; Wed, 26 May 2021 16:58:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FE69613D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0141781658; Wed, 26 May 2021 18:58:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MKyEs+ZB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C08D80377; Wed, 26 May 2021 18:58:15 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D85C180377 for ; Wed, 26 May 2021 18:58:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id c10so1378221qtx.10 for ; Wed, 26 May 2021 09:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=D17N3Jc6Z8MBfytc+cHazJYDVHH84x6VKq3UIb3UDeY=; b=MKyEs+ZB007vq8QohJz5pgzefVYQbqdmfYiM/n3Ax48bgG0mgm6stZDMdh8KWHhy13 cI9Ea7LqDyT0UpjV1K4AexKPqS3gw/XGrwr9SvKHl9zK3/e1imTSTrc9XLJcmmQkhXNq ThMp9m2sOyAI/X4r8B7Ye1yCUD9nAZV0tTC3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=D17N3Jc6Z8MBfytc+cHazJYDVHH84x6VKq3UIb3UDeY=; b=WzvdFHTpewcsK+R3XZgOilZJZTl86D6By18Uh3Fn1lIQdQjk9xh05OqTIDNkr319dl 6Rgl7YtZh3jsI9frFeZx+AB+IBVZz3so/TntQ8O7Xs6pzKND4cTD14RVc6eE9JiP19w+ sGH4b1Er+oauiNz5Tbgb2/DImfAKA6t83Izeys40fk8Na00QCHtCM56A1pU69oJj2voF rpFOKj57DU3aGE/5s5IHYsgbFxKzInWKOWHSXVd8w1vUM3QeHRspbhMBGJXG+hlh0cEb XHs8bywT+S630erilA5EZQDvwzr8d/Qm0O5aPmLb0+vKCbpyg9iTdw0Fiyqqv6PgddRW AZWA== X-Gm-Message-State: AOAM532GpHN2aGw3H/MswK8QvHuxHD0aDpSLM61Js0D41e9kWeYHbMLk G4ouSCwS3VaFSUhTLVDxah/jCVrJVPaRkg== X-Google-Smtp-Source: ABdhPJy1LHv/jzwBzcRxCTiop1biReu2DC9gPHFNlnBxrhG77X59SHS1nywIK9KrDlR7HQasmOjLCQ== X-Received: by 2002:ac8:7285:: with SMTP id v5mr39342158qto.247.1622048290417; Wed, 26 May 2021 09:58:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2083-4b51-adf2-e538.res6.spectrum.com. [2603:6081:7b01:cbda:2083:4b51:adf2:e538]) by smtp.gmail.com with ESMTPSA id n18sm1954959qkh.13.2021.05.26.09.58.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 May 2021 09:58:09 -0700 (PDT) Date: Wed, 26 May 2021 12:58:08 -0400 From: Tom Rini To: u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas Subject: [scan-admin@coverity.com: New Defects reported by Coverity Scan for Das U-Boot] Message-ID: <20210526165808.GH17669@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U8dGPtp+DHsXOYeW" Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --U8dGPtp+DHsXOYeW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable ----- Forwarded message from scan-admin@coverity.com ----- Date: Tue, 25 May 2021 01:05:20 +0000 (UTC) =46rom: scan-admin@coverity.com To: tom.rini@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot fou= nd with Coverity Scan. 3 new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the re= cent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 3 of 3 defect(s) ** CID 331856: Uninitialized variables (UNINIT) ___________________________________________________________________________= _____________________________ *** CID 331856: Uninitialized variables (UNINIT) /lib/efi_loader/efi_tcg2.c: 921 in create_specid_event() 915 spec_event->spec_version_major =3D 916 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_MAJOR_TPM2; 917 spec_event->spec_errata =3D 918 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_ERRATA_TPM2; 919 spec_event->uintn_size =3D sizeof(efi_uintn_t) / sizeof(u32); 920 =20 >>> CID 331856: Uninitialized variables (UNINIT) >>> Using uninitialized value "supported" when calling "tpm2_get_pcr_in= fo". 921 err =3D tpm2_get_pcr_info(dev, &supported, &active, 922 &spec_event->number_of_algorithms); 923 if (err) 924 goto out; 925 if (spec_event->number_of_algorithms > MAX_HASH_COUNT || 926 spec_event->number_of_algorithms < 1) ** CID 331855: Uninitialized variables (UNINIT) ___________________________________________________________________________= _____________________________ *** CID 331855: Uninitialized variables (UNINIT) /lib/efi_loader/efi_tcg2.c: 921 in create_specid_event() 915 spec_event->spec_version_major =3D 916 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_MAJOR_TPM2; 917 spec_event->spec_errata =3D 918 TCG_EFI_SPEC_ID_EVENT_SPEC_VERSION_ERRATA_TPM2; 919 spec_event->uintn_size =3D sizeof(efi_uintn_t) / sizeof(u32); 920 =20 >>> CID 331855: Uninitialized variables (UNINIT) >>> Using uninitialized value "active" when calling "tpm2_get_pcr_info". 921 err =3D tpm2_get_pcr_info(dev, &supported, &active, 922 &spec_event->number_of_algorithms); 923 if (err) 924 goto out; 925 if (spec_event->number_of_algorithms > MAX_HASH_COUNT || 926 spec_event->number_of_algorithms < 1) ** CID 331854: Control flow issues (NO_EFFECT) /lib/efi_loader/efi_tcg2.c: 752 in efi_tcg2_hash_log_extend_event() ___________________________________________________________________________= _____________________________ *** CID 331854: Control flow issues (NO_EFFECT) /lib/efi_loader/efi_tcg2.c: 752 in efi_tcg2_hash_log_extend_event() 746 if (efi_tcg_event->size < efi_tcg_event->header.header_size + 747 sizeof(u32)) { 748 ret =3D EFI_INVALID_PARAMETER; 749 goto out; 750 } 751 =20 >>> CID 331854: Control flow issues (NO_EFFECT) >>> This less-than-zero comparison of an unsigned value is never true. = "efi_tcg_event->header.pcr_index < 0U". 752 if (efi_tcg_event->header.pcr_index < 0 || 753 efi_tcg_event->header.pcr_index > TPM2_MAX_PCRS) { 754 ret =3D EFI_INVALID_PARAMETER; 755 goto out; 756 } 757 =20 ___________________________________________________________________________= _____________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.n= et/ls/click?upn=3DHRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoA22WlOQ-2By3= ieUvdbKmOyw68TMVT4Kip-2BBzfOGWXJ5yIiYplmPF9KAnKIja4Zd7tU-3DH9_4_EEm8SbLgSDs= aDZif-2Bv7ch8WqhKpLoKErHi4nXpwDNTuOTF5O38i4jL-2BD-2FsmrMh2lPzvREHBhqI8vCJ-2= BIP-2FXhAJ3irlT-2FJk2sTfzSE0n6yvc5mZv-2F1TXb3F0Ev-2FdreWwRhxjJoa-2FPZBEnX6y= Bmc80HGnkfFCmBlGixi3NDktrXT0unG8R8-2B-2BMnfJ5ZEf2wap1no4QCXizq5T9klMZiXxyjw= -3D-3D To manage Coverity Scan email notifications for "tom.rini@gmail.com", cli= ck https://u15810271.ct.sendgrid.net/ls/click?upn=3DHRESupC-2F2Czv4BOaCWWCy= 7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxWeIHzDeopm-2BEWQ6S6K-2FtUHv9ZTk8= qZbuzkkz9sa-2BJFw4elYDyedRVZOC-2ButxjBZdouVmTGuWB6Aj6G7lm7t25-2Biv1B-2B9082= pHzCCex2kqMs-3DrJM5_EEm8SbLgSDsaDZif-2Bv7ch8WqhKpLoKErHi4nXpwDNTuOTF5O38i4j= L-2BD-2FsmrMh2lCbMtreDazwi5HIVw-2FInsq1UjQPSekFOErjT207tnNVPyexr3egGBVAo2ZA= 7Ge-2Fl7I3INbrgnTuXLIb-2FaWaodarJVao56-2BJxiYKJP-2B-2F-2FDlnIXZgenQkkpFLZvm= Z4cmX1xLH9fbJ713T6bqjKF-2Fjt7HQ-3D-3D ----- End forwarded message ----- --=20 Tom --U8dGPtp+DHsXOYeW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmCufhkACgkQFHw5/5Y0 tywQgQv/evCbQT/CV3yOf68qQUtSRxQ7AOPW7H9rl7GccPfnr/qu3bwfnPmv6hmU M9k4IaEHHjeOGb+4utPHPfUPUIalbK8R6pBsTXuzQNqQ1FCrOepbY+1QxUzwUuEC nJglvK2b0VyXCAUoH7UHY95YyzsWAuWhpByYplvWmIEIyE4d9s+zxdCwKY+dIV1M KgYznZZ8bUUVo3c7VFM+3EabZue3O4Z0ULtgk/hDkSJG58is98dW1p9NlgTLj2Cx 3hMgVlODI7qNo9HaRK7t7dRwFV+nwA5fgcmMIrOyzXU86dherqqdmBNvVI3ZpL/6 Dh5Li85W8mlkzNqBfOER3nzkquFNPXIEvrSkewvt8gfi5is0jDSoAqPA40P9R4PL qq4WnGu9eVvPvJhpNz6rxaVqgLgTs7yyExeBxL5F5jwWbDQ5n6ELBc1RuQ5JbWVL rcL9ix+wTjn4IhrlMFcQiGiPW+oPW4z/kMr3tKQ4ghguYWc4tibfr+Kmsj6ibY4q gMoSqwbQ =bwfP -----END PGP SIGNATURE----- --U8dGPtp+DHsXOYeW--