All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mark Brown <broonie@kernel.org>
Cc: Joe Burmeister <joe.burmeister@devtank.co.uk>,
	Phil Elwell <phil@raspberrypi.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH for-5.14] spi: bcm2835: Allow arbitrary number of slaves
Date: Wed, 26 May 2021 21:30:32 +0200	[thread overview]
Message-ID: <20210526193032.GA12952@wunner.de> (raw)
In-Reply-To: <68febff3649a08d5bd0b5cd913d0f9128a634585.1621703200.git.lukas@wunner.de>

On Sat, May 22, 2021 at 09:29:42PM +0200, Lukas Wunner wrote:
> Since commit 571e31fa60b3 ("spi: bcm2835: Cache CS register value for
> ->prepare_message()"), the number of slaves has been limited by a
> compile-time constant.  This was necessitated by statically-sized
> arrays in the driver private data which contain per-slave register
> values.
> 
> As suggested by Mark, move those register values to a per-slave
> controller_state which is allocated on ->setup and freed on ->cleanup.
> The limitation on the number of slaves is thus lifted.
> 
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: Joe Burmeister <joe.burmeister@devtank.co.uk>
> Cc: Phil Elwell <phil@raspberrypi.com>

This patch needs a rebase on commit c7299fea6769 ("spi: Fix spi device
unregister flow") which has just landed in Linus' tree.

So I'm withdrawing the patch and will send a v2 shortly.

Thanks,

Lukas

      reply	other threads:[~2021-05-26 19:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22 19:29 [PATCH for-5.14] spi: bcm2835: Allow arbitrary number of slaves Lukas Wunner
2021-05-26 19:30 ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210526193032.GA12952@wunner.de \
    --to=lukas@wunner.de \
    --cc=broonie@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=joe.burmeister@devtank.co.uk \
    --cc=linux-spi@vger.kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.