Re: [PATCH v12 8/9] media: hantro: Introduce G2/HEVC decoder

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2840 bytes --]

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20210526]
[cannot apply to sunxi/sunxi/for-next pza/reset/next v5.13-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/Add-HANTRO-G2-HEVC-decoder-support-for-IMX8MQ/20210526-204854
base:   git://linuxtv.org/media_tree.git master
config: nios2-randconfig-r024-20210526 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/49e33af970a98ff968cb11dbaaba205bcf748bda
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Benjamin-Gaignard/Add-HANTRO-G2-HEVC-decoder-support-for-IMX8MQ/20210526-204854
        git checkout 49e33af970a98ff968cb11dbaaba205bcf748bda
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/media/hantro/hantro_g2_hevc_dec.c: In function 'hantro_write_addr':
>> drivers/staging/media/hantro/hantro_g2_hevc_dec.c:23:24: warning: right shift count >= width of type [-Wshift-count-overflow]
      23 |  vdpu_write(vpu, (addr >> 32) & 0xffffffff, offset + 4);
         |                        ^~
   In file included from drivers/staging/media/hantro/hantro_g2_hevc_dec.c:9:
   At top level:
   drivers/staging/media/hantro/hantro_g2_regs.h:16:33: warning: 'g2_scaling_list_e' defined but not used [-Wunused-const-variable=]
      16 |  static const struct hantro_reg g2_##name = { \
         |                                 ^~~
   drivers/staging/media/hantro/hantro_g2_regs.h:52:1: note: in expansion of macro 'G2_DEC_REG'
      52 | G2_DEC_REG(scaling_list_e, 5, 24, 0x1);
         | ^~~~~~~~~~


vim +23 drivers/staging/media/hantro/hantro_g2_hevc_dec.c

    17	
    18	static inline void hantro_write_addr(struct hantro_dev *vpu,
    19					     unsigned long offset,
    20					     dma_addr_t addr)
    21	{
    22		vdpu_write(vpu, addr & 0xffffffff, offset);
  > 23		vdpu_write(vpu, (addr >> 32) & 0xffffffff, offset + 4);
    24	}
    25	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34799 bytes --]