From: Mel Gorman <mgorman@suse.de>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"valentin.schneider@arm.com" <valentin.schneider@arm.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"bristot@redhat.com" <bristot@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"guodong.xu@linaro.org" <guodong.xu@linaro.org>,
yangyicong <yangyicong@huawei.com>,
tangchengchang <tangchengchang@huawei.com>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] sched: fair: don't depend on wake_wide if waker and wakee are already in same LLC
Date: Thu, 27 May 2021 13:14:09 +0100 [thread overview]
Message-ID: <20210527121409.GK3672@suse.de> (raw)
In-Reply-To: <7dd00a98d6454d5e92a7d9b936d1aa1c@hisilicon.com>
On Wed, May 26, 2021 at 09:38:19PM +0000, Song Bao Hua (Barry Song) wrote:
> > And no supportive numbers...
>
> Sorry for the confusion.
>
> I actually put some supportive numbers at the below thread which
> derived this patch:
> https://lore.kernel.org/lkml/bbc339cef87e4009b6d56ee37e202daf@hisilicon.com/
>
> when I tried to give Dietmar some pgbench data in that thread,
> I found in kunpeng920, while software ran in one die/numa with
> 24cores sharing LLC, disabling wake_wide() brought the best
> pgbench result.
>
> llc_as_factor don't_use_wake_wide
> Hmean 1 10869.27 ( 0.00%) 10723.08 * -1.34%*
> Hmean 8 19580.59 ( 0.00%) 19469.34 * -0.57%*
> Hmean 12 29643.56 ( 0.00%) 29520.16 * -0.42%*
> Hmean 24 43194.47 ( 0.00%) 43774.78 * 1.34%*
> Hmean 32 40163.23 ( 0.00%) 40742.93 * 1.44%*
> Hmean 48 42249.29 ( 0.00%) 48329.00 * 14.39%*
>
> The test was done by https://github.com/gormanm/mmtests
> and
> ./run-mmtests.sh --config ./configs/config-db-pgbench-timed-ro-medium test_tag
>
Out of curiousity, I briefly tested this on a Zen2 machine which also
has multiple LLCs per node. Only tbench4 was executed and I cancelled
the other tests because of results like this
tbench4
5.13.0-rc2 5.13.0-rc2
vanilla sched-nowakewidellc-v1r1
Hmean 1 349.34 ( 0.00%) 334.18 * -4.34%*
Hmean 2 668.49 ( 0.00%) 659.12 * -1.40%*
Hmean 4 1307.90 ( 0.00%) 1274.35 * -2.57%*
Hmean 8 2482.08 ( 0.00%) 2377.84 * -4.20%*
Hmean 16 4460.06 ( 0.00%) 4656.28 * 4.40%*
Hmean 32 9463.76 ( 0.00%) 8909.61 * -5.86%*
Hmean 64 15865.30 ( 0.00%) 19682.77 * 24.06%*
Hmean 128 24350.06 ( 0.00%) 21593.20 * -11.32%*
Hmean 256 39593.90 ( 0.00%) 31389.33 * -20.72%*
Hmean 512 37851.54 ( 0.00%) 30260.23 * -20.06%*
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2021-05-27 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 9:10 [PATCH] sched: fair: don't depend on wake_wide if waker and wakee are already in same LLC Barry Song
2021-05-26 12:15 ` Peter Zijlstra
2021-05-26 21:38 ` Song Bao Hua (Barry Song)
2021-05-27 12:14 ` Mel Gorman [this message]
2021-05-31 22:21 ` Song Bao Hua (Barry Song)
2021-06-01 7:59 ` Mel Gorman
2021-06-01 8:09 ` Song Bao Hua (Barry Song)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527121409.GK3672@suse.de \
--to=mgorman@suse.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=guodong.xu@linaro.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=song.bao.hua@hisilicon.com \
--cc=tangchengchang@huawei.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.