From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamin Lin Date: Fri, 28 May 2021 09:44:17 +0800 Subject: [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt to yaml format In-Reply-To: References: <20210527102512.20684-1-jamin_lin@aspeedtech.com> <20210527102512.20684-2-jamin_lin@aspeedtech.com> Message-ID: <20210528014416.GA3195@aspeedtech.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit The 05/27/2021 23:20, Andrew Jeffery wrote: > > > On Thu, 27 May 2021, at 19:55, Jamin Lin wrote: > > Convert aspeed i2c to yaml. > > > > Signed-off-by: Jamin Lin > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 86 +++++++++++++++++++ > > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ----------- > > 2 files changed, 86 insertions(+), 49 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > new file mode 100644 > > index 000000000000..1f7064d77708 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs Device > > Tree Bindings > > + > > +maintainers: > > + - Rayn Chen > > + > > +allOf: > > + - $ref: /schemas/i2c/i2c-controller.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-i2c-bus > > + - aspeed,ast2500-i2c-bus > > + - aspeed,ast2600-i2c-bus > > + > > + "#size-cells": > > + const: 0 > > + > > + "#address-cells": > > + const: 1 > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + items: > > + - description: address offset and range of bus > > + - description: address offset and range of bus buffer > > + > > + interrupts: > > + maxItems: 1 > > + description: interrupt number > > + > > + clocks: > > + maxItems: 1 > > + description: > > + root clock of bus, should reference the APB > > + clock in the second cell > > + > > + reset: > > + maxItems: 1 > > + description: phandle to reset controller with the reset number in > > + the second cell > > + > > + bus-frequency: > > + minimum: 500 > > + maximum: 4000000 > > + default: 100000 > > + description: frequency of the bus clock in Hz defaults to 100 kHz > > when not > > + specified > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > + > > +required: > > + - reg > > + - compatible > > + - clocks > > + - resets > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + i2c0: i2c-bus at 40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2500-i2c-bus"; > > + clocks = <&syscon ASPEED_CLK_APB>; > > + resets = <&syscon ASPEED_RESET_I2C>; > > + bus-frequency = <100000>; > > + interrupts = <0>; > > + interrupt-parent = <&i2c_ic>; > > + status = "disabled"; > > + /* Does not need pinctrl properties */ > > Note this actually isn't right and someone (me?) needs to send a patch > to fix the devicetree(s) - the I2C mux properties for bus 0 and 1 just > don't have a group, and so SCL and SDA need to be muxed individually. > > I expect we wound up with this comment by a lack of a match for an > erroneous grep. > > Andrew Understand. Can I change the example as the following or can you give me any suggestion? i2c0: i2c-bus at 40 { #address-cells = <1>; #size-cells = <0>; #interrupt-cells = <1>; reg = <0x40 0x40>; compatible = "aspeed,ast2500-i2c-bus"; clocks = <&syscon ASPEED_CLK_APB>; resets = <&syscon ASPEED_RESET_I2C>; bus-frequency = <100000>; interrupts = <0>; interrupt-parent = <&i2c_ic>; Thanks-Jamin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03CBCC4707F for ; Fri, 28 May 2021 01:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE606613D1 for ; Fri, 28 May 2021 01:44:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234281AbhE1Bp7 (ORCPT ); Thu, 27 May 2021 21:45:59 -0400 Received: from twspam01.aspeedtech.com ([211.20.114.71]:65188 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbhE1Bp7 (ORCPT ); Thu, 27 May 2021 21:45:59 -0400 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 14S1VC2k002352; Fri, 28 May 2021 09:31:12 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 09:44:18 +0800 Date: Fri, 28 May 2021 09:44:17 +0800 From: Jamin Lin To: Andrew Jeffery CC: Rob Herring , Joel Stanley , "Brendan Higgins" , Benjamin Herrenschmidt , Rayn Chen , "open list:I2C SUBSYSTEM HOST DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "moderated list:ARM/ASPEED I2C DRIVER" , Ryan Chen , "Chin-Ting Kuo" , Troy Lee , Steven Lee Subject: Re: [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt to yaml format Message-ID: <20210528014416.GA3195@aspeedtech.com> References: <20210527102512.20684-1-jamin_lin@aspeedtech.com> <20210527102512.20684-2-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 14S1VC2k002352 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org The 05/27/2021 23:20, Andrew Jeffery wrote: > > > On Thu, 27 May 2021, at 19:55, Jamin Lin wrote: > > Convert aspeed i2c to yaml. > > > > Signed-off-by: Jamin Lin > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 86 +++++++++++++++++++ > > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ----------- > > 2 files changed, 86 insertions(+), 49 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > new file mode 100644 > > index 000000000000..1f7064d77708 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs Device > > Tree Bindings > > + > > +maintainers: > > + - Rayn Chen > > + > > +allOf: > > + - $ref: /schemas/i2c/i2c-controller.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-i2c-bus > > + - aspeed,ast2500-i2c-bus > > + - aspeed,ast2600-i2c-bus > > + > > + "#size-cells": > > + const: 0 > > + > > + "#address-cells": > > + const: 1 > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + items: > > + - description: address offset and range of bus > > + - description: address offset and range of bus buffer > > + > > + interrupts: > > + maxItems: 1 > > + description: interrupt number > > + > > + clocks: > > + maxItems: 1 > > + description: > > + root clock of bus, should reference the APB > > + clock in the second cell > > + > > + reset: > > + maxItems: 1 > > + description: phandle to reset controller with the reset number in > > + the second cell > > + > > + bus-frequency: > > + minimum: 500 > > + maximum: 4000000 > > + default: 100000 > > + description: frequency of the bus clock in Hz defaults to 100 kHz > > when not > > + specified > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > + > > +required: > > + - reg > > + - compatible > > + - clocks > > + - resets > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + i2c0: i2c-bus@40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2500-i2c-bus"; > > + clocks = <&syscon ASPEED_CLK_APB>; > > + resets = <&syscon ASPEED_RESET_I2C>; > > + bus-frequency = <100000>; > > + interrupts = <0>; > > + interrupt-parent = <&i2c_ic>; > > + status = "disabled"; > > + /* Does not need pinctrl properties */ > > Note this actually isn't right and someone (me?) needs to send a patch > to fix the devicetree(s) - the I2C mux properties for bus 0 and 1 just > don't have a group, and so SCL and SDA need to be muxed individually. > > I expect we wound up with this comment by a lack of a match for an > erroneous grep. > > Andrew Understand. Can I change the example as the following or can you give me any suggestion? i2c0: i2c-bus@40 { #address-cells = <1>; #size-cells = <0>; #interrupt-cells = <1>; reg = <0x40 0x40>; compatible = "aspeed,ast2500-i2c-bus"; clocks = <&syscon ASPEED_CLK_APB>; resets = <&syscon ASPEED_RESET_I2C>; bus-frequency = <100000>; interrupts = <0>; interrupt-parent = <&i2c_ic>; Thanks-Jamin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84A1C47089 for ; Fri, 28 May 2021 01:45:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62C32613D1 for ; Fri, 28 May 2021 01:45:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62C32613D1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FrnZD118Yz301j for ; Fri, 28 May 2021 11:45:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=fail (SPF fail - not authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=jamin_lin@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FrnYk3F7hz2xxq; Fri, 28 May 2021 11:44:56 +1000 (AEST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 14S1VC2k002352; Fri, 28 May 2021 09:31:12 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 09:44:18 +0800 Date: Fri, 28 May 2021 09:44:17 +0800 From: Jamin Lin To: Andrew Jeffery Subject: Re: [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt to yaml format Message-ID: <20210528014416.GA3195@aspeedtech.com> References: <20210527102512.20684-1-jamin_lin@aspeedtech.com> <20210527102512.20684-2-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 14S1VC2k002352 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ryan Chen , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED I2C DRIVER" , Troy Lee , Brendan Higgins , open list , Rob Herring , Rayn Chen , Steven Lee , Chin-Ting Kuo , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "open list:I2C SUBSYSTEM HOST DRIVERS" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" The 05/27/2021 23:20, Andrew Jeffery wrote: > > > On Thu, 27 May 2021, at 19:55, Jamin Lin wrote: > > Convert aspeed i2c to yaml. > > > > Signed-off-by: Jamin Lin > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 86 +++++++++++++++++++ > > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ----------- > > 2 files changed, 86 insertions(+), 49 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > new file mode 100644 > > index 000000000000..1f7064d77708 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs Device > > Tree Bindings > > + > > +maintainers: > > + - Rayn Chen > > + > > +allOf: > > + - $ref: /schemas/i2c/i2c-controller.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-i2c-bus > > + - aspeed,ast2500-i2c-bus > > + - aspeed,ast2600-i2c-bus > > + > > + "#size-cells": > > + const: 0 > > + > > + "#address-cells": > > + const: 1 > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + items: > > + - description: address offset and range of bus > > + - description: address offset and range of bus buffer > > + > > + interrupts: > > + maxItems: 1 > > + description: interrupt number > > + > > + clocks: > > + maxItems: 1 > > + description: > > + root clock of bus, should reference the APB > > + clock in the second cell > > + > > + reset: > > + maxItems: 1 > > + description: phandle to reset controller with the reset number in > > + the second cell > > + > > + bus-frequency: > > + minimum: 500 > > + maximum: 4000000 > > + default: 100000 > > + description: frequency of the bus clock in Hz defaults to 100 kHz > > when not > > + specified > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > + > > +required: > > + - reg > > + - compatible > > + - clocks > > + - resets > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + i2c0: i2c-bus@40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2500-i2c-bus"; > > + clocks = <&syscon ASPEED_CLK_APB>; > > + resets = <&syscon ASPEED_RESET_I2C>; > > + bus-frequency = <100000>; > > + interrupts = <0>; > > + interrupt-parent = <&i2c_ic>; > > + status = "disabled"; > > + /* Does not need pinctrl properties */ > > Note this actually isn't right and someone (me?) needs to send a patch > to fix the devicetree(s) - the I2C mux properties for bus 0 and 1 just > don't have a group, and so SCL and SDA need to be muxed individually. > > I expect we wound up with this comment by a lack of a match for an > erroneous grep. > > Andrew Understand. Can I change the example as the following or can you give me any suggestion? i2c0: i2c-bus@40 { #address-cells = <1>; #size-cells = <0>; #interrupt-cells = <1>; reg = <0x40 0x40>; compatible = "aspeed,ast2500-i2c-bus"; clocks = <&syscon ASPEED_CLK_APB>; resets = <&syscon ASPEED_RESET_I2C>; bus-frequency = <100000>; interrupts = <0>; interrupt-parent = <&i2c_ic>; Thanks-Jamin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C2FC47089 for ; Fri, 28 May 2021 01:46:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40654613D8 for ; Fri, 28 May 2021 01:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40654613D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IXadH4pHabp5SfkB+MgxNM5YivykaAjBqLGMOY+ip14=; b=z2vu6k6upp9P9X 0VEbN/cqeVZSMWHtua6cmUX2uIBj5d3XtLcLG9TUQZESWRYtTtmTnixpYB6D7GdEYWjQZn/m4qidd TiVKCABm57mXWWXdaz2A6STbm+Pq+KmsEbdYZNFKcGRjoRdL2BNbhpmldCz+AfXVhHTnnhd1yY+9E iAQcEhslYnNK/lp4T+mHAsYnTTeanYa3qOFYcCv6rghQ+Tczm3SMJBHhXOoweicZ8nJd68anWJefZ tvasHIWWtIlrU+a9J8fK7KUO/0ohgJkBQmqI9dkX7jvTr2x/oo7Npc10uRdT73m5ahCTDAswtjIdC CUzE1Qeni68/n4MsRvDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmRYS-00B3U2-M4; Fri, 28 May 2021 01:44:52 +0000 Received: from [211.20.114.71] (helo=twspam01.aspeedtech.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmRYO-00B3RS-Af for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 01:44:50 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 14S1VC2k002352; Fri, 28 May 2021 09:31:12 +0800 (GMT-8) (envelope-from jamin_lin@aspeedtech.com) Received: from aspeedtech.com (192.168.100.253) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 28 May 2021 09:44:18 +0800 Date: Fri, 28 May 2021 09:44:17 +0800 From: Jamin Lin To: Andrew Jeffery CC: Rob Herring , Joel Stanley , "Brendan Higgins" , Benjamin Herrenschmidt , Rayn Chen , "open list:I2C SUBSYSTEM HOST DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list , "moderated list:ARM/ASPEED I2C DRIVER" , Ryan Chen , "Chin-Ting Kuo" , Troy Lee , Steven Lee Subject: Re: [PATCH v2 1/1] dt-bindings: aspeed-i2c: Convert txt to yaml format Message-ID: <20210528014416.GA3195@aspeedtech.com> References: <20210527102512.20684-1-jamin_lin@aspeedtech.com> <20210527102512.20684-2-jamin_lin@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [192.168.100.253] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 14S1VC2k002352 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_184448_670212_928BF18C X-CRM114-Status: GOOD ( 24.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 05/27/2021 23:20, Andrew Jeffery wrote: > > > On Thu, 27 May 2021, at 19:55, Jamin Lin wrote: > > Convert aspeed i2c to yaml. > > > > Signed-off-by: Jamin Lin > > --- > > .../devicetree/bindings/i2c/aspeed,i2c.yaml | 86 +++++++++++++++++++ > > .../devicetree/bindings/i2c/i2c-aspeed.txt | 49 ----------- > > 2 files changed, 86 insertions(+), 49 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-aspeed.txt > > > > diff --git a/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > new file mode 100644 > > index 000000000000..1f7064d77708 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i2c/aspeed,i2c.yaml > > @@ -0,0 +1,86 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/i2c/aspeed,i2c.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ASPEED I2C on the AST24XX, AST25XX, and AST26XX SoCs Device > > Tree Bindings > > + > > +maintainers: > > + - Rayn Chen > > + > > +allOf: > > + - $ref: /schemas/i2c/i2c-controller.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - aspeed,ast2400-i2c-bus > > + - aspeed,ast2500-i2c-bus > > + - aspeed,ast2600-i2c-bus > > + > > + "#size-cells": > > + const: 0 > > + > > + "#address-cells": > > + const: 1 > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + items: > > + - description: address offset and range of bus > > + - description: address offset and range of bus buffer > > + > > + interrupts: > > + maxItems: 1 > > + description: interrupt number > > + > > + clocks: > > + maxItems: 1 > > + description: > > + root clock of bus, should reference the APB > > + clock in the second cell > > + > > + reset: > > + maxItems: 1 > > + description: phandle to reset controller with the reset number in > > + the second cell > > + > > + bus-frequency: > > + minimum: 500 > > + maximum: 4000000 > > + default: 100000 > > + description: frequency of the bus clock in Hz defaults to 100 kHz > > when not > > + specified > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > + > > +required: > > + - reg > > + - compatible > > + - clocks > > + - resets > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + i2c0: i2c-bus@40 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + #interrupt-cells = <1>; > > + reg = <0x40 0x40>; > > + compatible = "aspeed,ast2500-i2c-bus"; > > + clocks = <&syscon ASPEED_CLK_APB>; > > + resets = <&syscon ASPEED_RESET_I2C>; > > + bus-frequency = <100000>; > > + interrupts = <0>; > > + interrupt-parent = <&i2c_ic>; > > + status = "disabled"; > > + /* Does not need pinctrl properties */ > > Note this actually isn't right and someone (me?) needs to send a patch > to fix the devicetree(s) - the I2C mux properties for bus 0 and 1 just > don't have a group, and so SCL and SDA need to be muxed individually. > > I expect we wound up with this comment by a lack of a match for an > erroneous grep. > > Andrew Understand. Can I change the example as the following or can you give me any suggestion? i2c0: i2c-bus@40 { #address-cells = <1>; #size-cells = <0>; #interrupt-cells = <1>; reg = <0x40 0x40>; compatible = "aspeed,ast2500-i2c-bus"; clocks = <&syscon ASPEED_CLK_APB>; resets = <&syscon ASPEED_RESET_I2C>; bus-frequency = <100000>; interrupts = <0>; interrupt-parent = <&i2c_ic>; Thanks-Jamin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel