All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@techsingularity.net>
To: David Laight <David.Laight@aculab.com>
Cc: 'Andrii Nakryiko' <andrii.nakryiko@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Michal Suchanek <msuchanek@suse.de>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Jiri Olsa <jolsa@kernel.org>, Hritik Vijay <hritikxx8@gmail.com>,
	bpf <bpf@vger.kernel.org>, Linux-Net <netdev@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/page_alloc: Work around a pahole limitation with zero-sized struct pagesets
Date: Fri, 28 May 2021 10:04:21 +0100	[thread overview]
Message-ID: <20210528090421.GK30378@techsingularity.net> (raw)
In-Reply-To: <8fe547e9e87f40aebce82021d76a2d08@AcuMS.aculab.com>

On Fri, May 28, 2021 at 08:09:39AM +0000, David Laight wrote:
> From: Andrii Nakryiko
> > Sent: 27 May 2021 15:42
> ...
> > I agree that empty structs are useful, but here we are talking about
> > per-CPU variables only, which is the first use case so far, as far as
> > I can see. If we had pahole 1.22 released and widely packaged it could
> > have been a viable option to force it on everyone. 
> ...
> 
> Would it be feasible to put the sources for pahole into the
> kernel repository and build it at the same time as objtool?
> 

We don't store other build dependencies like compilers, binutils etc in
the kernel repository even though minimum versions are mandated.
Obviously tools/ exists but for the most part, they are tools that do
not exist in other repositories and are kernel-specific. I don't know if
pahole would be accepted and it introduces the possibility that upstream
pahole and the kernel fork of it would diverge.

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2021-05-28  9:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26  8:07 [PATCH] mm/page_alloc: Work around a pahole limitation with zero-sized struct pagesets Mel Gorman
2021-05-26  8:16 ` David Hildenbrand
2021-05-26  8:33 ` (BTF) " Michal Suchánek
2021-05-26  9:00   ` Mel Gorman
2021-05-26 17:00   ` Andrii Nakryiko
2021-05-26 17:43     ` Michal Suchánek
2021-05-26 16:57 ` Andrii Nakryiko
2021-05-26 18:13   ` Mel Gorman
2021-05-26 18:41     ` Andrii Nakryiko
2021-05-27  8:04 ` Christoph Hellwig
2021-05-27  9:04   ` Mel Gorman
2021-05-27  9:18     ` Christoph Hellwig
2021-05-27 14:37       ` Andrii Nakryiko
2021-05-27 14:41         ` Andrii Nakryiko
2021-05-28  8:09           ` David Laight
2021-05-28  9:04             ` Mel Gorman [this message]
2021-05-28  9:49               ` David Laight
2021-05-28  9:56                 ` Michal Suchánek
2021-05-28 13:09                   ` David Laight
2021-05-30  0:46             ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210528090421.GK30378@techsingularity.net \
    --to=mgorman@techsingularity.net \
    --cc=David.Laight@aculab.com \
    --cc=acme@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hch@infradead.org \
    --cc=hritikxx8@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=msuchanek@suse.de \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.