Re: [RFC PATCH v6 04/27] nvme-tcp-offload: Add device scan implementation

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4765 bytes --]

Hi Shai,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linus/master]
[also build test WARNING on v5.13-rc3 next-20210527]
[cannot apply to ipvs/master sparc-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210528-080853
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 97e5bf604b7a0d6e1b3e00fe31d5fd4b9bffeaae
config: x86_64-randconfig-a013-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6505c630407c5feec818f0bb1c284f9eeebf2071)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/e0686b51cd419d2cb3fe66deea80199b2238d41b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shai-Malin/NVMeTCP-Offload-ULP-and-QEDN-Device-Driver/20210528-080853
        git checkout e0686b51cd419d2cb3fe66deea80199b2238d41b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/nvme/host/tcp-offload.c:79:5: warning: no previous prototype for function 'nvme_tcp_ofld_report_queue_err' [-Wmissing-prototypes]
   int nvme_tcp_ofld_report_queue_err(struct nvme_tcp_ofld_queue *queue)
       ^
   drivers/nvme/host/tcp-offload.c:79:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int nvme_tcp_ofld_report_queue_err(struct nvme_tcp_ofld_queue *queue)
   ^
   static 
   drivers/nvme/host/tcp-offload.c:97:6: warning: no previous prototype for function 'nvme_tcp_ofld_req_done' [-Wmissing-prototypes]
   void nvme_tcp_ofld_req_done(struct nvme_tcp_ofld_req *req,
        ^
   drivers/nvme/host/tcp-offload.c:97:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void nvme_tcp_ofld_req_done(struct nvme_tcp_ofld_req *req,
   ^
   static 
>> drivers/nvme/host/tcp-offload.c:105:1: warning: no previous prototype for function 'nvme_tcp_ofld_lookup_dev' [-Wmissing-prototypes]
   nvme_tcp_ofld_lookup_dev(struct nvme_tcp_ofld_ctrl *ctrl)
   ^
   drivers/nvme/host/tcp-offload.c:104:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct nvme_tcp_ofld_dev *
   ^
   static 
   drivers/nvme/host/tcp-offload.c:16:42: warning: unused function 'to_tcp_ofld_ctrl' [-Wunused-function]
   static inline struct nvme_tcp_ofld_ctrl *to_tcp_ofld_ctrl(struct nvme_ctrl *nctrl)
                                            ^
   4 warnings generated.


vim +/nvme_tcp_ofld_lookup_dev +105 drivers/nvme/host/tcp-offload.c

    85	
    86	/**
    87	 * nvme_tcp_ofld_req_done() - NVMeTCP Offload request done callback
    88	 * function. Pointed to by nvme_tcp_ofld_req->done.
    89	 * Handles both NVME_TCP_F_DATA_SUCCESS flag and NVMe CQ.
    90	 * @req:	NVMeTCP offload request to complete.
    91	 * @result:     The nvme_result.
    92	 * @status:     The completion status.
    93	 *
    94	 * API function that allows the vendor specific offload driver to report request
    95	 * completions to the common offload layer.
    96	 */
  > 97	void nvme_tcp_ofld_req_done(struct nvme_tcp_ofld_req *req,
    98				    union nvme_result *result,
    99				    __le16 status)
   100	{
   101		/* Placeholder - complete request with/without error */
   102	}
   103	
   104	struct nvme_tcp_ofld_dev *
 > 105	nvme_tcp_ofld_lookup_dev(struct nvme_tcp_ofld_ctrl *ctrl)
   106	{
   107		struct nvme_tcp_ofld_dev *dev;
   108	
   109		mutex_lock(&nvme_tcp_ofld_devices_mutex);
   110		list_for_each_entry(dev, &nvme_tcp_ofld_devices, entry) {
   111			if (dev->ops->claim_dev(dev, &ctrl->conn_params))
   112				goto out;
   113		}
   114	
   115		dev = NULL;
   116	out:
   117		mutex_unlock(&nvme_tcp_ofld_devices_mutex);
   118	
   119		return dev;
   120	}
   121	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42884 bytes --]