From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1534DC47080 for ; Mon, 31 May 2021 10:20:34 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBDF4610E7 for ; Mon, 31 May 2021 10:20:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBDF4610E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 97DAD83AC7; Mon, 31 May 2021 10:20:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DnxYw4HDQpPO; Mon, 31 May 2021 10:20:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTP id 41E1283AB4; Mon, 31 May 2021 10:20:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 11F24C000E; Mon, 31 May 2021 10:20:32 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id C7E65C0001 for ; Mon, 31 May 2021 10:20:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B4C1340377 for ; Mon, 31 May 2021 10:20:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GYVTpvEXdsBD for ; Mon, 31 May 2021 10:20:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2A0C6401FD for ; Mon, 31 May 2021 10:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622456427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h+I4L8Ybm0KB4Gou+uepbAq9mkXVhCftc/wwnbvVOfU=; b=NfXjIhRpvB2g1f9UjfQEGkm4RE88jQmj7bt30Fs2KFIB8/+5K3F1f+AwSZ9Sud7qZpiYU3 ddV+DFjLVzYyL5JLo64GCF4iypXSr8jlVG3kicXspPrEpRgGtwJzV1OL5soy0R5oKKd8T2 BSLnCau13HOlbEBnc/yqdY0OUQWC6QU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-_snnUtbwOCqlwGgY_ppdAA-1; Mon, 31 May 2021 06:20:26 -0400 X-MC-Unique: _snnUtbwOCqlwGgY_ppdAA-1 Received: by mail-wr1-f72.google.com with SMTP id z4-20020adfe5440000b0290114f89c9931so1573539wrm.17 for ; Mon, 31 May 2021 03:20:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h+I4L8Ybm0KB4Gou+uepbAq9mkXVhCftc/wwnbvVOfU=; b=PXsYzT76NNWRpRmVLwoGRDSxwZjZG+rmduRAtRbdSZK4amD4yGvlCZtIw3VB0gKzlt wsdEiYJ4t5vksWr5xHv04jXlzyp5qxmP3HlVwpEt9dEZ7yUXcNj5pE3zegaItKiTEGJD eOIJMtJI+9aOd7jkeJN7KNUreZInt++hIV5As2YYLDFSgP28LaaHgLYgsoXC9VnD5NUY AVmwsCaTuTMHE3EwimwSiOEjJfWMMGrhiGmM5YJy1961CZXoMyzXTmb5SOOcVDZfHFCX YW6RtAndjajzNdCMNaFhwOdKRAYKQvJj0g6faOakYzsVf4ZOgCZ+QOY4ebEhZ7d58/HF 7EBg== X-Gm-Message-State: AOAM531oFyE7fzjXT8Q5LiUZC3PNFvV08Vk3lS59mwbuxt1R1OxNVqe1 pfsvGuJSZqBew1rzRDqvrWdKZ4HdhInDUHC9zN3sLPljyVIk/tXmjL6u8MkRiVWQwCUgsPdu6rA qptOrmP1fYa8L8eIQtox78wwZKWxdzVoz68DdQtl9pA== X-Received: by 2002:a7b:c7c6:: with SMTP id z6mr20568568wmk.35.1622456424933; Mon, 31 May 2021 03:20:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPYHUVdhYBLl6N+z8Oi12/8I7xJS2//O9Zz03YW4kCtGt7KRIltZrH+UlPPfleL3cO8QH9mQ== X-Received: by 2002:a7b:c7c6:: with SMTP id z6mr20568557wmk.35.1622456424786; Mon, 31 May 2021 03:20:24 -0700 (PDT) Received: from redhat.com ([2a00:a040:196:94e6::1002]) by smtp.gmail.com with ESMTPSA id u8sm5115260wrb.77.2021.05.31.03.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 03:20:24 -0700 (PDT) Date: Mon, 31 May 2021 06:20:20 -0400 From: "Michael S. Tsirkin" To: "Zhu, Lingshan" Subject: Re: [PATCH RESEND 1/2] virtio: update virtio id table, add transitional ids Message-ID: <20210531061955-mutt-send-email-mst@kernel.org> References: <20210531072743.363171-1-lingshan.zhu@intel.com> <20210531072743.363171-2-lingshan.zhu@intel.com> <20210531095804.47629646.cohuck@redhat.com> <53862384-be2b-4a5f-adbb-37eb25ec9fe1@intel.com> MIME-Version: 1.0 In-Reply-To: <53862384-be2b-4a5f-adbb-37eb25ec9fe1@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: netdev@vger.kernel.org, Cornelia Huck , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, May 31, 2021 at 05:57:47PM +0800, Zhu, Lingshan wrote: > > > On 5/31/2021 3:58 PM, Cornelia Huck wrote: > > On Mon, 31 May 2021 15:27:42 +0800 > > Zhu Lingshan wrote: > > > > > This commit updates virtio id table by adding transitional device > > > ids > > > virtio_pci_common.h > > > Signed-off-by: Zhu Lingshan > > > --- > > > include/uapi/linux/virtio_ids.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h > > > index f0c35ce8628c..fcc9ec6a73c1 100644 > > > --- a/include/uapi/linux/virtio_ids.h > > > +++ b/include/uapi/linux/virtio_ids.h > > > @@ -57,4 +57,16 @@ > > > #define VIRTIO_ID_BT 28 /* virtio bluetooth */ > > > #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ > > > +/* > > > + * Virtio Transitional IDs > > > + */ > > > + > > > +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */ > > > +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */ > > > +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */ > > > +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */ > > > +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */ > > > +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */ > > > +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */ > > > + > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > Isn't this a purely virtio-pci concept? (The spec lists the virtio ids > > in the common section, and those transitional ids in the pci section.) > > IOW, is there a better, virtio-pci specific, header for this? > Hi Cornelia, > > yes they are pure virtio-pci transitional concept. There is a virtio_pci.h, > but not looks like > a good place for these stuffs, Michael ever suggested to add these ids to > virtio_ids.h, so I have > chosen this file. > > https://www.spinics.net/lists/netdev/msg739269.html Didn't think straight, virtio_pci.h is better. > Thanks > Zhu Lingshan > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2830C47082 for ; Mon, 31 May 2021 10:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AC5E611CA for ; Mon, 31 May 2021 10:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231296AbhEaKWK (ORCPT ); Mon, 31 May 2021 06:22:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:29451 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231283AbhEaKWJ (ORCPT ); Mon, 31 May 2021 06:22:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622456429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h+I4L8Ybm0KB4Gou+uepbAq9mkXVhCftc/wwnbvVOfU=; b=ED1/MRfNBtXi8RWgpJk8Q16ERjrjDdpJF29y7YqEQ+m144VUD5NPpNcF1XBb/3QSKGnyvH ugAWI7VKqhMXLokB/pqSGvgarbsq0IrnBNiFaf3M8SdtPGAg6zhLpAJJPi2U+j71+oMUT0 ISneGiwk0eQcU2mmSO8DRt+eEFx+ecM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-348-I2vkDMB3MnKxc9QshipBGA-1; Mon, 31 May 2021 06:20:26 -0400 X-MC-Unique: I2vkDMB3MnKxc9QshipBGA-1 Received: by mail-wr1-f71.google.com with SMTP id n2-20020adfb7420000b029010e47b59f31so3766944wre.9 for ; Mon, 31 May 2021 03:20:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=h+I4L8Ybm0KB4Gou+uepbAq9mkXVhCftc/wwnbvVOfU=; b=HAyBk0sWi4ILYjzBO4nGBtQ32XebCOM6oQjTpJXdjeYIY+rgweo28ezLLETENdk1so TK0APPPru5u5omAUDRjOZVKuN6BEWa/6nGtgKNYq/KqP4GqXB4axB+AhdCx7cjcivUUn v3qaNZ2I9F/KWRMtIbN52dNiu/gQ4Joqp7uUykAIwVMPAKaHds/trVeMu7cZxuzhEarU 06vmmIdB+naVzbhjVyqqy689r9L9n38TogRnQbqRWcY4Z/ZS5WY8u8H1QaYNYCrp/DvX eO83vvVC8Thj2YY4VP8VGMRKsUturZzHtEvvCxmWR3Hi3N5saRYMgPcxHgvC+BuIuuY9 49kg== X-Gm-Message-State: AOAM532m//DDYTOPttj16pA7nZ4vs7iTsd7Y6+Oa/HhnJA2SFRZVzT0R PH+GnXbqsdp19ulE9HyqweK83V5hEHcFFVBtzafXi76PYxYIDfB3sfmsApFC00QN5MuvBxfHDvT 5wvy0+mAklFKM X-Received: by 2002:a7b:c7c6:: with SMTP id z6mr20568571wmk.35.1622456424963; Mon, 31 May 2021 03:20:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPYHUVdhYBLl6N+z8Oi12/8I7xJS2//O9Zz03YW4kCtGt7KRIltZrH+UlPPfleL3cO8QH9mQ== X-Received: by 2002:a7b:c7c6:: with SMTP id z6mr20568557wmk.35.1622456424786; Mon, 31 May 2021 03:20:24 -0700 (PDT) Received: from redhat.com ([2a00:a040:196:94e6::1002]) by smtp.gmail.com with ESMTPSA id u8sm5115260wrb.77.2021.05.31.03.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 May 2021 03:20:24 -0700 (PDT) Date: Mon, 31 May 2021 06:20:20 -0400 From: "Michael S. Tsirkin" To: "Zhu, Lingshan" Cc: Cornelia Huck , jasowang@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH RESEND 1/2] virtio: update virtio id table, add transitional ids Message-ID: <20210531061955-mutt-send-email-mst@kernel.org> References: <20210531072743.363171-1-lingshan.zhu@intel.com> <20210531072743.363171-2-lingshan.zhu@intel.com> <20210531095804.47629646.cohuck@redhat.com> <53862384-be2b-4a5f-adbb-37eb25ec9fe1@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53862384-be2b-4a5f-adbb-37eb25ec9fe1@intel.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, May 31, 2021 at 05:57:47PM +0800, Zhu, Lingshan wrote: > > > On 5/31/2021 3:58 PM, Cornelia Huck wrote: > > On Mon, 31 May 2021 15:27:42 +0800 > > Zhu Lingshan wrote: > > > > > This commit updates virtio id table by adding transitional device > > > ids > > > virtio_pci_common.h > > > Signed-off-by: Zhu Lingshan > > > --- > > > include/uapi/linux/virtio_ids.h | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/include/uapi/linux/virtio_ids.h b/include/uapi/linux/virtio_ids.h > > > index f0c35ce8628c..fcc9ec6a73c1 100644 > > > --- a/include/uapi/linux/virtio_ids.h > > > +++ b/include/uapi/linux/virtio_ids.h > > > @@ -57,4 +57,16 @@ > > > #define VIRTIO_ID_BT 28 /* virtio bluetooth */ > > > #define VIRTIO_ID_MAC80211_HWSIM 29 /* virtio mac80211-hwsim */ > > > +/* > > > + * Virtio Transitional IDs > > > + */ > > > + > > > +#define VIRTIO_TRANS_ID_NET 1000 /* transitional virtio net */ > > > +#define VIRTIO_TRANS_ID_BLOCK 1001 /* transitional virtio block */ > > > +#define VIRTIO_TRANS_ID_BALLOON 1002 /* transitional virtio balloon */ > > > +#define VIRTIO_TRANS_ID_CONSOLE 1003 /* transitional virtio console */ > > > +#define VIRTIO_TRANS_ID_SCSI 1004 /* transitional virtio SCSI */ > > > +#define VIRTIO_TRANS_ID_RNG 1005 /* transitional virtio rng */ > > > +#define VIRTIO_TRANS_ID_9P 1009 /* transitional virtio 9p console */ > > > + > > > #endif /* _LINUX_VIRTIO_IDS_H */ > > Isn't this a purely virtio-pci concept? (The spec lists the virtio ids > > in the common section, and those transitional ids in the pci section.) > > IOW, is there a better, virtio-pci specific, header for this? > Hi Cornelia, > > yes they are pure virtio-pci transitional concept. There is a virtio_pci.h, > but not looks like > a good place for these stuffs, Michael ever suggested to add these ids to > virtio_ids.h, so I have > chosen this file. > > https://www.spinics.net/lists/netdev/msg739269.html Didn't think straight, virtio_pci.h is better. > Thanks > Zhu Lingshan > >