From: Christoph Hellwig <hch@lst.de>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: anup@brainfault.org, Christoph Hellwig <hch@lst.de>,
pbonzini@redhat.com, Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: remove unused SBI helpers and exports
Date: Mon, 31 May 2021 08:34:16 +0200 [thread overview]
Message-ID: <20210531063416.GA1143@lst.de> (raw)
In-Reply-To: <mhng-76155150-9e67-4125-a970-d805d38c7831@palmerdabbelt-glaptop>
On Sat, May 29, 2021 at 04:48:56PM -0700, Palmer Dabbelt wrote:
> I know the general rule is to only take code with callers, but these are
> defined by the SBI so I figured we'd make everyone's lives a bit easier by
> just keeping them around.
Keeping unused code never helps anyone. Adding code without any known
users like some of the others is even worse. And given that sbi_ecall
is exported (and just a trivial inline asm wrapper) there is no point
in having most of the helpers at all, but that is another story.
So for now I'd suggest to merge my patch, and changing any new code
to just use sbi_ecall instead of the remove wrappes as there is no
point in bloating the core kernel with trivial wrappers only used by
a single module.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-05-31 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 7:20 [PATCH] riscv: remove unused SBI helpers and exports Christoph Hellwig
2021-05-27 13:10 ` Anup Patel
2021-05-27 13:15 ` Paolo Bonzini
2021-05-27 13:17 ` Christoph Hellwig
2021-05-27 13:24 ` Anup Patel
2021-05-29 23:48 ` Palmer Dabbelt
2021-05-31 6:34 ` Christoph Hellwig [this message]
2021-05-27 13:21 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531063416.GA1143@lst.de \
--to=hch@lst.de \
--cc=anup@brainfault.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.