All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] ext4: fsmap: Fix the block/inode bitmap comment
Date: Mon, 31 May 2021 15:51:01 -0700	[thread overview]
Message-ID: <20210531225101.GA15541@locust> (raw)
In-Reply-To: <e79134132db7ea42f15747b5c669ee91cc1aacdf.1622432690.git.riteshh@linux.ibm.com>

On Mon, May 31, 2021 at 09:19:08AM +0530, Ritesh Harjani wrote:
> While debugging fstest ext4/027 failure, found below comment to be wrong and
> confusing. Hence fix it while we are at it.
> 
> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>

Doh.  Thanks for fixing that.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/ext4/fsmap.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/fsmap.h b/fs/ext4/fsmap.h
> index 68c8001fee85..ac642be2302e 100644
> --- a/fs/ext4/fsmap.h
> +++ b/fs/ext4/fsmap.h
> @@ -50,7 +50,7 @@ int ext4_getfsmap(struct super_block *sb, struct ext4_fsmap_head *head,
>  #define EXT4_FMR_OWN_INODES	FMR_OWNER('X', 5) /* inodes */
>  #define EXT4_FMR_OWN_GDT	FMR_OWNER('f', 1) /* group descriptors */
>  #define EXT4_FMR_OWN_RESV_GDT	FMR_OWNER('f', 2) /* reserved gdt blocks */
> -#define EXT4_FMR_OWN_BLKBM	FMR_OWNER('f', 3) /* inode bitmap */
> -#define EXT4_FMR_OWN_INOBM	FMR_OWNER('f', 4) /* block bitmap */
> +#define EXT4_FMR_OWN_BLKBM	FMR_OWNER('f', 3) /* block bitmap */
> +#define EXT4_FMR_OWN_INOBM	FMR_OWNER('f', 4) /* inode bitmap */
>  
>  #endif /* __EXT4_FSMAP_H__ */
> -- 
> 2.31.1
> 

  reply	other threads:[~2021-05-31 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31  3:49 [PATCH] ext4: fsmap: Fix the block/inode bitmap comment Ritesh Harjani
2021-05-31 22:51 ` Darrick J. Wong [this message]
2021-06-24 13:48 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210531225101.GA15541@locust \
    --to=djwong@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=riteshh@linux.ibm.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.