From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id'
Date: Tue, 1 Jun 2021 10:05:03 +0100 [thread overview]
Message-ID: <20210601090503.GY543307@dell> (raw)
In-Reply-To: <20210528103532.5n6zzr26hqglvz2p@pengutronix.de>
On Fri, 28 May 2021, Uwe Kleine-König wrote:
> Hey Lee,
>
> On Fri, May 28, 2021 at 10:55:31AM +0100, Lee Jones wrote:
> > On Fri, 28 May 2021, Uwe Kleine-König wrote:
> > > On Fri, May 28, 2021 at 10:06:16AM +0100, Lee Jones wrote:
> > > > diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c
> > > > index b9187e71e0cf2..de3f12c2b80d7 100644
> > > > --- a/drivers/leds/leds-gpio-register.c
> > > > +++ b/drivers/leds/leds-gpio-register.c
> > > > @@ -11,6 +11,7 @@
> > > > /**
> > > > * gpio_led_register_device - register a gpio-led device
> > > > * @pdata: the platform data used for the new device
> > > > + * @id: platform ID
> > > > *
> > >
> > > Given that id is the first parameter and pdata the second I suggest to
> > > swap the order here and describe id first.
> >
> > That's super picky.
> >
> > I can do it as a follow-up patch if you *really* care about it.
>
> I'd say introducing the one-line description for id now in the "wrong"
> location and then reordering as a followup is ridiculus. But having said
> that: I don't care at all.
It's only "wrong" according to you.
I see these presented in a different order to their counterparts all
the time. I do however appreciate that it does make more sense and
is easier on the eye, which is why I am more than happy to rectify.
With regards to the follow-up scenario, it makes far less sense for an
already merged patch in a history tree to be reverted, or for history
to be unnecessarily re-written for something as trivial as this.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-06-01 9:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 9:06 [PATCH 00/15] Rid W=1 warnings from LED Lee Jones
2021-05-28 9:06 ` [PATCH 01/15] leds: trigger: ledtrig-cpu: Fix incorrectly documented param 'ledevt' Lee Jones
2021-05-28 10:03 ` Alexander Dahl
2021-05-28 9:06 ` [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id' Lee Jones
2021-05-28 9:41 ` Uwe Kleine-König
2021-05-28 9:55 ` Lee Jones
2021-05-28 10:35 ` Uwe Kleine-König
2021-06-01 9:05 ` Lee Jones [this message]
2021-06-02 8:24 ` Uwe Kleine-König
2021-06-02 8:33 ` Alexander Dahl
2021-06-04 5:05 ` Uwe Kleine-König
2021-05-28 9:06 ` [PATCH 03/15] leds: led-class: Fix incorrectly documented param 'dev' Lee Jones
2021-05-28 10:10 ` Alexander Dahl
2021-06-01 9:05 ` Lee Jones
2021-05-28 9:06 ` [PATCH 04/15] leds: leds-bcm6328: Demote kernel-doc abuse Lee Jones
2021-05-28 9:06 ` [PATCH 05/15] leds: leds-as3645a: Fix function name 'as3645a_set_current()' Lee Jones
2021-05-28 9:31 ` Sakari Ailus
2021-05-28 9:40 ` Pavel Machek
2021-05-28 9:55 ` Lee Jones
2021-05-28 9:06 ` [PATCH 06/15] leds: leds-blinkm: Remove unused variable 'ret' Lee Jones
2021-05-28 9:06 ` [PATCH 07/15] leds: leds-is31fl32xx: Provide missing description for member 'sw_shutdown_func' Lee Jones
2021-05-28 9:06 ` [PATCH 08/15] leds: leds-lp3944: Provide missing function names in documentation headers Lee Jones
2021-05-28 9:06 ` [PATCH 09/15] leds: leds-lm3530: Fix incorrect spelling of 'brightness' Lee Jones
2021-05-28 9:06 ` [PATCH 10/15] leds: leds-lm3692x: Fix some kernel-doc formatting issues Lee Jones
2021-05-28 9:06 ` [PATCH 11/15] leds: leds-lm3697: Provide some missing descriptions for struct members Lee Jones
2021-05-28 9:06 ` [PATCH 12/15] leds: leds-mlxreg: Fix incorrect documentation of struct member 'led_cdev' and 'led_cdev_name' Lee Jones
2021-05-28 9:06 ` [PATCH 13/15] leds: leds-lp8860: Fix kernel-doc related formatting issues Lee Jones
2021-05-28 9:06 ` [PATCH 14/15] leds: leds-lm3692x: Demote non-complete kernel-doc Lee Jones
2021-05-28 9:39 ` Pavel Machek
2021-05-28 9:56 ` Lee Jones
2021-05-28 9:06 ` [PATCH 15/15] leds: leds-mlxcpld: Fix a bunch of kernel-doc formatting issues Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601090503.GY543307@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.