From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] media: av7110_v4l: Fix build error
Date: Tue, 1 Jun 2021 11:19:10 +0200 [thread overview]
Message-ID: <20210601111910.11df774f@coco.lan> (raw)
In-Reply-To: <20210601111617.5856e175@coco.lan>
Em Tue, 1 Jun 2021 11:16:17 +0200
Mauro Carvalho Chehab <mchehab@kernel.org> escreveu:
> Em Wed, 9 Sep 2020 21:38:44 +0800
> YueHaibing <yuehaibing@huawei.com> escreveu:
>
> > drivers/media/pci/ttpci/av7110_v4l.c: In function ‘vidioc_s_frequency’:
> > drivers/media/pci/ttpci/av7110_v4l.c:163:11: error: SSE register return with SSE disabled
> > if (freq < 16U * 168.25)
> > ~~~~~^~~~~~~~~~~~~~
> > Get rid of float pointing math to fix this.
>
> Out of curiosity: what compiler are you using? This sounds to be a compiler
> issue, as compiler should be optimizing the code by doing the math evaluation
> at compile time instead of doing it during runtime.
Nevermind. A similar patch was already applied upstream.
Please ignore this e-mail.
Thanks,
Mauro
prev parent reply other threads:[~2021-06-01 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 13:38 [PATCH -next] media: av7110_v4l: Fix build error YueHaibing
2021-06-01 9:16 ` Mauro Carvalho Chehab
2021-06-01 9:19 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601111910.11df774f@coco.lan \
--to=mchehab@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.