Re: [PATCH 1/7] mips: ar7: convert to clkdev_lookup

["Russell King (Oracle)" <linux@armlinux.org.uk>]

On Mon, May 31, 2021 at 08:47:43PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> ar7 is one of only two platforms that provide the clock interface but
> implement a custom version of the clkdev_lookup code.
> 
> Change this to use the generic version instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/mips/Kconfig     |  1 +
>  arch/mips/ar7/clock.c | 32 ++++++++++++--------------------
>  2 files changed, 13 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index ed51970c08e7..1cc03a7652a9 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -215,6 +215,7 @@ config AR7
>  	select SYS_SUPPORTS_ZBOOT_UART16550
>  	select GPIOLIB
>  	select VLYNQ
> +	select CLKDEV_LOOKUP
>  	select HAVE_LEGACY_CLK
>  	help
>  	  Support for the Texas Instruments AR7 System-on-a-Chip
> diff --git a/arch/mips/ar7/clock.c b/arch/mips/ar7/clock.c
> index 95def949c971..c614f254f370 100644
> --- a/arch/mips/ar7/clock.c
> +++ b/arch/mips/ar7/clock.c
> @@ -5,6 +5,7 @@
>   * Copyright (C) 2009 Florian Fainelli <florian@openwrt.org>
>   */
>  
> +#include <linux/clkdev.h>
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/types.h>
> @@ -14,6 +15,7 @@
>  #include <linux/io.h>
>  #include <linux/err.h>
>  #include <linux/clk.h>
> +#include <linux/clkdev.h>

Did you mean to include this twice?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!