Re: [PATCH] input: add SparkFun Qwiic Joystick driver

[Rob Herring <robh@kernel.org>]

On Mon, May 31, 2021 at 11:18:29PM -0700, Dmitry Torokhov wrote:
> Hi Oleh,
> 
> On Mon, May 31, 2021 at 04:32:43PM +0300, Oleh Kravchenko wrote:
> > A simple analog joystick built on Low Power ATtiny85 Microcontroller.
> > Directional movements are measured with two 10 kΩ potentiometers
> > connected with a gimbal mechanism that separates the horizontal and
> > vertical movements. This joystick also has a select button that is actuated
> > when the joystick is pressed down.
> > 
> > Input events polled over the I2C bus.
> 
> Thank you for the driver.
> 
> > 
> > Product page:
> > https://www.sparkfun.com/products/15168
> > Firmware and hardware sources:
> > https://github.com/sparkfun/Qwiic_Joystick
> > 
> > Tested on RPi4B and O4-iMX-NANO boards.
> > 
> > Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Cc: Device Tree mailing list <devicetree@vger.kernel.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Jiri Kosina <jikos@jikos.cz>
> > Cc: Patchwork Bot <patchwork-bot@kernel.org>
> > Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
> > ---
> >  .../bindings/input/qwiic-joystick.yaml        |  31 ++++
> >  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
> >  drivers/input/joystick/Kconfig                |   9 +
> >  drivers/input/joystick/Makefile               |   1 +
> >  drivers/input/joystick/qwiic-joystick.c       | 169 ++++++++++++++++++
> >  5 files changed, 212 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/input/qwiic-joystick.yaml
> >  create mode 100644 drivers/input/joystick/qwiic-joystick.c
> > 
> > diff --git a/Documentation/devicetree/bindings/input/qwiic-joystick.yaml b/Documentation/devicetree/bindings/input/qwiic-joystick.yaml
> > new file mode 100644
> > index 000000000000..51cadeb350f2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/qwiic-joystick.yaml
> > @@ -0,0 +1,31 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +# Copyright 2021 Oleh Kravchenko
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/input/qwiic-joystick.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: SparkFun Qwiic Joystick
> > +
> > +maintainers:
> > +  - Oleh Kravchenko <oleg@kaa.org.ua>
> > +
> > +description: |
> > +  Bindings for SparkFun Qwiic Joystick (COM-15168).
> > +  https://www.sparkfun.com/products/15168
> > +
> > +properties:
> > +  compatible:
> > +    const: sparkfun,qwiic-joystick
> 
> Rob, is this compatible acceptable?

Yes.

> 
> > +
> > +required:
> > +  - compatible
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    qwiic@20 {
> > +        compatible = "sparkfun,qwiic-joystick";
> > +        reg = <0x20>;
> > +    };
> 
> I think this device would be covered by
> Documentation/devicetree/bindings/trivial-devices.yaml so please add its
> compatible there.

That's fine. Or not.

Please make bindings a separate patch.

Rob