From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Mark Brown <broonie@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
devicetree@vger.kernel.org,
Iskren Chernev <iskren.chernev@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 7/7] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
Date: Wed, 2 Jun 2021 15:06:09 -0500 [thread overview]
Message-ID: <20210602200609.GA3900200@robh.at.kernel.org> (raw)
In-Reply-To: <20210526172036.183223-8-krzysztof.kozlowski@canonical.com>
On Wed, 26 May 2021 13:20:36 -0400, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 14577/77836 datasheets describe the interrupt line as active
> low with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Iskren Chernev <iskren.chernev@gmail.com>
>
> ---
>
> Changes since v1:
> 1. Remove the 'flags' variable.
> 2. Added ack.
> 3. Rebase - the bindings were converted to dtschema.
> ---
> .../devicetree/bindings/power/supply/maxim,max17040.yaml | 2 +-
> drivers/power/supply/max17040_battery.c | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-06-02 20:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 17:20 [PATCH v2 0/7] mfd/power/rtc: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 1/7] mfd: sec-irq: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 2/7] mfd: max77686: " Krzysztof Kozlowski
2021-05-26 22:33 ` Stephen Boyd
2021-05-26 17:20 ` [PATCH v2 3/7] mfd: max77693: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 4/7] mfd: max14577: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 5/7] rtc: max77686: " Krzysztof Kozlowski
2021-05-26 17:20 ` [PATCH v2 6/7] power: supply: max17042: " Krzysztof Kozlowski
2021-06-04 10:00 ` Sebastian Reichel
2021-05-26 17:20 ` [PATCH v2 7/7] power: supply: max17040: " Krzysztof Kozlowski
2021-06-02 20:06 ` Rob Herring [this message]
2021-06-04 10:01 ` Sebastian Reichel
2021-06-01 15:41 ` [PATCH v2 0/7] mfd/power/rtc: " Lee Jones
2021-06-01 16:13 ` Krzysztof Kozlowski
2021-06-20 20:22 ` (subset) " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602200609.GA3900200@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.