From: David Teigland <teigland@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH]pvchange: Fix the deadlock problem
Date: Wed, 2 Jun 2021 16:45:54 -0500 [thread overview]
Message-ID: <20210602214554.GA31884@redhat.com> (raw)
In-Reply-To: <eed37eea-bf93-158e-6366-cc6e338851c8@huawei.com>
On Tue, Jun 01, 2021 at 04:14:39PM +0800, Wu Guanghao wrote:
> Hi,
>
> I found a deadlock problem during testing?the reason is that the pvchange command
> did not acquire the global lock first.
> + if (!lock_global(cmd, "ex"))
> + return_ECMD_FAILED;
> +
> clear_hint_file(cmd);
Thanks, that's correct, but I changed it a bit to avoid invalidating the
hints more than necessary, which also avoids serializing more commands
than necessary.
https://sourceware.org/git/?p=lvm2.git;a=commit;h=2bce6faed017df8da3e659eff3f42f39d25c7f09
prev parent reply other threads:[~2021-06-02 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:14 [PATCH]pvchange: Fix the deadlock problem Wu Guanghao
2021-06-02 21:45 ` David Teigland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210602214554.GA31884@redhat.com \
--to=teigland@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.