From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH mchinth] platform/x86: sw_copy_driver_interface_info_i can be static
Date: Thu, 03 Jun 2021 11:44:33 +0800 [thread overview]
Message-ID: <20210603034433.GA44263@7e00ed148fbe> (raw)
In-Reply-To: <202106031111.jAttDVEM-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 4156 bytes --]
drivers/platform/x86/socwatch/sw_collector.c:85:33: warning: symbol 'sw_copy_driver_interface_info_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:116:5: warning: symbol 'sw_init_driver_interface_info_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:138:5: warning: symbol 'sw_init_ops_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:211:24: warning: symbol 'sw_alloc_ops_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:323:6: warning: symbol 'sw_free_driver_interface_info_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:329:6: warning: symbol 'sw_free_ops_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:335:5: warning: symbol 'sw_reset_driver_interface_info_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:453:6: warning: symbol 'sw_free_collector_msg_i' was not declared. Should it be static?
drivers/platform/x86/socwatch/sw_collector.c:459:6: warning: symbol 'sw_handle_per_cpu_msg_i' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
sw_collector.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/platform/x86/socwatch/sw_collector.c b/drivers/platform/x86/socwatch/sw_collector.c
index 652d5af6113ba..212cf2b4e9645 100644
--- a/drivers/platform/x86/socwatch/sw_collector.c
+++ b/drivers/platform/x86/socwatch/sw_collector.c
@@ -82,7 +82,7 @@ const static struct sw_hw_ops *s_hw_ops;
* Returns: a pointer to the newly allocated sw_driver_interface_info,
* which is a copy of the version passed in via the info pointer.
*/
-struct sw_driver_interface_info *
+static struct sw_driver_interface_info *
sw_copy_driver_interface_info_i(const struct sw_driver_interface_info *info)
{
size_t size;
@@ -113,7 +113,7 @@ sw_copy_driver_interface_info_i(const struct sw_driver_interface_info *info)
return node;
}
-int sw_init_driver_interface_info_i(struct sw_driver_interface_info *info)
+static int sw_init_driver_interface_info_i(struct sw_driver_interface_info *info)
{
/*
* Do any initialization here.
@@ -135,7 +135,7 @@ int sw_init_driver_interface_info_i(struct sw_driver_interface_info *info)
return PW_SUCCESS;
}
-int sw_init_ops_i(const struct sw_hw_ops **ops,
+static int sw_init_ops_i(const struct sw_hw_ops **ops,
const struct sw_driver_interface_info *info)
{
int i = 0;
@@ -208,7 +208,7 @@ sw_alloc_collector_msg_i(const struct sw_driver_interface_info *info,
return msg;
}
-const struct sw_hw_ops **sw_alloc_ops_i(pw_u16_t num_io_descriptors)
+static const struct sw_hw_ops **sw_alloc_ops_i(pw_u16_t num_io_descriptors)
{
size_t size = num_io_descriptors * sizeof(struct sw_hw_ops *);
const struct sw_hw_ops **ops = sw_kmalloc(size, GFP_KERNEL);
@@ -320,19 +320,19 @@ int sw_add_driver_info(void *list_head,
return PW_SUCCESS;
}
-void sw_free_driver_interface_info_i(struct sw_driver_interface_info *info)
+static void sw_free_driver_interface_info_i(struct sw_driver_interface_info *info)
{
if (info)
sw_kfree(info);
}
-void sw_free_ops_i(const struct sw_hw_ops **ops)
+static void sw_free_ops_i(const struct sw_hw_ops **ops)
{
if (ops)
sw_kfree(ops);
}
-int sw_reset_driver_interface_info_i(struct sw_driver_interface_info *info)
+static int sw_reset_driver_interface_info_i(struct sw_driver_interface_info *info)
{
/*
* Do any finalization here.
@@ -450,13 +450,13 @@ int sw_handle_driver_io_descriptor(
return PW_SUCCESS;
}
-void sw_free_collector_msg_i(sw_driver_msg_t *msg)
+static void sw_free_collector_msg_i(sw_driver_msg_t *msg)
{
if (msg)
sw_kfree(msg);
}
-void sw_handle_per_cpu_msg_i(void *info, enum sw_wakeup_action action)
+static void sw_handle_per_cpu_msg_i(void *info, enum sw_wakeup_action action)
{
/*
* Basic algo:
prev parent reply other threads:[~2021-06-03 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 3:44 [mchinth: sep_socwatch_linux_5_9 19/41] drivers/platform/x86/sepdk/sep/linuxos.c:244:26: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
2021-06-03 3:44 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603034433.GA44263@7e00ed148fbe \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.