From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 871A8C47097 for ; Thu, 3 Jun 2021 17:08:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6CBB661401 for ; Thu, 3 Jun 2021 17:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232095AbhFCRKl (ORCPT ); Thu, 3 Jun 2021 13:10:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:41918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231570AbhFCRKX (ORCPT ); Thu, 3 Jun 2021 13:10:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6C001613F8; Thu, 3 Jun 2021 17:08:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622740119; bh=FNHdvV5gRfdkfTmM6T5k/QAZ8L1tj0CITsaPmdGBSVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WxEr51jD6zezqV2OJZ20kvAEHYZLiWBe2aSpZMEcVhdqfjbqyN400jXYpO+aTtMAY SdjRm4B+nkQOfnrHAlAg+a2yL6f8trqXO5rgvnekAIOBxVxuBkGDbW7FqbCGFgySYt m7XxT2lvpbOcfUNmcBcW5sbab4ucMBnBO3pkELcxSCn8IjzQIeJ/yP0Ve14GYBX4fR SUi5QeEZbV/jKebS2a9vBZjsV6Hnkj1cE1MM8EXnEEe8/hXPrJOUWv+URc9fLf9YLR P36R1kFldresRmAdHXjG/Msmf22EG8/Y15DKIOX1MUFsatj/AsBJQ82poyOlzMG8B5 Uw69fyEeLXB8w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dinghao Liu , Peter Chen , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 07/39] usb: cdns3: Fix runtime PM imbalance on error Date: Thu, 3 Jun 2021 13:07:57 -0400 Message-Id: <20210603170829.3168708-7-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210603170829.3168708-1-sashal@kernel.org> References: <20210603170829.3168708-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Dinghao Liu [ Upstream commit 07adc0225484fc199e3dc15ec889f75f498c4fca ] When cdns3_gadget_start() fails, a pairing PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu Link: https://lore.kernel.org/r/20210412054908.7975-1-dinghao.liu@zju.edu.cn Signed-off-by: Peter Chen Signed-off-by: Sasha Levin --- drivers/usb/cdns3/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index 0aa85cc07ff1..c24c0e3440e3 100644 --- a/drivers/usb/cdns3/gadget.c +++ b/drivers/usb/cdns3/gadget.c @@ -3255,8 +3255,10 @@ static int __cdns3_gadget_init(struct cdns3 *cdns) pm_runtime_get_sync(cdns->dev); ret = cdns3_gadget_start(cdns); - if (ret) + if (ret) { + pm_runtime_put_sync(cdns->dev); return ret; + } /* * Because interrupt line can be shared with other components in -- 2.30.2