From: Jason Gunthorpe <jgg@nvidia.com>
To: Weihang Li <liweihang@huawei.com>
Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com, Yixing Liu <liuyixing1@huawei.com>
Subject: Re: [PATCH v2 for-next 2/2] RDMA/hns: Support direct WQE of userspace
Date: Thu, 3 Jun 2021 16:12:26 -0300 [thread overview]
Message-ID: <20210603191226.GD1002214@nvidia.com> (raw)
In-Reply-To: <1622705834-19353-3-git-send-email-liweihang@huawei.com>
On Thu, Jun 03, 2021 at 03:37:14PM +0800, Weihang Li wrote:
> + hr_qp->has_mmaped = true;
> + pfn = context->uar.dwqe_page + pgoff;
> + prot = pgprot_device(vma->vm_page_prot);
Why doesn't this use pgprot_writecombine() ? Does the devce really need
nGnRE not GRE?
Jason
next prev parent reply other threads:[~2021-06-03 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 7:37 [PATCH v2 for-next 0/2] RDMA/hns: Add support for userspace Direct WQE Weihang Li
2021-06-03 7:37 ` [PATCH v2 for-next 1/2] RDMA/hns: Refactor hns uar mmap flow Weihang Li
2021-06-03 19:12 ` Jason Gunthorpe
2021-06-10 12:07 ` liweihang
2021-06-03 7:37 ` [PATCH v2 for-next 2/2] RDMA/hns: Support direct WQE of userspace Weihang Li
2021-06-03 19:12 ` Jason Gunthorpe [this message]
2021-06-11 9:03 ` liweihang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603191226.GD1002214@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyixing1@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.