From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
Lama Kayal <lkayal@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: [net-next 06/10] net/mlx5e: Zero-init DIM structures
Date: Thu, 3 Jun 2021 13:11:51 -0700 [thread overview]
Message-ID: <20210603201155.109184-7-saeed@kernel.org> (raw)
In-Reply-To: <20210603201155.109184-1-saeed@kernel.org>
From: Lama Kayal <lkayal@nvidia.com>
Initialize structs to avoid unexpected behavior.
No immediate issue in current code, structs are return values, it's
safer to initialize.
Signed-off-by: Lama Kayal <lkayal@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c
index f410c1268422..69cdc4e41a46 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c
@@ -201,7 +201,7 @@ int mlx5e_validate_params(struct mlx5_core_dev *mdev, struct mlx5e_params *param
static struct dim_cq_moder mlx5e_get_def_tx_moderation(u8 cq_period_mode)
{
- struct dim_cq_moder moder;
+ struct dim_cq_moder moder = {};
moder.cq_period_mode = cq_period_mode;
moder.pkts = MLX5E_PARAMS_DEFAULT_TX_CQ_MODERATION_PKTS;
@@ -214,7 +214,7 @@ static struct dim_cq_moder mlx5e_get_def_tx_moderation(u8 cq_period_mode)
static struct dim_cq_moder mlx5e_get_def_rx_moderation(u8 cq_period_mode)
{
- struct dim_cq_moder moder;
+ struct dim_cq_moder moder = {};
moder.cq_period_mode = cq_period_mode;
moder.pkts = MLX5E_PARAMS_DEFAULT_RX_CQ_MODERATION_PKTS;
--
2.31.1
next prev parent reply other threads:[~2021-06-03 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 20:11 [pull request][net-next 00/10] mlx5 updates 2021-06-03 Saeed Mahameed
2021-06-03 20:11 ` [net-next 01/10] mlx5: count all link events Saeed Mahameed
2021-06-03 22:30 ` patchwork-bot+netdevbpf
2021-06-03 20:11 ` [net-next 02/10] net/mlx5: Fix duplicate included vhca_event.h Saeed Mahameed
2021-06-03 20:11 ` [net-next 03/10] net/mlx5: check for allocation failure in mlx5_ft_pool_init() Saeed Mahameed
2021-06-03 20:11 ` [net-next 04/10] net/mlx5e: Remove the repeated declaration Saeed Mahameed
2021-06-03 20:11 ` [net-next 05/10] net/mlx5e: IPoIB, Add support for NDR speed Saeed Mahameed
2021-06-03 20:11 ` Saeed Mahameed [this message]
2021-06-03 20:11 ` [net-next 07/10] net/mlx5e: RX, Re-place page pool numa node change logic Saeed Mahameed
2021-06-03 20:11 ` [net-next 08/10] net/mlx5e: Disable TX MPWQE in kdump mode Saeed Mahameed
2021-06-03 20:11 ` [net-next 09/10] net/mlx5e: Disable TLS device offload " Saeed Mahameed
2021-06-03 20:11 ` [net-next 10/10] net/mlx5e: Remove unreachable code in mlx5e_xmit() Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210603201155.109184-7-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lkayal@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.