All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Daniel Kiss <daniel.kiss@arm.com>
Cc: will@kernel.org, Ard.Biesheuvel@arm.com,
	linux-arm-kernel@lists.infradead.org, pcc@google.com
Subject: Re: [PATCH v5 1/2] arm64: Add ARM64_PTR_AUTH_KERNEL config option
Date: Fri, 4 Jun 2021 11:37:55 +0100	[thread overview]
Message-ID: <20210604103755.GB31173@arm.com> (raw)
In-Reply-To: <20210604100437.1658599-2-daniel.kiss@arm.com>

On Fri, Jun 04, 2021 at 12:04:36PM +0200, Daniel Kiss wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 9f1d8566bbf9..c0c0073a70c3 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1481,12 +1481,6 @@ menu "ARMv8.3 architectural features"
>  config ARM64_PTR_AUTH
>  	bool "Enable support for pointer authentication"
>  	default y
[...]
> +config ARM64_PTR_AUTH_KERNEL
> +	bool "Use pointer authentication for kernel"
> +	default y
> +	depends on ARM64_PTR_AUTH

Nitpick: if you only apply this patch and disable ARM64_PTR_AUTH_KERNEL,
I suspect it will go wrong. Maybe make it unselectable in this patch:

config ARM64_PTR_AUTH_KERNEL
	bool
	default y
	depends on ARM64_PTR_AUTH

and add the description in the next one, once all the other bits are in
place (for bisectability reasons):

With that:

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-04 11:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 10:04 [PATCH v5 0/2] arm64: split ARM64_PTR_AUTH option to userspace and kernel Daniel Kiss
2021-06-04 10:04 ` [PATCH v5 1/2] arm64: Add ARM64_PTR_AUTH_KERNEL config option Daniel Kiss
2021-06-04 10:37   ` Catalin Marinas [this message]
2021-06-08 11:58   ` Will Deacon
2021-06-13  9:25     ` Daniel Kiss
2021-06-04 10:04 ` [PATCH v5 2/2] arm64: Conditionally configure PTR_AUTH key of the kernel Daniel Kiss
2021-06-04 11:04   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604103755.GB31173@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=Ard.Biesheuvel@arm.com \
    --cc=daniel.kiss@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=pcc@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.