All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
	neil@brown.name
Subject: Re: [PATCH 5/5] staging: mt7621-pci: parse some dt properties from root port child nodes
Date: Mon, 7 Jun 2021 09:59:34 +0300	[thread overview]
Message-ID: <20210607065934.GM1955@kadam> (raw)
In-Reply-To: <20210605073023.21435-6-sergio.paracuellos@gmail.com>

On Sat, Jun 05, 2021 at 09:30:23AM +0200, Sergio Paracuellos wrote:
> Properties 'clocks', 'resets' and 'phys' have been moved from parent
> node to the root port childs. Hence we have to adapt the way device
> tree is parsed in driver code to properly align things and make all
> the stuff work.
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

It sounds like this commit needs a fixes tag?  What does "to properly
align things and make all the stuff work." in terms of what the user
sees?

regards,
dan carpenter


  reply	other threads:[~2021-06-07  7:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-05  7:30 [PATCH 0/5] staging: mt7621-pci: some required changes after first review Sergio Paracuellos
2021-06-05  7:30 ` [PATCH 1/5] staging: mt7621-pci: make cleaner 'mt7621_pcie_enable_ports' Sergio Paracuellos
2021-06-05  7:30 ` [PATCH 2/5] staging: mt7621-pci: remove 'RALINK_PCI_BAR0SETUP_ADDR' definition Sergio Paracuellos
2021-06-05  7:30 ` [PATCH 3/5] staging: mt7621-pci: use {readl|writel}_relaxed instead of readl/writel Sergio Paracuellos
2021-06-05  7:30 ` [PATCH 4/5] staging: mt7621-dts: move some properties into root port child nodes Sergio Paracuellos
2021-06-05  7:30 ` [PATCH 5/5] staging: mt7621-pci: parse some dt properties from " Sergio Paracuellos
2021-06-07  6:59   ` Dan Carpenter [this message]
2021-06-07  7:11     ` Sergio Paracuellos
2021-06-07 10:37       ` Dan Carpenter
2021-06-07 11:10         ` Sergio Paracuellos
2021-06-07 11:30           ` Sergio Paracuellos
2021-06-07 12:05             ` Dan Carpenter
2021-06-07 12:09               ` Sergio Paracuellos
2021-06-07 13:20           ` Dan Carpenter
2021-06-07 14:17             ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607065934.GM1955@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=neil@brown.name \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.