From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A64AC47094 for ; Mon, 7 Jun 2021 11:40:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4729E610FC for ; Mon, 7 Jun 2021 11:40:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4729E610FC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 007DC82836; Mon, 7 Jun 2021 13:40:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EwtGMcoJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A91182AAC; Mon, 7 Jun 2021 13:40:15 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F3F8C814A4 for ; Mon, 7 Jun 2021 13:40:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id hf3so2713768qvb.1 for ; Mon, 07 Jun 2021 04:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=dsn1TuwxMhcGVdc3yvpPAtmy6dXPlD7mUT6d5LBRKak=; b=EwtGMcoJaGJsg9kYevuOqj5LtDzYFYZcm/drk+yqr+ZBtDRLXofel6/QrfoGsI0x/Y uYY/FDEoiT3Vv8ybQgWGpqUTcmXQWopyTanE95gc74R0gaqkwtswkTngwp5cKXR5s+Aj mHKjZQz3P1bUUGJpKllTTopwp3Qpo4JvyBTAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=dsn1TuwxMhcGVdc3yvpPAtmy6dXPlD7mUT6d5LBRKak=; b=to0Dw4STBN/TdT8PyzKtWt1abP0J7YOv9QaRamDtXF3zpYnh54qnWDak9K87IUAUE9 4JW2BmDvJi1Kg/YOY+R6/ZZNxF5Yu1kmF5ZCObyhniTyCsLcsM8z7DhAFcHEkNc0NpdW SHSiJ9HrTQrItTsHIAPjByoMh1qCVbiiMvGPcUeNuZGzVGQiYtOcVAK+WWgB7BE8OztB GCv/s3RniGrqq35viUP9GJDrfRY3/f4Dc8t9Qe6dBW6jh0lr5MPNbXla/YTcF+PjGuYl ImVDIlUh/PRY6nEvLzXz85p6n2k3alPAdWE1RnMxtxGYPeX+liWD3ORT/NmLb6K9C+Dg 8fbw== X-Gm-Message-State: AOAM530QZgdrF6LJgXL0pgRPTo7lj6DNf320VTFmDGciQ/U4HOh1h32y 6xfl88LGlYzG+lrMoXmZEsGW1g== X-Google-Smtp-Source: ABdhPJyP3Yrhmj0hkPUo/C5PMiaVo9t/wvEdh5zBNI5iX3dGEqi/F65Z0cRNVLY/o9edmgNoCMYfGQ== X-Received: by 2002:a0c:b911:: with SMTP id u17mr7786013qvf.14.1623066009755; Mon, 07 Jun 2021 04:40:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9db4-c0b7-56c2-7ad9.res6.spectrum.com. [2603:6081:7b01:cbda:9db4:c0b7:56c2:7ad9]) by smtp.gmail.com with ESMTPSA id n16sm325476qtk.40.2021.06.07.04.40.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 07 Jun 2021 04:40:08 -0700 (PDT) Date: Mon, 7 Jun 2021 07:40:07 -0400 From: Tom Rini To: Lokesh Vutla Cc: Jan Kiszka , U-Boot Mailing List , Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng , Simon Glass Subject: Re: [PATCH v2 4/5] watchdog: rti_wdt: Add support for loading firmware Message-ID: <20210607114007.GD9516@bill-the-cat> References: <88d7d3e323c27417d7109b8a92bf53a08ad77654.1622626660.git.jan.kiszka@siemens.com> <96039724-9a5f-dbb8-d46b-b268a0d9a8c2@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GyRA7555PLgSTuth" Content-Disposition: inline In-Reply-To: <96039724-9a5f-dbb8-d46b-b268a0d9a8c2@ti.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --GyRA7555PLgSTuth Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 07, 2021 at 03:33:52PM +0530, Lokesh Vutla wrote: > +Tom, >=20 > Hi Tom, >=20 > On 02/06/21 3:07 pm, Jan Kiszka wrote: > > From: Jan Kiszka > >=20 > > To avoid the need of extra boot scripting on AM65x for loading a > > watchdog firmware, add the required rproc init and loading logic for the > > first R5F core to the watchdog start handler. In case the R5F cluster is > > in lock-step mode, also initialize the second core. The firmware itself > > is embedded into U-Boot binary to ease access to it and ensure it is > > properly hashed in case of secure boot. > >=20 > > One possible firmware source is https://github.com/siemens/k3-rti-wdt. > >=20 > > Signed-off-by: Jan Kiszka > > --- > > drivers/watchdog/Kconfig | 20 ++++++++++++ > > drivers/watchdog/Makefile | 5 +++ > > drivers/watchdog/rti_wdt.c | 58 ++++++++++++++++++++++++++++++++++- > > drivers/watchdog/rti_wdt_fw.S | 20 ++++++++++++ > > 4 files changed, 102 insertions(+), 1 deletion(-) > > create mode 100644 drivers/watchdog/rti_wdt_fw.S > >=20 > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > index f0ff2612a6..1a1fddfe9f 100644 > > --- a/drivers/watchdog/Kconfig > > +++ b/drivers/watchdog/Kconfig > > @@ -209,6 +209,26 @@ config WDT_K3_RTI > > Say Y here if you want to include support for the K3 watchdog > > timer (RTI module) available in the K3 generation of processors. > > =20 > > +if WDT_K3_RTI > > + > > +config WDT_K3_RTI_LOAD_FW > > + bool "Load watchdog firmware" > > + depends on REMOTEPROC > > + help > > + Automatically load the specified firmware image into the MCU R5F > > + core 0. On the AM65x, this firmware is supposed to handle the expiry > > + of the watchdog timer, typically by resetting the system. > > + > > +config WDT_K3_RTI_FW_FILE > > + string "Watchdog firmware image file" > > + default "k3-rti-wdt.fw" > > + depends on WDT_K3_RTI_LOAD_FW > > + help > > + Firmware image to be embedded into U-Boot and loaded on watchdog > > + start. >=20 > I need your input on this proach. Is it okay to include the linker file u= nders > drivers? Maybe? I suppose the first thing that springs to mind is why aren't we using binman and including this blob (which I happily see is GPLv2) similar to how we do things with x86 for one example. --=20 Tom --GyRA7555PLgSTuth Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmC+BZMACgkQFHw5/5Y0 tyyfOwv+LvIku8ZEQuqXzkODkxPsqzhnKCbFd6Q0mNEsBnHSg0w7JGOvFwrdqg1A xkVpOUL7kLiyf12XT9sWZc3POE+CytuSmQS2KCYcbrY8pUiM3Rz0s+4PoY6GOA9C gyfrwUx07CxY5Ly1vOnYmRUNqDPoJZlmG/U9iDJcJjW5JKcWmmLrbbx29sf5rqAN rQzdXdj+9oCyOhE7p4SNXlhgmm1ZQv/02UqpW0tr3l9eyz0eUn8ba/CWT1iKCUkM AJRh5D2NIrk7uuMJ4Uodh3mdqAaJGK/nGvXiYth6rAV9w69KZZv3UKHj5gqVuS7/ 3JV9YxIA2hlwrgXIFFKsN3FxLDW4d+1fZ0P9hMCfMqHy2jrK4Sez3YFEtnVALz0n 5fwbw3jD/kLoCZUK6qilG7UEwRKRSGDdpvP+PkNu4Ghyv021HTAmUuMRKeVVb6sr c8l6DCG5Onnhhr5ck5j9EtIY/GC1ylRTSZB6S3qb/Cm8ufMpepp70LdsinA0mFSM wt8uv6Xk =kR+g -----END PGP SIGNATURE----- --GyRA7555PLgSTuth--