All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 try2 3/4] completion: bash: fix for multiple dash commands
Date: Mon, 7 Jun 2021 21:00:46 +0200	[thread overview]
Message-ID: <20210607190046.GB6312@szeder.dev> (raw)
In-Reply-To: <20210606184726.1018460-4-felipe.contreras@gmail.com>

On Sun, Jun 06, 2021 at 01:47:25PM -0500, Felipe Contreras wrote:
> Otherwise commands like 'for-each-ref' are not completed.

I think you meant that options of commands like 'for-each-ref' are not
completed.  The command itself can be completed just fine:

  $ git for<TAB>
  for-each-ref      format-patch      

> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 05606609f9..1feb2ee108 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -421,7 +421,7 @@ __gitcomp_builtin ()
>  	local incl="${2-}"
>  	local excl="${3-}"
>  
> -	local var=__gitcomp_builtin_"${cmd/-/_}"
> +	local var=__gitcomp_builtin_"${cmd//-/_}"
>  	local options
>  	eval "options=\${$var-}"
>  
> -- 
> 2.31.1.2.g0532ba4bf6
> 

  reply	other threads:[~2021-06-07 19:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 18:47 [PATCH v2 try2 0/4] completion: bash: a bunch of fixes Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-07 19:00   ` SZEDER Gábor [this message]
2021-06-07 19:11     ` Felipe Contreras
2021-06-08  5:15       ` Junio C Hamano
2021-06-08  5:49         ` Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 4/4] completion: bash: add correct suffix in variables Felipe Contreras
2021-06-07  0:46 ` [PATCH v2 try2 0/4] completion: bash: a bunch of fixes David Aguilar
2021-06-07  1:08   ` Junio C Hamano
2021-06-08  6:00 ` [PATCH v3 " Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 4/4] completion: bash: add correct suffix in variables Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607190046.GB6312@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.