Re: [PATCH rdma-next] irdma: Use list_last_entry/list_first_entry

[Jason Gunthorpe <jgg@nvidia.com>]

On Tue, Jun 08, 2021 at 02:44:14PM -0500, Shiraz Saleem wrote:
> Use list_last_entry and list_first_entry instead of using prev and next
> pointers.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
>  drivers/infiniband/hw/irdma/puda.c  | 2 +-
>  drivers/infiniband/hw/irdma/utils.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/puda.c b/drivers/infiniband/hw/irdma/puda.c
> index 1805713..e09d3be 100644
> +++ b/drivers/infiniband/hw/irdma/puda.c
> @@ -1419,7 +1419,7 @@ static void irdma_ieq_compl_pfpdu(struct irdma_puda_rsrc *ieq,
>  
>  error:
>  	while (!list_empty(&pbufl)) {
> -		buf = (struct irdma_puda_buf *)(pbufl.prev);
> +		buf = list_last_entry(&pbufl, struct irdma_puda_buf, list);
>  		list_del(&buf->list);
>  		list_add(&buf->list, rxlist);
>  	}

This doesn't apply, nothing like this exists in my tree??

Jason