From: Florian Westphal <fw@strlen.de>
To: coverity-bot <keescook@chromium.org>
Cc: Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Re: Coverity: nf_tables_addchain(): Memory - corruptions
Date: Tue, 8 Jun 2021 22:13:23 +0200 [thread overview]
Message-ID: <20210608201323.GJ20020@breakpoint.cc> (raw)
In-Reply-To: <202106081047.A1AA0551EB@keescook>
coverity-bot <keescook@chromium.org> wrote:
> 2186 nft_trans_chain_policy(trans) = NFT_CHAIN_POLICY_UNSET;
> 2187 if (nft_is_base_chain(chain)) {
> vvv CID 1505166: Memory - corruptions (UNINIT)
> vvv Using uninitialized value "basechain".
> 2188 basechain->ops.hook_ops_type = NF_HOOK_OP_NF_TABLES;
> 2189 nft_trans_chain_policy(trans) = policy;
Hmm, I do not see how is_base_chain() can be true while basechain
pointer is garbage.
However its probably better for readability to move the NF_HOOK_OP_...
assignment closer to where the basechain ops are allocated.
prev parent reply other threads:[~2021-06-08 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 17:47 Coverity: nf_tables_addchain(): Memory - corruptions coverity-bot
2021-06-08 20:13 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608201323.GJ20020@breakpoint.cc \
--to=fw@strlen.de \
--cc=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-next@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.