From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Heinrich Schuchardt <xypron.glpk@gmx.de>
Subject: Re: [PATCH v4 0/2] log: Allow multiple lines and conversion to printf()
Date: Tue, 8 Jun 2021 17:43:09 -0400 [thread overview]
Message-ID: <20210608214309.GZ9516@bill-the-cat> (raw)
In-Reply-To: <20210508194654.1760567-1-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Sat, May 08, 2021 at 01:46:52PM -0600, Simon Glass wrote:
> At present when logging is not enabled, all log() calls become nops. This
> does not seem right, since if the log level is high enough then there
> should be some sort of message. So in that case, this series updates it to
> print the message if the log level is above LOGL_INFO.
>
> This mimics the behaviour for the log_...() macros like log_debug() and
> log_info(), so we can drop the special case for these.
>
> Also the current implementation does not support multiple log calls on the
> same line nicely. The tags are repeated so the line is very hard to read.
> This series adds that as a new feature.
For the series, applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-06-08 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 19:46 [PATCH v4 0/2] log: Allow multiple lines and conversion to printf() Simon Glass
2021-05-08 19:46 ` [PATCH v4 1/2] sandbox: log: Avoid build error with !CONFIG_LOG Simon Glass
2021-05-08 19:46 ` [PATCH v4 2/2] log: Convert log values to printf() if not enabled Simon Glass
2021-06-08 21:43 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608214309.GZ9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.