From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD07DC48BCD for ; Wed, 9 Jun 2021 07:10:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 897CE61361 for ; Wed, 9 Jun 2021 07:10:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 897CE61361 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zary.sk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=nouveau-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 323A86E235; Wed, 9 Jun 2021 07:10:57 +0000 (UTC) Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by gabe.freedesktop.org (Postfix) with ESMTP id 54ED46E20E; Wed, 9 Jun 2021 07:10:55 +0000 (UTC) Received: from [192.168.1.3] (ns.gsystem.sk [62.176.172.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 8496D7A025C; Wed, 9 Jun 2021 09:10:54 +0200 (CEST) From: Ondrej Zary To: Christian =?utf-8?q?K=C3=B6nig?= Date: Wed, 9 Jun 2021 09:10:51 +0200 User-Agent: KMail/1.9.10 References: <202106052143.52488.linux@zary.sk> <202106090857.42133.linux@zary.sk> <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> In-Reply-To: <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Disposition: inline Message-Id: <202106090910.51188.linux@zary.sk> Subject: Re: [Nouveau] nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, Ben Skeggs , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" T24gV2VkbmVzZGF5IDA5IEp1bmUgMjAyMSwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBBbSAw OS4wNi4yMSB1bSAwODo1NyBzY2hyaWViIE9uZHJlaiBaYXJ5Ogo+ID4gW1NOSVBdCj4gPj4gVGhh bmtzIGZvciB0aGUgaGVhZHMgdXAuIFNvIHRoZSBwcm9ibGVtIHdpdGggbXkgcGF0Y2ggaXMgYWxy ZWFkeSBmaXhlZCwKPiA+PiBpc24ndCBpdD8KPiA+IFRoZSBOVUxMIHBvaW50ZXIgZGVyZWZlcmVu Y2UgaW4gbm91dmVhdV9ib193cjE2IGludHJvZHVjZWQgaW4KPiA+IDE0MWIxNWU1OTE3NWFhMTc0 Y2ExZjc1OTYxODhiZDE1YTdjYTE3YmEgd2FzIGZpeGVkIGJ5Cj4gPiBhZWE2NTZiMGQwNWVjNWI4 ZWQ1YmViMmY5NGM0ZGQ0MmVhODM0ZTlkLgo+ID4KPiA+IFRoYXQncyB0aGUgYnVnIEkgaGl0IHdo ZW4gYmlzZWN0aW5nIHRoZSBvcmlnaW5hbCBwcm9ibGVtOgo+ID4gTlVMTCBwb2ludGVyIGRlcmVm ZXJlbmNlIGluIG5vdXZlYXVfYm9fc3luY19mb3JfZGV2aWNlCj4gPiBJdCdzIGNhdXNlZCBieToK PiA+ICMgZmlyc3QgYmFkIGNvbW1pdDogW2UzNGI4ZmVlYWE0YjY1NzI1YjI1ZjQ5YzliMDhhMGY4 NzA3ZThlODZdIGRybS90dG06IG1lcmdlIHR0bV9kbWFfdHQgYmFjayBpbnRvIHR0bV90dAo+IAo+ IEdvb2QgdGhhdCBJJ3ZlIGFza2VkIDopCj4gCj4gT2sgdGhhdCdzIGEgYml0IHN0cmFuZ2UuIGUz NGI4ZmVlYWE0YjY1NzI1YjI1ZjQ5YzliMDhhMGY4NzA3ZThlODYgd2FzIAo+IGNyZWF0ZWQgbW9z dGx5IGF1dG9tYXRlZC4KPiAKPiBEbyB5b3UgaGF2ZSB0aGUgb3JpZ2luYWwgYmFja3RyYWNlIG9m IHRoYXQgTlVMTCBwb2ludGVyIGRlcmVmIG9uY2UgbW9yZT8KClRoZSBvcmlnaW5hbCBiYWNrdHJh Y2UgaXMgaGVyZTogaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMjEvNi81LzM1MAoKLS0gCk9uZHJl aiBaYXJ5Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5v dXZlYXUgbWFpbGluZyBsaXN0Ck5vdXZlYXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vbm91dmVhdQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58431C47095 for ; Wed, 9 Jun 2021 07:10:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5E4A61352 for ; Wed, 9 Jun 2021 07:10:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5E4A61352 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zary.sk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B2776E20E; Wed, 9 Jun 2021 07:10:56 +0000 (UTC) Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by gabe.freedesktop.org (Postfix) with ESMTP id 54ED46E20E; Wed, 9 Jun 2021 07:10:55 +0000 (UTC) Received: from [192.168.1.3] (ns.gsystem.sk [62.176.172.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 8496D7A025C; Wed, 9 Jun 2021 09:10:54 +0200 (CEST) From: Ondrej Zary To: Christian =?utf-8?q?K=C3=B6nig?= Subject: Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device Date: Wed, 9 Jun 2021 09:10:51 +0200 User-Agent: KMail/1.9.10 References: <202106052143.52488.linux@zary.sk> <202106090857.42133.linux@zary.sk> <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> In-Reply-To: <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <202106090910.51188.linux@zary.sk> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, Ben Skeggs , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wednesday 09 June 2021, Christian K=C3=B6nig wrote: > Am 09.06.21 um 08:57 schrieb Ondrej Zary: > > [SNIP] > >> Thanks for the heads up. So the problem with my patch is already fixed, > >> isn't it? > > The NULL pointer dereference in nouveau_bo_wr16 introduced in > > 141b15e59175aa174ca1f7596188bd15a7ca17ba was fixed by > > aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d. > > > > That's the bug I hit when bisecting the original problem: > > NULL pointer dereference in nouveau_bo_sync_for_device > > It's caused by: > > # first bad commit: [e34b8feeaa4b65725b25f49c9b08a0f8707e8e86] drm/ttm:= merge ttm_dma_tt back into ttm_tt >=20 > Good that I've asked :) >=20 > Ok that's a bit strange. e34b8feeaa4b65725b25f49c9b08a0f8707e8e86 was=20 > created mostly automated. >=20 > Do you have the original backtrace of that NULL pointer deref once more? The original backtrace is here: https://lkml.org/lkml/2021/6/5/350 =2D-=20 Ondrej Zary From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC69BC48BCF for ; Wed, 9 Jun 2021 07:10:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE9B76135D for ; Wed, 9 Jun 2021 07:10:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234967AbhFIHMu convert rfc822-to-8bit (ORCPT ); Wed, 9 Jun 2021 03:12:50 -0400 Received: from hosting.gsystem.sk ([212.5.213.30]:56808 "EHLO hosting.gsystem.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233692AbhFIHMt (ORCPT ); Wed, 9 Jun 2021 03:12:49 -0400 Received: from [192.168.1.3] (ns.gsystem.sk [62.176.172.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 8496D7A025C; Wed, 9 Jun 2021 09:10:54 +0200 (CEST) From: Ondrej Zary To: Christian =?utf-8?q?K=C3=B6nig?= Subject: Re: nouveau broken on Riva TNT2 in 5.13.0-rc4: NULL pointer dereference in nouveau_bo_sync_for_device Date: Wed, 9 Jun 2021 09:10:51 +0200 User-Agent: KMail/1.9.10 Cc: Ben Skeggs , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <202106052143.52488.linux@zary.sk> <202106090857.42133.linux@zary.sk> <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> In-Reply-To: <1c4a7360-57e3-c75a-c729-1432db5b90b9@amd.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <202106090910.51188.linux@zary.sk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 09 June 2021, Christian König wrote: > Am 09.06.21 um 08:57 schrieb Ondrej Zary: > > [SNIP] > >> Thanks for the heads up. So the problem with my patch is already fixed, > >> isn't it? > > The NULL pointer dereference in nouveau_bo_wr16 introduced in > > 141b15e59175aa174ca1f7596188bd15a7ca17ba was fixed by > > aea656b0d05ec5b8ed5beb2f94c4dd42ea834e9d. > > > > That's the bug I hit when bisecting the original problem: > > NULL pointer dereference in nouveau_bo_sync_for_device > > It's caused by: > > # first bad commit: [e34b8feeaa4b65725b25f49c9b08a0f8707e8e86] drm/ttm: merge ttm_dma_tt back into ttm_tt > > Good that I've asked :) > > Ok that's a bit strange. e34b8feeaa4b65725b25f49c9b08a0f8707e8e86 was > created mostly automated. > > Do you have the original backtrace of that NULL pointer deref once more? The original backtrace is here: https://lkml.org/lkml/2021/6/5/350 -- Ondrej Zary