From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104BBC48BCF for ; Wed, 9 Jun 2021 15:18:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E984B6128A for ; Wed, 9 Jun 2021 15:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbhFIPUu (ORCPT ); Wed, 9 Jun 2021 11:20:50 -0400 Received: from foss.arm.com ([217.140.110.172]:34304 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230427AbhFIPUV (ORCPT ); Wed, 9 Jun 2021 11:20:21 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C596011FB; Wed, 9 Jun 2021 08:18:25 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74D153F73D; Wed, 9 Jun 2021 08:18:24 -0700 (PDT) Date: Wed, 9 Jun 2021 16:17:24 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , Szabolcs Nagy , Jeremy Linton , "H . J . Lu" , Yu-cheng Yu , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, libc-alpha@sourceware.org Subject: Re: [PATCH v2 3/3] elf: Remove has_interp property from arch_adjust_elf_prot() Message-ID: <20210609151724.GM4187@arm.com> References: <20210604112450.13344-1-broonie@kernel.org> <20210604112450.13344-4-broonie@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210604112450.13344-4-broonie@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Jun 04, 2021 at 12:24:50PM +0100, Mark Brown wrote: > Since we have added an is_interp flag to arch_parse_elf_property() we can > drop the has_interp flag from arch_elf_adjust_prot(), the only user was > the arm64 code which no longer needs it and any future users will be able > to use arch_parse_elf_properties() to determine if an interpreter is in > use. So far so good, but can we also drop the has_interp argument from arch_parse_elf_properties()? Cross-check with Yu-Cheng Yu's series, but I don't see this being used any more (except for passthrough in binfmt_elf.c). Since we are treating the interpreter and main executable orthogonally to each other now, I don't think we should need a has_interp argument to pass knowledge between the interpreter and executable handling phases here. > > Signed-off-by: Mark Brown > --- > arch/arm64/kernel/process.c | 2 +- > fs/binfmt_elf.c | 2 +- > include/linux/elf.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index f7fff4a4c99f..e51c4aa7e048 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -742,7 +742,7 @@ asmlinkage void __sched arm64_preempt_schedule_irq(void) > > #ifdef CONFIG_BINFMT_ELF > int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, > - bool has_interp, bool is_interp) > + bool is_interp) > { > if (prot & PROT_EXEC) { > if (state->flags & ARM64_ELF_INTERP_BTI && is_interp) > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 253ca9969345..1aba4e50e651 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -580,7 +580,7 @@ static inline int make_prot(u32 p_flags, struct arch_elf_state *arch_state, > if (p_flags & PF_X) > prot |= PROT_EXEC; > > - return arch_elf_adjust_prot(prot, arch_state, has_interp, is_interp); > + return arch_elf_adjust_prot(prot, arch_state, is_interp); > } > > /* This is much more generalized than the library routine read function, > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1c45ecf29147..d8392531899d 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -101,11 +101,11 @@ extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz, > > #ifdef CONFIG_ARCH_HAVE_ELF_PROT > int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, > - bool has_interp, bool is_interp); > + bool is_interp); > #else > static inline int arch_elf_adjust_prot(int prot, > const struct arch_elf_state *state, > - bool has_interp, bool is_interp) > + bool is_interp) [...] Otherwise, looks reasonable. Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C863C48BCF for ; Wed, 9 Jun 2021 16:29:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC46E613BF for ; Wed, 9 Jun 2021 16:29:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC46E613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tdqI0Y3E+lAXFGqxwL+aEC2CFaxNzKAczPNsea+F7+A=; b=Vs93YobbqSt0Vd M6+hq2gHBHUt6EqWdxF5AblmN24SSddR4Z2ymF1TkAXAOHl2GRvhAPgyozF6HBWz4CCMg0zVpoDJV t8wrx3KkulmR10QqKFMT4Dix3TPEY+L6HoI56d/br3JCG4XGHU+NZMe8FDWyexYTOsDuL1xuhpWi3 f45IWFVPRMJqfXG8Zm7PDyAOYXKGuUzE17UwZFHbyaIh/mHZoYFJYzuJE3UNjZ24Y8oFtICXsBy30 R70n5eCiNXvlIUYaWcbTuhvbczcEl4HVoHhevHkPSSLfb71IMgGzKbgU99EBWIPLeWCsV4uZ63NCi APgQo5UPsWcAxEjr08sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lr13P-00Ev6N-NL; Wed, 09 Jun 2021 16:27:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqzyM-00EYO7-OZ for linux-arm-kernel@lists.infradead.org; Wed, 09 Jun 2021 15:18:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C596011FB; Wed, 9 Jun 2021 08:18:25 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 74D153F73D; Wed, 9 Jun 2021 08:18:24 -0700 (PDT) Date: Wed, 9 Jun 2021 16:17:24 +0100 From: Dave Martin To: Mark Brown Cc: Catalin Marinas , Will Deacon , Szabolcs Nagy , Jeremy Linton , "H . J . Lu" , Yu-cheng Yu , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, libc-alpha@sourceware.org Subject: Re: [PATCH v2 3/3] elf: Remove has_interp property from arch_adjust_elf_prot() Message-ID: <20210609151724.GM4187@arm.com> References: <20210604112450.13344-1-broonie@kernel.org> <20210604112450.13344-4-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604112450.13344-4-broonie@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210609_081826_933889_24F06052 X-CRM114-Status: GOOD ( 20.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 04, 2021 at 12:24:50PM +0100, Mark Brown wrote: > Since we have added an is_interp flag to arch_parse_elf_property() we can > drop the has_interp flag from arch_elf_adjust_prot(), the only user was > the arm64 code which no longer needs it and any future users will be able > to use arch_parse_elf_properties() to determine if an interpreter is in > use. So far so good, but can we also drop the has_interp argument from arch_parse_elf_properties()? Cross-check with Yu-Cheng Yu's series, but I don't see this being used any more (except for passthrough in binfmt_elf.c). Since we are treating the interpreter and main executable orthogonally to each other now, I don't think we should need a has_interp argument to pass knowledge between the interpreter and executable handling phases here. > > Signed-off-by: Mark Brown > --- > arch/arm64/kernel/process.c | 2 +- > fs/binfmt_elf.c | 2 +- > include/linux/elf.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index f7fff4a4c99f..e51c4aa7e048 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -742,7 +742,7 @@ asmlinkage void __sched arm64_preempt_schedule_irq(void) > > #ifdef CONFIG_BINFMT_ELF > int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, > - bool has_interp, bool is_interp) > + bool is_interp) > { > if (prot & PROT_EXEC) { > if (state->flags & ARM64_ELF_INTERP_BTI && is_interp) > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 253ca9969345..1aba4e50e651 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -580,7 +580,7 @@ static inline int make_prot(u32 p_flags, struct arch_elf_state *arch_state, > if (p_flags & PF_X) > prot |= PROT_EXEC; > > - return arch_elf_adjust_prot(prot, arch_state, has_interp, is_interp); > + return arch_elf_adjust_prot(prot, arch_state, is_interp); > } > > /* This is much more generalized than the library routine read function, > diff --git a/include/linux/elf.h b/include/linux/elf.h > index 1c45ecf29147..d8392531899d 100644 > --- a/include/linux/elf.h > +++ b/include/linux/elf.h > @@ -101,11 +101,11 @@ extern int arch_parse_elf_property(u32 type, const void *data, size_t datasz, > > #ifdef CONFIG_ARCH_HAVE_ELF_PROT > int arch_elf_adjust_prot(int prot, const struct arch_elf_state *state, > - bool has_interp, bool is_interp); > + bool is_interp); > #else > static inline int arch_elf_adjust_prot(int prot, > const struct arch_elf_state *state, > - bool has_interp, bool is_interp) > + bool is_interp) [...] Otherwise, looks reasonable. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel