From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 328F5C48BCF for ; Wed, 9 Jun 2021 15:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 178BB61364 for ; Wed, 9 Jun 2021 15:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234536AbhFIP5l (ORCPT ); Wed, 9 Jun 2021 11:57:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51894 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230311AbhFIP5k (ORCPT ); Wed, 9 Jun 2021 11:57:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623254145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=keilHIV5bACKUg1mjHegqweisKM/7NCx/zq57buVyEU=; b=Ud9zJRS7kOxc6gaSI4GSTLUKuRldHeMyhOhlT/SzOfFRwZt7+NFfhEIf2AUixHkDE0SxS0 6h01CHzOgsEmV6tp2y4vYjPSWyP5T1JDJ1A7nSe+kutHEALCJ9OvGpkm+LWqi9y0EeeXkk 6jMYiYMbEYy3nu+Cho2YRiM2HKQCEms= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-603-6R7Mh9AeMNis9DH0m7jMew-1; Wed, 09 Jun 2021 11:55:43 -0400 X-MC-Unique: 6R7Mh9AeMNis9DH0m7jMew-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95422100A8EE; Wed, 9 Jun 2021 15:55:41 +0000 (UTC) Received: from carbon (unknown [10.36.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 419FC19C45; Wed, 9 Jun 2021 15:55:29 +0000 (UTC) Date: Wed, 9 Jun 2021 17:55:27 +0200 From: Jesper Dangaard Brouer To: Matteo Croce Cc: Grygorii Strashko , Lorenzo Bianconi , netdev@vger.kernel.org, Lorenzo Bianconi , David Miller , Jakub Kicinski , Ilias Apalodimas , brouer@redhat.com, Willem de Bruijn Subject: Re: [RFT net-next] net: ti: add pp skb recycling support Message-ID: <20210609175527.2f321eca@carbon> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 9 Jun 2021 17:43:57 +0200 Matteo Croce wrote: > On Wed, Jun 9, 2021 at 5:03 PM Grygorii Strashko > wrote: > > > > On 09/06/2021 15:20, Matteo Croce wrote: > > > On Wed, Jun 9, 2021 at 2:01 PM Lorenzo Bianconi wrote: > > >> > > >> As already done for mvneta and mvpp2, enable skb recycling for ti > > >> ethernet drivers > > >> > > >> Signed-off-by: Lorenzo Bianconi > > > > > > Looks good! If someone with the HW could provide a with and without > > > the patch, that would be nice! > > > > > > > What test would you recommend to run? > > [...] > > A test which benefits most from this kind of change is one in which > the frames are freed early. I would also recommend running an XDP_PASS program, and then running something that let the packets travel as deep as possible into netstack. Not to test performance, but to make sure we didn't break something! I've hacked up bnxt driver (it's not as straight forward as this driver to convert) and is running some TCP tests. Not problems so-far :-0 I wanted to ask if someone knows howto setup the zero-copy TCP stuff that google did? (but is that TX only?) -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer