From: Jason Wang <jasowang@redhat.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: Jason Wang <jasowang@redhat.com>,
qemu-stable@nongnu.org, Gautam Dawar <gdawar@xilinx.com>
Subject: [PULL 03/12] vhost-vdpa: don't initialize backend_features
Date: Fri, 11 Jun 2021 14:00:15 +0800 [thread overview]
Message-ID: <20210611060024.46763-4-jasowang@redhat.com> (raw)
In-Reply-To: <20210611060024.46763-1-jasowang@redhat.com>
We used to initialize backend_features during vhost_vdpa_init()
regardless whether or not it was supported by vhost. This will lead
the unsupported features like VIRTIO_F_IN_ORDER to be included and set
to the vhost-vdpa during vhost_dev_start. Because the
VIRTIO_F_IN_ORDER is not supported by vhost-vdpa so it won't be
advertised to guest which will break the datapath.
Fix this by not initializing the backend_features, so the
acked_features could be built only from guest features via
vhost_net_ack_features().
Fixes: 108a64818e69b ("vhost-vdpa: introduce vhost-vdpa backend")
Cc: qemu-stable@nongnu.org
Cc: Gautam Dawar <gdawar@xilinx.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/virtio/vhost-vdpa.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 7bcccf1..61ba313 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -268,15 +268,12 @@ static void vhost_vdpa_add_status(struct vhost_dev *dev, uint8_t status)
static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque)
{
struct vhost_vdpa *v;
- uint64_t features;
assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_VDPA);
trace_vhost_vdpa_init(dev, opaque);
v = opaque;
v->dev = dev;
dev->opaque = opaque ;
- vhost_vdpa_call(dev, VHOST_GET_FEATURES, &features);
- dev->backend_features = features;
v->listener = vhost_vdpa_memory_listener;
v->msg_type = VHOST_IOTLB_MSG_V2;
--
2.7.4
next prev parent reply other threads:[~2021-06-11 6:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 6:00 [PULL 00/12] Net patches Jason Wang
2021-06-11 6:00 ` [PULL 01/12] vhost-vdpa: skip ram device from the IOTLB mapping Jason Wang
2021-06-11 6:00 ` [PULL 02/12] vhost-vdpa: map virtqueue notification area if possible Jason Wang
2021-06-11 6:00 ` Jason Wang [this message]
2021-06-11 6:00 ` [PULL 04/12] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features() Jason Wang
2021-06-11 6:00 ` [PULL 05/12] netdev: add more commands to preconfig mode Jason Wang
2021-06-11 6:00 ` [PULL 06/12] Remove some duplicate trace code Jason Wang
2021-06-11 6:00 ` [PULL 07/12] Fix the qemu crash when guest shutdown during checkpoint Jason Wang
2021-06-11 6:00 ` [PULL 08/12] Optimize the function of filter_send Jason Wang
2021-06-11 6:00 ` [PULL 09/12] Remove migrate_set_block_enabled in checkpoint Jason Wang
2021-06-11 6:00 ` [PULL 10/12] Add a function named packet_new_nocopy for COLO Jason Wang
2021-06-11 6:00 ` [PULL 11/12] Add the function of colo_compare_cleanup Jason Wang
2021-06-11 6:00 ` [PULL 12/12] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info() Jason Wang
2021-06-11 12:02 ` [PULL 00/12] Net patches Peter Maydell
2021-06-14 22:43 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611060024.46763-4-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=gdawar@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.