From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up
Date: Mon, 14 Jun 2021 12:03:34 +0200 [thread overview]
Message-ID: <20210614100334.GA10629@lst.de> (raw)
In-Reply-To: <20210614095107.GD26615@quack2.suse.cz>
On Mon, Jun 14, 2021 at 11:51:07AM +0200, Jan Kara wrote:
> On Mon 14-06-21 08:15:12, Christoph Hellwig wrote:
> > Remove the CONFIG_BLOCK default to __set_page_dirty_buffers and just
> > wire that method up for the missing instances.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Make sense. Did you somehow autogenerate this? If this patch would race
> with addition of new aops struct, we'd get null-ptr-defer out of that so
> maybe providing the script would be better. But other than that the changes
> look good to me. You can add:
No, this was done manually as I audited all instances for actually being
able to dirty pages.
next prev parent reply other threads:[~2021-06-14 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 6:15 remove the implicit .set_page_dirty default Christoph Hellwig
2021-06-14 6:15 ` [PATCH 1/3] fs: unexport __set_page_dirty Christoph Hellwig
2021-06-14 6:23 ` Greg Kroah-Hartman
2021-06-14 9:42 ` Jan Kara
2021-06-14 12:32 ` Matthew Wilcox
2021-06-14 15:52 ` Christoph Hellwig
2021-06-14 6:15 ` [PATCH 2/3] fs: move ramfs_aops to libfs Christoph Hellwig
2021-06-14 6:24 ` Greg Kroah-Hartman
2021-06-14 9:45 ` Jan Kara
2021-06-14 6:15 ` [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Christoph Hellwig
2021-06-14 6:24 ` Greg Kroah-Hartman
2021-06-14 9:51 ` Jan Kara
2021-06-14 10:03 ` Christoph Hellwig [this message]
2021-06-18 19:23 ` Dmitry Osipenko
2021-06-21 5:26 ` Christoph Hellwig
2021-06-14 12:23 ` remove the implicit .set_page_dirty default Matthew Wilcox
2021-06-14 15:53 ` Christoph Hellwig
2021-06-14 15:55 ` Christoph Hellwig
2021-06-14 16:17 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614100334.GA10629@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.