From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB7EDC48BDF for ; Tue, 15 Jun 2021 14:56:22 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8173E61581 for ; Tue, 15 Jun 2021 14:56:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8173E61581 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VzqytOvpuwjSMzkrRFUl1X1wSxYrWB3jtNllGP3QL4M=; b=fPivjbuNSohKVu o81tieSAp34gjYqPJnOfcHK5nMq5BtaeJ0F/o9u70ewpVmEyZrFPLC4oTox7aTMXA0goD4++6RuUA BtFRx58TXBkMm4EpTfqywnULNhPFqM8W0bl5blupgoDTOe6v96B3vWfIUSp9CjWRzTlONKs8+6oER NwgTtgLIBDWmsUE85gCfeRnuGjW3S+IS1helcHJAobPwNgOS1pgQUZ6PEMMxDOJsgwma4boJVvN3p f5nr8soUn0bq6DPzDHshziev9Hw0OnxmbFNUUKIAfllFCf0T5exPpEvxkiNehcNGvx5GKsP8cVABq 3cidsuXG2Y+q+iLsFcdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltANO-000htD-0Q; Tue, 15 Jun 2021 14:49:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9Pl-000IhC-QS for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 13:47:39 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4842461462; Tue, 15 Jun 2021 13:47:36 +0000 (UTC) Date: Tue, 15 Jun 2021 14:47:33 +0100 From: Catalin Marinas To: Will Deacon Cc: Yu Zhao , Jia He , Mark Rutland , Marc Zyngier , Suzuki Poulose , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: mm: fix warning in arch_faults_on_old_pte() Message-ID: <20210615134733.GI26027@arm.com> References: <20210613214728.1695340-1-yuzhao@google.com> <20210615105230.GD20225@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615105230.GD20225@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_064737_946026_EA9ECEAB X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 11:52:30AM +0100, Will Deacon wrote: > On Sun, Jun 13, 2021 at 03:47:28PM -0600, Yu Zhao wrote: > > cow_user_page() doesn't disable preemption, and it triggers the > > warning in arch_faults_on_old_pte() when CONFIG_PREEMPT_COUNT=y. > > Doesn't kmap_atomic() disable preemption? Good point, I missed that. I wonder whether there are additional patches on top that replace it with kmap_local_page(). I couldn't see any in -next. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel