From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] fs: Remove anon_set_page_dirty()
Date: Tue, 15 Jun 2021 18:37:56 +0200 [thread overview]
Message-ID: <20210615163756.GD1600@lst.de> (raw)
In-Reply-To: <20210615162342.1669332-5-willy@infradead.org>
On Tue, Jun 15, 2021 at 05:23:40PM +0100, Matthew Wilcox (Oracle) wrote:
> Use __set_page_dirty_no_writeback() instead. This will set the dirty
> bit on the page, which will be used to avoid calling set_page_dirty()
> in the future. It will have no effect on actually writing the page
> back, as the pages are not on any LRU lists.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-06-15 16:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 16:23 [PATCH 0/6] Further set_page_dirty cleanups Matthew Wilcox (Oracle)
2021-06-15 16:23 ` [PATCH 1/6] mm/writeback: Move __set_page_dirty() to core mm Matthew Wilcox (Oracle)
2021-06-15 16:35 ` Christoph Hellwig
2021-06-15 17:17 ` Greg Kroah-Hartman
2021-06-16 16:14 ` Matthew Wilcox
2021-06-15 16:23 ` [PATCH 2/6] mm/writeback: Use __set_page_dirty in __set_page_dirty_nobuffers Matthew Wilcox (Oracle)
2021-06-15 16:35 ` Christoph Hellwig
2021-06-15 17:18 ` Greg Kroah-Hartman
2021-06-15 16:23 ` [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers Matthew Wilcox (Oracle)
2021-06-15 16:37 ` Christoph Hellwig
2021-06-15 17:19 ` Greg Kroah-Hartman
2021-06-15 17:32 ` Matthew Wilcox
2021-06-15 17:34 ` Christoph Hellwig
2021-06-15 18:04 ` Greg Kroah-Hartman
2021-06-15 18:13 ` Matthew Wilcox
2021-06-16 6:50 ` Greg Kroah-Hartman
2021-06-16 16:28 ` Matthew Wilcox
2021-06-16 16:35 ` Greg Kroah-Hartman
2021-06-15 16:23 ` [PATCH 4/6] fs: Remove anon_set_page_dirty() Matthew Wilcox (Oracle)
2021-06-15 16:37 ` Christoph Hellwig [this message]
2021-06-15 16:23 ` [PATCH 5/6] fs: Remove noop_set_page_dirty() Matthew Wilcox (Oracle)
2021-06-15 16:38 ` Christoph Hellwig
2021-06-16 18:10 ` kernel test robot
2021-06-16 18:10 ` kernel test robot
2021-06-16 18:12 ` Matthew Wilcox
2021-06-16 18:12 ` Matthew Wilcox
2021-06-16 22:33 ` kernel test robot
2021-06-16 22:33 ` kernel test robot
2021-06-15 16:23 ` [PATCH 6/6] mm: Move page dirtying prototypes from mm.h Matthew Wilcox (Oracle)
2021-06-15 16:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615163756.GD1600@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.