From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B550C48BDF for ; Fri, 18 Jun 2021 20:17:30 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FF3C61284 for ; Fri, 18 Jun 2021 20:17:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FF3C61284 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6E39E1724; Fri, 18 Jun 2021 22:16:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6E39E1724 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624047446; bh=Zj+ye5PMyu6RWVaxMw4mQZp5tDjiq98KiSHTjkas3NM=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BTUoMt7ZVneasm3+nzc3bG9QpbQdR4Hk6xiR6BQ9ZgsRX7hIxoGXfLtvj69gY57RO 6f21uoeFkxTGnf8jPGT9klr0QfOvFA9boCUwO6reO/OkkFaP6JqmvI6SwjK0oZPDnX YpnPYAhaQo0R+36g8ZKScgnkgOwjCQUtNxj3c558= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DFA7DF802E8; Fri, 18 Jun 2021 22:16:35 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7B023F8032D; Fri, 18 Jun 2021 22:16:34 +0200 (CEST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 83C83F80084 for ; Fri, 18 Jun 2021 22:16:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 83C83F80084 Received: by mail-ot1-f51.google.com with SMTP id q5-20020a9d4b050000b029044ecc922d44so639080otf.7 for ; Fri, 18 Jun 2021 13:16:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lBtHIzlhVk8sJY83HR9VHHtDV8zU8qEhN6lMMc8ccAQ=; b=mJp48jhq5cYmS4+Sv7CMVJ9Cbva3QW9hOK95R7KdRj13X4zd2nhrG+zDAim1vqZQP8 TYrGhZCQxn8XQ/6rbO3ql04P3MAY2HczQ/Mqz2MVPwezEdpg0aYiKnI7i49iO0hrHX5l x37PtnGCtE6zWybx1NtbAxn9cx4I8Z1fSlCxw2h2xpAG8XhTChCZlHes5ArelClSnsSU hPCalFZ2lp9xGC33JpkKQ4+5eiOJVMiAniLVJhyjXSPKWLrUjJPFglpWlYlBSpwwMNFT 3rhWTxKjt4D0F+oDtxz0awkrYGvTYfo7rwbzUkFqHFJ8eQw0jJJm8DH81VOxjTO++Y1N hohA== X-Gm-Message-State: AOAM5331hqjLOtByNI1D2EW5GnK4r3YRpDQTkuQFIwNNVZtwyMjTMznL HoRfJ23wPPWGkUdMUazSXA== X-Google-Smtp-Source: ABdhPJyxP4UQValuX9uYfay5qm8ASFvM1GL7mD27tgWSBBiyyj2DP4FOmSEom/6h9O3OOXV6G3LOZw== X-Received: by 2002:a9d:4b02:: with SMTP id q2mr11111358otf.370.1624047386315; Fri, 18 Jun 2021 13:16:26 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id j3sm1981852oii.46.2021.06.18.13.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 13:16:25 -0700 (PDT) Received: (nullmailer pid 2807200 invoked by uid 1000); Fri, 18 Jun 2021 20:16:21 -0000 Date: Fri, 18 Jun 2021 14:16:21 -0600 From: Rob Herring To: Srinivas Kandagatla Subject: Re: [RFC PATCH 03/13] ASoC: qcom: dt-bindings: add bindings Audio Processing manager Message-ID: <20210618201621.GA2801502@robh.at.kernel.org> References: <20210607152836.17154-1-srinivas.kandagatla@linaro.org> <20210607152836.17154-4-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607152836.17154-4-srinivas.kandagatla@linaro.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, tiwai@suse.de, plai@codeaurora.org, linux-kernel@vger.kernel.org, broonie@kernel.org, bjorn.andersson@linaro.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, Jun 07, 2021 at 04:28:26PM +0100, Srinivas Kandagatla wrote: > This patch adds bindings support for Qualcomm Audio Processing Manager > service in Audio DSP. > > Audio Process Manager is one of the static service in DSP which is > responsible for Command/response handling, graph Management > and Control/Event management between modules. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/sound/qcom,q6apm.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > new file mode 100644 > index 000000000000..9906ef935206 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/sound/qcom,q6apm.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Audio Process Manager binding > + > +maintainers: > + - Srinivas Kandagatla > + > +description: | > + This binding describes the Qualcomm Audio Process Manager service in DSP > + > +properties: > + compatible: > + const: qcom,q6apm > + > + reg: > + maxItems: 1 > + > +#APM Services > +patternProperties: > + "^.*@[0-9a-f]+$": You can drop '^.*'. > + type: object > + description: > + APM devices use subnodes for services. > + > + properties: > + compatible: > + enum: > + - qcom,q6apm-dai > + - qcom,q6apm-bedai > + > + iommus: > + maxItems: 1 > + > + "#sound-dai-cels": cells? How is this optional? > + const: 1 > + > + required: > + - compatible > + - reg > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: true This needs to be false and fix whatever is missing. > + > +examples: > + - | > + gpr { > + #address-cells = <1>; > + #size-cells = <0>; > + gprservice@1 { > + compatible = "qcom,q6apm"; > + reg = <1>; > + > + q6apm-dai { This doesn't match what you have in the schema at all. > + compatible = "qcom,q6apm-dai"; > + #sound-dai-cels = <1>; > + }; > + > + q6apm-bedai { > + compatible = "qcom,q6apm-bedai"; > + #sound-dai-cels = <1>; > + }; > + }; > + }; > -- > 2.21.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C9BC48BE8 for ; Fri, 18 Jun 2021 20:16:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A1F061284 for ; Fri, 18 Jun 2021 20:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbhFRUSg (ORCPT ); Fri, 18 Jun 2021 16:18:36 -0400 Received: from mail-ot1-f41.google.com ([209.85.210.41]:37529 "EHLO mail-ot1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbhFRUSg (ORCPT ); Fri, 18 Jun 2021 16:18:36 -0400 Received: by mail-ot1-f41.google.com with SMTP id 102-20020a9d0eef0000b02903fccc5b733fso10887681otj.4; Fri, 18 Jun 2021 13:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lBtHIzlhVk8sJY83HR9VHHtDV8zU8qEhN6lMMc8ccAQ=; b=gizWLcVjwlD36k+jLMoURodueIdTD4wcSXUVal0/kA40+BUpWw2hKqvfDJOK/DtAKX 46JbFeTuAPcTk6oGiH7kAqoJSF56E+SujF9jI9xFW3hD8GhBMX+dRkqk3pykJ3uqFD5j +C1xtp07QtFHVH2BdlplrnRvkuer1P7Zxc/1d6NomSjPS/yxpuTgIWBhDW5bPiOT8t9a ySGTKSOcAOZX6J8J7z271wjDIV9BGzAUPWWd0KFy0xihIEjqA6co/QngGEa0VZ3U9/0I F3a3IhOfygnAF0YKbuqG1PmpslyP3BE58lwYgxwAsacIJktlqAICwpWbowq00K9yBofM dSBA== X-Gm-Message-State: AOAM530H/q94RmPMdtB4FAIN/HJGK+OLbh7JyI7yLzn2g+R+Fx4UJJsy QKFW1X7/tbEqNhXLFrsL8A== X-Google-Smtp-Source: ABdhPJyxP4UQValuX9uYfay5qm8ASFvM1GL7mD27tgWSBBiyyj2DP4FOmSEom/6h9O3OOXV6G3LOZw== X-Received: by 2002:a9d:4b02:: with SMTP id q2mr11111358otf.370.1624047386315; Fri, 18 Jun 2021 13:16:26 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id j3sm1981852oii.46.2021.06.18.13.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 13:16:25 -0700 (PDT) Received: (nullmailer pid 2807200 invoked by uid 1000); Fri, 18 Jun 2021 20:16:21 -0000 Date: Fri, 18 Jun 2021 14:16:21 -0600 From: Rob Herring To: Srinivas Kandagatla Cc: bjorn.andersson@linaro.org, broonie@kernel.org, plai@codeaurora.org, tiwai@suse.de, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, bgoswami@codeaurora.org Subject: Re: [RFC PATCH 03/13] ASoC: qcom: dt-bindings: add bindings Audio Processing manager Message-ID: <20210618201621.GA2801502@robh.at.kernel.org> References: <20210607152836.17154-1-srinivas.kandagatla@linaro.org> <20210607152836.17154-4-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607152836.17154-4-srinivas.kandagatla@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jun 07, 2021 at 04:28:26PM +0100, Srinivas Kandagatla wrote: > This patch adds bindings support for Qualcomm Audio Processing Manager > service in Audio DSP. > > Audio Process Manager is one of the static service in DSP which is > responsible for Command/response handling, graph Management > and Control/Event management between modules. > > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/sound/qcom,q6apm.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > new file mode 100644 > index 000000000000..9906ef935206 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/sound/qcom,q6apm.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Audio Process Manager binding > + > +maintainers: > + - Srinivas Kandagatla > + > +description: | > + This binding describes the Qualcomm Audio Process Manager service in DSP > + > +properties: > + compatible: > + const: qcom,q6apm > + > + reg: > + maxItems: 1 > + > +#APM Services > +patternProperties: > + "^.*@[0-9a-f]+$": You can drop '^.*'. > + type: object > + description: > + APM devices use subnodes for services. > + > + properties: > + compatible: > + enum: > + - qcom,q6apm-dai > + - qcom,q6apm-bedai > + > + iommus: > + maxItems: 1 > + > + "#sound-dai-cels": cells? How is this optional? > + const: 1 > + > + required: > + - compatible > + - reg > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + > +additionalProperties: true This needs to be false and fix whatever is missing. > + > +examples: > + - | > + gpr { > + #address-cells = <1>; > + #size-cells = <0>; > + gprservice@1 { > + compatible = "qcom,q6apm"; > + reg = <1>; > + > + q6apm-dai { This doesn't match what you have in the schema at all. > + compatible = "qcom,q6apm-dai"; > + #sound-dai-cels = <1>; > + }; > + > + q6apm-bedai { > + compatible = "qcom,q6apm-bedai"; > + #sound-dai-cels = <1>; > + }; > + }; > + }; > -- > 2.21.0 > >