From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
"Ryan J . Barnett" <ryan.barnett@collins.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] dt-bindings: mtd: gpmc: Fix the ECC bytes vs. OOB bytes equation
Date: Fri, 18 Jun 2021 15:19:08 -0600 [thread overview]
Message-ID: <20210618211908.GA2927042@robh.at.kernel.org> (raw)
In-Reply-To: <20210610143945.3504781-1-miquel.raynal@bootlin.com>
On Thu, 10 Jun 2021 16:39:45 +0200, Miquel Raynal wrote:
> "PAGESIZE / 512" is the number of ECC chunks.
> "ECC_BYTES" is the number of bytes needed to store a single ECC code.
> "2" is the space reserved by the bad block marker.
>
> "2 + (PAGESIZE / 512) * ECC_BYTES" should of course be lower or equal
> than the total number of OOB bytes, otherwise it won't fit.
>
> Fix the equation by substituting s/>=/<=/.
>
> Suggested-by: Ryan J. Barnett <ryan.barnett@collins.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Documentation/devicetree/bindings/mtd/gpmc-nand.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: linux-mtd@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
"Ryan J . Barnett" <ryan.barnett@collins.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] dt-bindings: mtd: gpmc: Fix the ECC bytes vs. OOB bytes equation
Date: Fri, 18 Jun 2021 15:19:08 -0600 [thread overview]
Message-ID: <20210618211908.GA2927042@robh.at.kernel.org> (raw)
In-Reply-To: <20210610143945.3504781-1-miquel.raynal@bootlin.com>
On Thu, 10 Jun 2021 16:39:45 +0200, Miquel Raynal wrote:
> "PAGESIZE / 512" is the number of ECC chunks.
> "ECC_BYTES" is the number of bytes needed to store a single ECC code.
> "2" is the space reserved by the bad block marker.
>
> "2 + (PAGESIZE / 512) * ECC_BYTES" should of course be lower or equal
> than the total number of OOB bytes, otherwise it won't fit.
>
> Fix the equation by substituting s/>=/<=/.
>
> Suggested-by: Ryan J. Barnett <ryan.barnett@collins.com>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> Documentation/devicetree/bindings/mtd/gpmc-nand.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-06-18 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 14:39 [PATCH] dt-bindings: mtd: gpmc: Fix the ECC bytes vs. OOB bytes equation Miquel Raynal
2021-06-10 14:39 ` Miquel Raynal
2021-06-18 21:19 ` Rob Herring [this message]
2021-06-18 21:19 ` Rob Herring
2021-07-15 23:08 ` Miquel Raynal
2021-07-15 23:08 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618211908.GA2927042@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=ryan.barnett@collins.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.