All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Shai Malin <smalin@marvell.com>
Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de,
	axboe@fb.com, kbusch@kernel.org, davem@davemloft.net,
	aelior@marvell.com, mkalderon@marvell.com, okulkarni@marvell.com,
	pkushwaha@marvell.com, prabhakar.pkin@gmail.com,
	malin1024@gmail.com
Subject: Re: [PATCH v2 0/8] NVMeTCP Offload ULP
Date: Mon, 21 Jun 2021 08:45:29 +0200	[thread overview]
Message-ID: <20210621064528.GA5906@lst.de> (raw)
In-Reply-To: <20210621051046.28783-1-smalin@marvell.com>

This seems to lack drivers actually using the infrastructure.  That is not
only completly not acceptable for merging code into the kernel, but also
make the code impossible to review.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  parent reply	other threads:[~2021-06-21  6:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21  5:10 [PATCH v2 0/8] NVMeTCP Offload ULP Shai Malin
2021-06-21  5:10 ` [PATCH v2 1/8] nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP Shai Malin
2021-06-21  5:10 ` [PATCH v2 2/8] nvme-fabrics: Move NVMF_ALLOWED_OPTS and NVMF_REQUIRED_OPTS definitions Shai Malin
2021-06-21  5:10 ` [PATCH v2 3/8] nvme-fabrics: Expose nvmf_check_required_opts() globally Shai Malin
2021-06-21  6:49   ` Christoph Hellwig
2021-06-23 18:58     ` Shai Malin
2021-06-21  5:10 ` [PATCH v2 4/8] nvme-tcp-offload: Add device scan implementation Shai Malin
2021-06-21  6:50   ` Christoph Hellwig
2021-06-23 19:02     ` Shai Malin
2021-06-21  5:10 ` [PATCH v2 5/8] nvme-tcp-offload: Add controller level implementation Shai Malin
2021-06-21  5:10 ` [PATCH v2 6/8] nvme-tcp-offload: Add controller level error recovery implementation Shai Malin
2021-06-21  5:10 ` [PATCH v2 7/8] nvme-tcp-offload: Add queue level implementation Shai Malin
2021-06-21  5:10 ` [PATCH v2 8/8] nvme-tcp-offload: Add IO " Shai Malin
2021-06-21  6:45 ` Christoph Hellwig [this message]
2021-06-23 18:55   ` [PATCH v2 0/8] NVMeTCP Offload ULP Shai Malin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621064528.GA5906@lst.de \
    --to=hch@lst.de \
    --cc=aelior@marvell.com \
    --cc=axboe@fb.com \
    --cc=davem@davemloft.net \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=malin1024@gmail.com \
    --cc=mkalderon@marvell.com \
    --cc=okulkarni@marvell.com \
    --cc=pkushwaha@marvell.com \
    --cc=prabhakar.pkin@gmail.com \
    --cc=sagi@grimberg.me \
    --cc=smalin@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.