From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH] nvme: add comment to not use kobj_to_dev()
Date: Mon, 21 Jun 2021 18:20:19 +0200 [thread overview]
Message-ID: <20210621162019.GA7655@lst.de> (raw)
In-Reply-To: <20210621161743.GB1268033@dhcp-10-100-145-180.wdc.com>
On Mon, Jun 21, 2021 at 09:17:43AM -0700, Keith Busch wrote:
> On Mon, Jun 21, 2021 at 07:32:51AM +0200, Christoph Hellwig wrote:
> > On Sun, Jun 20, 2021 at 08:09:40PM -0700, Chaitanya Kulkarni wrote:
> > > Add a comment in nvme_ns_id_attrs_are_visible() and
> > > nvme_dev_attrs_are_visible() not to replace container_of() with
> > > kobj_to_dev(). Since use of kobj_to_dev() makes code harder to read.
> > >
> > > Suggested-by: Keith Busch <kbusch@kernel.org>
> > > Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> >
> > Err, no. This code is completely obvious as is, and if people keep
> > sending these stupid patches we need to start blacklisting them.
>
> People will continue to send these patches as long as
> scripts/coccinelle/api/kobj_to_dev.cocci keeps warning about it.
Maybe we need to fix that instead?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2021-06-21 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 3:09 [PATCH] nvme: add comment to not use kobj_to_dev() Chaitanya Kulkarni
2021-06-21 5:32 ` Christoph Hellwig
2021-06-21 16:17 ` Keith Busch
2021-06-21 16:19 ` Jens Axboe
2021-06-21 16:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210621162019.GA7655@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.