All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
	Loic Poulain <loic.poulain@linaro.org>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Robert Foss <robert.foss@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	dri-devel@lists.freedesktop.org,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Philippe Schenker <philippe.schenker@toradex.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Valentin Raevsky <valentin@compulab.co.il>,
	Stephen Boyd <swboyd@chromium.org>,
	Adam Ford <aford173@gmail.com>, Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH 0/5] ti-sn65dsi83: Finalize transition to atomic operations
Date: Mon, 21 Jun 2021 21:34:46 +0200	[thread overview]
Message-ID: <20210621193446.GA962565@ravnborg.org> (raw)
In-Reply-To: <YNDhuwRErUEeE19+@pendragon.ideasonboard.com>

Hi Laurent,

> > 
> > It is news to me that the atomic ops are the way to go - but then I have
> > been off-line for a while so no suprise or maybe I just missed it
> > before.
> 
> They're not mandatory as such, but they give us access to the atomic
> state, which is sometimes required. Overall I think it would be nice to
> move to the atomic operations and drop the legacy ones, to avoid
> maintaining two sets of operations. It will take time :-)
Yeah, but if we can get more people working on the job..
> 
> > It would be good if the comments in drm_bridge.h could point out what is
> > deprecated, so we know what to avoid in new and updated bridge drivers.
> > But this is all un-related to this series.
> 
> It's a good point. Would you like to submit a patch, or should I do so ?
Please do as I would have to dig around to do it right as I have
fogotten most of the drm internals the last couple of months.

Just something simple like: "This is deprecated, do not use!" would do
the trick for me. Then I would know what to look for if I was reviewing
a new bridge driver or patching an existing one or just trying to gentle
push someone in the right direction.

For drm_drv.h this really helped me to understand what should not be
used.

	Sam

  reply	other threads:[~2021-06-21 19:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 12:55 [PATCH 0/5] ti-sn65dsi83: Finalize transition to atomic operations Laurent Pinchart
2021-06-21 12:55 ` [PATCH 1/5] drm: bridge: ti-sn65dsi83: Move LVDS format selection to .mode_set() Laurent Pinchart
2021-06-21 12:55 ` [PATCH 2/5] drm: bridge: ti-sn65dsi83: Pass mode explicitly to helper functions Laurent Pinchart
2021-06-21 12:55 ` [PATCH 3/5] drm: bridge: ti-sn65dsi83: Switch to atomic operations Laurent Pinchart
2021-06-21 12:55 ` [PATCH 4/5] drm: bridge: ti-sn65dsi83: Retrieve output format from bridge state Laurent Pinchart
2021-06-21 12:55 ` [PATCH 5/5] drm: bridge: ti-sn65dsi83: Retrieve the display mode from the state Laurent Pinchart
2021-06-21 18:49 ` [PATCH 0/5] ti-sn65dsi83: Finalize transition to atomic operations Sam Ravnborg
2021-06-21 19:00   ` Laurent Pinchart
2021-06-21 19:34     ` Sam Ravnborg [this message]
2021-06-22  8:28   ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621193446.GA962565@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=aford173@gmail.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=jagan@amarulasolutions.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=loic.poulain@linaro.org \
    --cc=marex@denx.de \
    --cc=maxime@cerno.tech \
    --cc=philippe.schenker@toradex.com \
    --cc=robert.foss@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=valentin@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.