From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B775DC48BDF for ; Tue, 22 Jun 2021 09:32:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F6E461351 for ; Tue, 22 Jun 2021 09:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbhFVJfG (ORCPT ); Tue, 22 Jun 2021 05:35:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:56712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbhFVJfF (ORCPT ); Tue, 22 Jun 2021 05:35:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1058A61352; Tue, 22 Jun 2021 09:32:44 +0000 (UTC) Date: Tue, 22 Jun 2021 10:32:42 +0100 From: Catalin Marinas To: Mark Rutland Cc: Nick Desaulniers , Bill Wendling , Masahiro Yamada , Will Deacon , Ard Biesheuvel , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Peter Oberparleiter , Kees Cook , Peter Zijlstra , Bill Wendling , Sami Tolvanen , Miguel Ojeda , Nathan Chancellor , Luc Van Oostenryck , Arnd Bergmann , Andrew Morton , Rasmus Villemoes , LKML , clang-built-linux , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Borislav Petkov , Martin Liska , Jonathan Corbet , Fangrui Song , Linux Doc Mailing List , Linux Kbuild mailing list , Dmitry Vyukov , Johannes Berg , linux-toolchains@vger.kernel.org, Marco Elver , Linux ARM , linux-s390 Subject: Re: [PATCH 2/2] Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Message-ID: <20210622093241.GC3555@arm.com> References: <20210618233023.1360185-1-ndesaulniers@google.com> <20210618233023.1360185-3-ndesaulniers@google.com> <20210622092533.GB3555@arm.com> <20210622092937.GB67232@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622092937.GB67232@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jun 22, 2021 at 10:29:37AM +0100, Mark Rutland wrote: > On Tue, Jun 22, 2021 at 10:25:34AM +0100, Catalin Marinas wrote: > > On Mon, Jun 21, 2021 at 01:43:54PM -0700, Nick Desaulniers wrote: > > > We need to be able to express via Kconfig "GCOV should not be enabled > > > for architectures that use noinstr when the toolchain does not support > > > __attribute__((no_profile_instrument_function))." > > > > > > Where "architectures that use noinstr" are currently arm64, s390, and > > > x86. So I guess we could do: > > > > > > + depends on !ARM64 || !S390 || !X86 || CC_HAS_NO_PROFILE_FN_ATTR > > > > I think you want: > > > > depends on !(ARM64 || S390 || X86) || CC_HAS_NO_PROFILE_FN_ATTR > > > > > (We could add a Kconfig for ARCH_WANTS_NO_INSTR, which might be more > > > informative than listed out architectures which might be non-obvious > > > to passers-by). > > > > That would probably look better. > > It does; see: > > https://lore.kernel.org/r/20210621231822.2848305-1-ndesaulniers@google.com I'm getting there, eventually ;). -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540CEC2B9F4 for ; Tue, 22 Jun 2021 09:34:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18B4B60FE9 for ; Tue, 22 Jun 2021 09:34:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18B4B60FE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eLwvEtbN/m3LrtFGmGLdnL4QTO5d6CziR3PB3apX1ik=; b=Bs+u4V/w3XA33O iiqboUlePVZvqScDL3gpQC6Hr6Ot/hpMdtxOrTuOgfm0fXrDtn9uqPRrhbajcpaw6OWlBXc66RGJe OEtjJ+E76DsSTQElzGbVhDCvzM+ImYvkqPbYVCyK2kSd7b8/jh3tXpQOtSwBMP1UK4LmDXQXX67fH 1rcEAWT/9Y4hmz3ZoZuSUyRRMwloXbn8szF294tXk9BWdbJIDK3X3qFMsYXQAfxzmVuYpIPEUby6G O/OisvBNdldq1mvh4jsw4dYmVzUBfgKl0R6hsUCaRJ9QmB81Sbe4nqe85pY3HhkqdF3T1K0Ou+aci edyDAh0tnSvK3v1l/fmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvcm6-006QmM-5T; Tue, 22 Jun 2021 09:32:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvcm2-006Qhu-EH for linux-arm-kernel@lists.infradead.org; Tue, 22 Jun 2021 09:32:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1058A61352; Tue, 22 Jun 2021 09:32:44 +0000 (UTC) Date: Tue, 22 Jun 2021 10:32:42 +0100 From: Catalin Marinas To: Mark Rutland Cc: Nick Desaulniers , Bill Wendling , Masahiro Yamada , Will Deacon , Ard Biesheuvel , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Peter Oberparleiter , Kees Cook , Peter Zijlstra , Bill Wendling , Sami Tolvanen , Miguel Ojeda , Nathan Chancellor , Luc Van Oostenryck , Arnd Bergmann , Andrew Morton , Rasmus Villemoes , LKML , clang-built-linux , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Borislav Petkov , Martin Liska , Jonathan Corbet , Fangrui Song , Linux Doc Mailing List , Linux Kbuild mailing list , Dmitry Vyukov , Johannes Berg , linux-toolchains@vger.kernel.org, Marco Elver , Linux ARM , linux-s390 Subject: Re: [PATCH 2/2] Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Message-ID: <20210622093241.GC3555@arm.com> References: <20210618233023.1360185-1-ndesaulniers@google.com> <20210618233023.1360185-3-ndesaulniers@google.com> <20210622092533.GB3555@arm.com> <20210622092937.GB67232@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210622092937.GB67232@C02TD0UTHF1T.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210622_023250_605304_12C9AFB2 X-CRM114-Status: GOOD ( 19.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 22, 2021 at 10:29:37AM +0100, Mark Rutland wrote: > On Tue, Jun 22, 2021 at 10:25:34AM +0100, Catalin Marinas wrote: > > On Mon, Jun 21, 2021 at 01:43:54PM -0700, Nick Desaulniers wrote: > > > We need to be able to express via Kconfig "GCOV should not be enabled > > > for architectures that use noinstr when the toolchain does not support > > > __attribute__((no_profile_instrument_function))." > > > > > > Where "architectures that use noinstr" are currently arm64, s390, and > > > x86. So I guess we could do: > > > > > > + depends on !ARM64 || !S390 || !X86 || CC_HAS_NO_PROFILE_FN_ATTR > > > > I think you want: > > > > depends on !(ARM64 || S390 || X86) || CC_HAS_NO_PROFILE_FN_ATTR > > > > > (We could add a Kconfig for ARCH_WANTS_NO_INSTR, which might be more > > > informative than listed out architectures which might be non-obvious > > > to passers-by). > > > > That would probably look better. > > It does; see: > > https://lore.kernel.org/r/20210621231822.2848305-1-ndesaulniers@google.com I'm getting there, eventually ;). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel