From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5825AC2B9F4 for ; Wed, 23 Jun 2021 01:04:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E77CE6109E for ; Wed, 23 Jun 2021 01:04:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E77CE6109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 93CBB85D; Wed, 23 Jun 2021 03:03:42 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 93CBB85D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624410272; bh=/UokAgtuJ75ZQQqf1dWfPmZt2rp3P/9U6JkcEtOg3jU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=E9vwqiZvRvLoz5LSUTRpcDcpIq2KhWaUEWpXXGs+qHhYq0TR3aiD1LoF6GGC0sEyq W5DDMoraBpCzT/UZjPH09c5EoFR6x+qgcJWMmAhOOIZMLewlCh8VFAWI8dT1gFWHJ0 v6Vzn7iBmatMMfmhbkJmQnUaefL4HdlRa+6xrRZE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1D2A0F80161; Wed, 23 Jun 2021 03:03:42 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 52D99F80268; Wed, 23 Jun 2021 03:03:41 +0200 (CEST) Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 27358F80161 for ; Wed, 23 Jun 2021 03:03:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 27358F80161 Received: by m.b4.vu (Postfix, from userid 1000) id 1443861E286D; Wed, 23 Jun 2021 10:33:27 +0930 (ACST) Date: Wed, 23 Jun 2021 10:33:27 +0930 From: "Geoffrey D. Bennett" To: Takashi Iwai Subject: Re: [PATCH 01/17] ALSA: usb-audio: scarlett2: Fix wrong resume call Message-ID: <20210623010327.GA15559@m.b4.vu> References: <49721219f45b7e175e729b0d9d9c142fd8f4342a.1624379707.git.g@b4.vu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Hin-Tak Leung , alsa-devel@alsa-project.org, Vladimir Sadovnikov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Jun 22, 2021 at 09:42:10PM +0200, Takashi Iwai wrote: > On Tue, 22 Jun 2021 19:00:49 +0200, > Geoffrey D. Bennett wrote: > > > > From: Takashi Iwai > > > > The current way of the scarlett2 mixer code managing the > > usb_mixer_elem_info object is wrong in two ways: it passes its > > internal index to the head.id field, and the val_type field is > > uninitialized. This ended up with the wrong execution at the resume > > because a bogus unit id is passed wrongly. Also, in the later code > > extensions, we'll have more mixer elements, and passing the index will > > overflow the unit id size (of 256). > > > > This patch corrects those issues. It introduces a new value type, > > USB_MIXER_BESPOKEN, which indicates a non-standard mixer element, and > > use this type for all scarlett2 mixer elements, as well as > > initializing the fixed unit id 0 for avoiding the overflow. > > > > Tested-by: Geoffrey D. Bennett > > Cc: > > Signed-off-by: Takashi Iwai > > When submitting a patch, you have to your Signed-off-by line even if > you are no author. Could you give it? Just reply with a proper SOB, > then I'll fix manually. Of course. You know how many times I've read Documentation/process/submitting-patches.rst ? Not enough for it to sink in, apparently :). Please append my SOB: Signed-off-by: Geoffrey D. Bennett Thanks, Geoffrey.