From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gawk: create awk symlink for host-gawk
Date: Thu, 24 Jun 2021 23:38:37 +0200 [thread overview]
Message-ID: <20210624213837.GH2852@scaer> (raw)
In-Reply-To: <20210615140302.2485993-1-hubert.lacote@gmail.com>
Hubert, All,
On 2021-06-15 16:03 +0200, Hubert Lacote spake thusly:
> From: Hubert Lacote <hubert.lacote@youview.com>
>
> This is to make sure that host packages that depend on `host-gawk` and that use
> `awk` end up using `gawk`, instead of the `awk` symlink installed on the host
> system.
>
> On recent Debian-based distributions, `awk` is still symlinked to `mawk` [1].
>
> [1] https://bugs.launchpad.net/ubuntu/+source/mawk/+bug/1841654
>
> Signed-off-by: Hubert Lacote <hubert.lacote@youview.com>
> Co-authored-by: Hubert Lacote <hubert.lacote@youview.com>
> Co-authored-by: Vicente Olivert Riera <vincent.olivert.riera@youview.com>
> ---
> package/gawk/gawk.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
> index 16906f6f93..ab7088e90e 100644
> --- a/package/gawk/gawk.mk
> +++ b/package/gawk/gawk.mk
> @@ -33,6 +33,12 @@ endif
>
> HOST_GAWK_CONF_OPTS = --without-readline --without-mpfr
>
> +define HOST_GAWK_CREATE_SYMLINK
> + ln -sf gawk $(HOST_DIR)/usr/bin/awk
> +endef
> +
> +HOST_GAWK_POST_INSTALL_HOOKS += HOST_GAWK_CREATE_SYMLINK
Usually, we add the host-variant stuff after the target-variant stuff,
so I moved that after the corresponding hook, below:
> define GAWK_CREATE_SYMLINK
> ln -sf gawk $(TARGET_DIR)/usr/bin/awk
> endef
Of course, I see that you inserted that next to the existing
host-variant CONF_OPTS, and I can see the reasoning. Still, I found it
odd for the host suff to be stuffed in the middle of the tarrget
stuff...
Applied to master, thanks.
Regards,
Yann E. MORIN.
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2021-06-24 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 14:03 [Buildroot] [PATCH] package/gawk: create awk symlink for host-gawk Hubert Lacote
2021-06-24 21:38 ` Yann E. MORIN [this message]
2021-07-10 17:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210624213837.GH2852@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.