From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21F5C49EAF for ; Thu, 24 Jun 2021 22:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBFC1613B9 for ; Thu, 24 Jun 2021 22:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbhFXW33 (ORCPT ); Thu, 24 Jun 2021 18:29:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:37964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232729AbhFXW33 (ORCPT ); Thu, 24 Jun 2021 18:29:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 74F9E613AD; Thu, 24 Jun 2021 22:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624573629; bh=aZA6UgY1/SzRgcP8YOY86cgw0pyUiDGpoMTA23VVvCU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jqdUJhytpHrkARYoowBbNkAMTY767sqMR56OgZ1+fce0yzYY9PxhTHA46hvd1bLq+ isxE4iqlFqvb0MWIPJEfWUR9Z20M5TevMkNIZw5rpi+r7tYUkGhIt5PWJsVAmCTrJY XeS8Y5eYGOn+Ir1GTWpJ9YgW5Lt5MD25IrBN/65WruvEmDaDPpS7uRCxznXhLCbUaO WdalJD2uhocY747ObhnpUBlWWdnrglWNBu556hFG36gO4LZty7Mf1yLPhH9EkOiNk6 OWY8Dk2dxbzlgaVgAnpup4QIBBMKyZCVYAgEppxfkFWKoE3fhUdzqrrldqUCi18f4y ypNI0P0dRsKjA== Received: by pali.im (Postfix) id 33DBE8A3; Fri, 25 Jun 2021 00:27:09 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , Rob Herring , Gregory Clement Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , "Remi Pommarel" , Xogium , "Tomasz Maciej Nowak" , Nadav Haklai , Kostya Porotchkin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH 3/5] PCI: aardvark: Fix PCIe Max Payload Size setting Date: Fri, 25 Jun 2021 00:26:19 +0200 Message-Id: <20210624222621.4776-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624222621.4776-1-pali@kernel.org> References: <20210624222621.4776-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Change PCIe Max Payload Size setting in PCIe Device Control register to 512 bytes to align with PCIe Link Initialization sequence as defined in Marvell Armada 3700 Functional Specification. According to the specification, maximal Max Payload Size supported by this device is 512 bytes. Without this kernel prints suspicious line: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 16384, max 512) With this change it changes to: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 512, max 512) Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Cc: stable@vger.kernel.org --- drivers/pci/controller/pci-aardvark.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 11368d23b612..397431d641f6 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -428,8 +428,9 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie) reg = advk_readl(pcie, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL); reg &= ~PCI_EXP_DEVCTL_RELAX_EN; reg &= ~PCI_EXP_DEVCTL_NOSNOOP_EN; + reg &= ~PCI_EXP_DEVCTL_PAYLOAD; reg &= ~PCI_EXP_DEVCTL_READRQ; - reg |= PCI_EXP_DEVCTL_PAYLOAD; /* Set max payload size */ + reg |= PCI_EXP_DEVCTL_PAYLOAD_512B; reg |= PCI_EXP_DEVCTL_READRQ_512B; advk_writel(pcie, reg, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E710CC49EA7 for ; Thu, 24 Jun 2021 22:29:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7C5F6138C for ; Thu, 24 Jun 2021 22:29:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7C5F6138C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4D6ETEbfGKWlUYGL3uaR9BL4cST3zASF8FaKvgKBHrQ=; b=qD4vPaiQJxM7mF 0UKw4dm2T+3pty88xtE0lCQ501dxXiaMHfx6b4GYZfrtko1yCxGib1LKIt0QSNowU0jWr9rIy8CGr x9K/pIq6EMdrIbpioyz4tX3iHaaNxv+7LSuxrKKE6wdnq67NFVygkIqzt8mudPwmQw6oRBignT2y1 GYHExvsFMK9L1QjRwVhySrkLxbVt5BVXXjbGTqH+iOISCkWcnB4PEvykNegblTKQc9//JlswcVo/A 6O6tLtaLjLmRSR2e+4zV9CFPxvSUxrFTH1E9fOJKf/8V8kAlBQqWn7GK2pc6cRcFcyzkoFxiFuXeM BdFTb8vTjkomhiI/mbAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwXog-00GV93-EZ; Thu, 24 Jun 2021 22:27:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwXoT-00GV6A-TA for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 22:27:11 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 74F9E613AD; Thu, 24 Jun 2021 22:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624573629; bh=aZA6UgY1/SzRgcP8YOY86cgw0pyUiDGpoMTA23VVvCU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jqdUJhytpHrkARYoowBbNkAMTY767sqMR56OgZ1+fce0yzYY9PxhTHA46hvd1bLq+ isxE4iqlFqvb0MWIPJEfWUR9Z20M5TevMkNIZw5rpi+r7tYUkGhIt5PWJsVAmCTrJY XeS8Y5eYGOn+Ir1GTWpJ9YgW5Lt5MD25IrBN/65WruvEmDaDPpS7uRCxznXhLCbUaO WdalJD2uhocY747ObhnpUBlWWdnrglWNBu556hFG36gO4LZty7Mf1yLPhH9EkOiNk6 OWY8Dk2dxbzlgaVgAnpup4QIBBMKyZCVYAgEppxfkFWKoE3fhUdzqrrldqUCi18f4y ypNI0P0dRsKjA== Received: by pali.im (Postfix) id 33DBE8A3; Fri, 25 Jun 2021 00:27:09 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , Rob Herring , Gregory Clement Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , "Remi Pommarel" , Xogium , "Tomasz Maciej Nowak" , Nadav Haklai , Kostya Porotchkin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH 3/5] PCI: aardvark: Fix PCIe Max Payload Size setting Date: Fri, 25 Jun 2021 00:26:19 +0200 Message-Id: <20210624222621.4776-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624222621.4776-1-pali@kernel.org> References: <20210624222621.4776-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_152709_997129_9709F579 X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Q2hhbmdlIFBDSWUgTWF4IFBheWxvYWQgU2l6ZSBzZXR0aW5nIGluIFBDSWUgRGV2aWNlIENvbnRy b2wgcmVnaXN0ZXIgdG8gNTEyCmJ5dGVzIHRvIGFsaWduIHdpdGggUENJZSBMaW5rIEluaXRpYWxp emF0aW9uIHNlcXVlbmNlIGFzIGRlZmluZWQgaW4gTWFydmVsbApBcm1hZGEgMzcwMCBGdW5jdGlv bmFsIFNwZWNpZmljYXRpb24uIEFjY29yZGluZyB0byB0aGUgc3BlY2lmaWNhdGlvbiwKbWF4aW1h bCBNYXggUGF5bG9hZCBTaXplIHN1cHBvcnRlZCBieSB0aGlzIGRldmljZSBpcyA1MTIgYnl0ZXMu CgpXaXRob3V0IHRoaXMga2VybmVsIHByaW50cyBzdXNwaWNpb3VzIGxpbmU6CgogICAgcGNpIDAw MDA6MDE6MDAuMDogVXBzdHJlYW0gYnJpZGdlJ3MgTWF4IFBheWxvYWQgU2l6ZSBzZXQgdG8gMjU2 ICh3YXMgMTYzODQsIG1heCA1MTIpCgpXaXRoIHRoaXMgY2hhbmdlIGl0IGNoYW5nZXMgdG86Cgog ICAgcGNpIDAwMDA6MDE6MDAuMDogVXBzdHJlYW0gYnJpZGdlJ3MgTWF4IFBheWxvYWQgU2l6ZSBz ZXQgdG8gMjU2ICh3YXMgNTEyLCBtYXggNTEyKQoKU2lnbmVkLW9mZi1ieTogUGFsaSBSb2jDoXIg PHBhbGlAa2VybmVsLm9yZz4KUmV2aWV3ZWQtYnk6IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVs Lm9yZz4KQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKLS0tCiBkcml2ZXJzL3BjaS9jb250cm9s bGVyL3BjaS1hYXJkdmFyay5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3Bj aS1hYXJkdmFyay5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwppbmRl eCAxMTM2OGQyM2I2MTIuLjM5NzQzMWQ2NDFmNiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9wY2ktYWFyZHZhcmsuYworKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1h YXJkdmFyay5jCkBAIC00MjgsOCArNDI4LDkgQEAgc3RhdGljIHZvaWQgYWR2a19wY2llX3NldHVw X2h3KHN0cnVjdCBhZHZrX3BjaWUgKnBjaWUpCiAJcmVnID0gYWR2a19yZWFkbChwY2llLCBQQ0lF X0NPUkVfUENJRVhQX0NBUCArIFBDSV9FWFBfREVWQ1RMKTsKIAlyZWcgJj0gflBDSV9FWFBfREVW Q1RMX1JFTEFYX0VOOwogCXJlZyAmPSB+UENJX0VYUF9ERVZDVExfTk9TTk9PUF9FTjsKKwlyZWcg Jj0gflBDSV9FWFBfREVWQ1RMX1BBWUxPQUQ7CiAJcmVnICY9IH5QQ0lfRVhQX0RFVkNUTF9SRUFE UlE7Ci0JcmVnIHw9IFBDSV9FWFBfREVWQ1RMX1BBWUxPQUQ7IC8qIFNldCBtYXggcGF5bG9hZCBz aXplICovCisJcmVnIHw9IFBDSV9FWFBfREVWQ1RMX1BBWUxPQURfNTEyQjsKIAlyZWcgfD0gUENJ X0VYUF9ERVZDVExfUkVBRFJRXzUxMkI7CiAJYWR2a193cml0ZWwocGNpZSwgcmVnLCBQQ0lFX0NP UkVfUENJRVhQX0NBUCArIFBDSV9FWFBfREVWQ1RMKTsKIAotLSAKMi4yMC4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=