From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFF37C49EA7 for ; Thu, 24 Jun 2021 22:27:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEC0F61361 for ; Thu, 24 Jun 2021 22:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232870AbhFXW3d (ORCPT ); Thu, 24 Jun 2021 18:29:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:38132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232873AbhFXW3b (ORCPT ); Thu, 24 Jun 2021 18:29:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 06FA561375; Thu, 24 Jun 2021 22:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624573632; bh=jYt5kfZFIc6erlp5/8lvnkSBPgbQ6DNhQvJQ28jGNJ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kd7vizbDFBauhateivIkhyAS7AStROoZqtwp9gkAiGOj8di81tHkRcunYn1wtYuzh XqDNQnlAa6wyt8vcP0gpp4vSvvPoiorZ3mYKq1glVKQTciW2RU4mkeEVekVbFaOHIB VjdFIvkfmN+SdxOIvmvQuRrVx9Ykkyd83yivSCXPPcFix1t9pNrj3RteUBRnffiri7 95Te6fuY3YMGppRmo5jReHWcsh2ckNXzdzlZ4k5XDnf/BTS3iA+RPHMXX++5NHalIs ivePIe8pYmt4NkbgX4Og9rw+vsbuYJuIdhoMCwuJbjQ80f+wYwrP9Q5oUXx9ejJtlj dAfODsxjJ6Rhg== Received: by pali.im (Postfix) id B87C88A3; Fri, 25 Jun 2021 00:27:11 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , Rob Herring , Gregory Clement Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , "Remi Pommarel" , Xogium , "Tomasz Maciej Nowak" , Nadav Haklai , Kostya Porotchkin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH 5/5] PCI: aardvark: Implement workaround for PCIe Completion Timeout Date: Fri, 25 Jun 2021 00:26:21 +0200 Message-Id: <20210624222621.4776-6-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624222621.4776-1-pali@kernel.org> References: <20210624222621.4776-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Marvell Armada 3700 Functional Errata, Guidelines, and Restrictions document describes in erratum 3.12 PCIe Completion Timeout (Ref #: 251), that PCIe IP does not support a strong-ordered model for inbound posted vs. outbound completion. As a workaround for this erratum, DIS_ORD_CHK flag in Debug Mux Control register must be set. It disables the ordering check in the core between Completions and Posted requests received from the link. It was reported that enabling this workaround fixes instability issues and "Unhandled fault" errors when using 60 GHz WiFi 802.11ad card with Qualcomm QCA6335 chip under significant load which were caused by interrupt status stuck in the outbound CMPLT queue traced back to this erratum. This workaround fixes also kernel panic triggered after some minutes of usage 5 GHz WiFi 802.11ax card with Mediatek MT7915 chip: Internal error: synchronous external abort: 96000210 [#1] SMP Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Thomas Petazzoni Signed-off-by: Pali Rohár Cc: stable@vger.kernel.org --- Patch was originally written by Thomas and is already for a long time part of Marvell SDK. I have just re-written/re-applied it on top of mainline kernel and also wrote a new updated commit message. Please note that this patch is questionable as Bjorn has some objections and nobody, including Marvell, was not able to explain erratum nor what is workaround exactly doing. Documentation about this topic is basically missing. We just know that it fixes real kernel crashes when using WiFi cards. --- drivers/pci/controller/pci-aardvark.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index 9ff68abd8d1e..231f4469d87e 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -167,6 +167,8 @@ #define LTSSM_L0 0x10 #define RC_BAR_CONFIG 0x300 #define VENDOR_ID_REG (LMI_BASE_ADDR + 0x44) +#define DEBUG_MUX_CTRL_REG (LMI_BASE_ADDR + 0x208) +#define DIS_ORD_CHK BIT(30) /* PCIe core controller registers */ #define CTRL_CORE_BASE_ADDR 0x18000 @@ -450,6 +452,11 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie) PCIE_CORE_CTRL2_TD_ENABLE; advk_writel(pcie, reg, PCIE_CORE_CTRL2_REG); + /* Disable ordering checks, workaround for erratum 3.12 "PCIe completion timeout" */ + reg = advk_readl(pcie, DEBUG_MUX_CTRL_REG); + reg |= DIS_ORD_CHK; + advk_writel(pcie, reg, DEBUG_MUX_CTRL_REG); + /* Set lane X1 */ reg = advk_readl(pcie, PCIE_CORE_CTRL0_REG); reg &= ~LANE_CNT_MSK; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6678C49EA5 for ; Thu, 24 Jun 2021 22:29:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F24B61164 for ; Thu, 24 Jun 2021 22:29:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F24B61164 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K/bLS/6UATogCjamv3jrd7z1vMyrQvq7aWdqRkRGovU=; b=ywOldkysFyUV0+ zScjxV5J40l/1QE1er29d08ODkVIT5XLHQt4fo431NWN+7iB6mu8LAZ2w2u9VSQStgPNQA0HxTKhu 4tTpT72F3FXZxMdizUD7DP/Y6MgXZnOI5H0biB74tNKiwMvhLBftmx0WtlDFhNFjq/BVld7oHy/hX hUtgd00evXpVdUQB7FRyaSYprAM267DsiouoJmF5UqdE9KSCAU6grBa3C/ssNjXCqzFmokcAVMFeJ hv3rZ7nKh8YYJgSZBoIgodMyDbFMtex28zrKDRREHC8siHlTjvLs0gevr2L4fYf45UnM3RyO1q19z Ut6mGmlWWrt9v2DXE8eA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwXpN-00GVGe-No; Thu, 24 Jun 2021 22:28:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwXoW-00GV6Z-9L for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 22:27:13 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 06FA561375; Thu, 24 Jun 2021 22:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624573632; bh=jYt5kfZFIc6erlp5/8lvnkSBPgbQ6DNhQvJQ28jGNJ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kd7vizbDFBauhateivIkhyAS7AStROoZqtwp9gkAiGOj8di81tHkRcunYn1wtYuzh XqDNQnlAa6wyt8vcP0gpp4vSvvPoiorZ3mYKq1glVKQTciW2RU4mkeEVekVbFaOHIB VjdFIvkfmN+SdxOIvmvQuRrVx9Ykkyd83yivSCXPPcFix1t9pNrj3RteUBRnffiri7 95Te6fuY3YMGppRmo5jReHWcsh2ckNXzdzlZ4k5XDnf/BTS3iA+RPHMXX++5NHalIs ivePIe8pYmt4NkbgX4Og9rw+vsbuYJuIdhoMCwuJbjQ80f+wYwrP9Q5oUXx9ejJtlj dAfODsxjJ6Rhg== Received: by pali.im (Postfix) id B87C88A3; Fri, 25 Jun 2021 00:27:11 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Bjorn Helgaas , Rob Herring , Gregory Clement Cc: =?UTF-8?q?Marek=20Beh=C3=BAn?= , "Remi Pommarel" , Xogium , "Tomasz Maciej Nowak" , Nadav Haklai , Kostya Porotchkin , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [RESEND PATCH 5/5] PCI: aardvark: Implement workaround for PCIe Completion Timeout Date: Fri, 25 Jun 2021 00:26:21 +0200 Message-Id: <20210624222621.4776-6-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624222621.4776-1-pali@kernel.org> References: <20210624222621.4776-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_152712_383954_BC7C4577 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TWFydmVsbCBBcm1hZGEgMzcwMCBGdW5jdGlvbmFsIEVycmF0YSwgR3VpZGVsaW5lcywgYW5kIFJl c3RyaWN0aW9ucwpkb2N1bWVudCBkZXNjcmliZXMgaW4gZXJyYXR1bSAzLjEyIFBDSWUgQ29tcGxl dGlvbiBUaW1lb3V0IChSZWYgIzogMjUxKSwKdGhhdCBQQ0llIElQIGRvZXMgbm90IHN1cHBvcnQg YSBzdHJvbmctb3JkZXJlZCBtb2RlbCBmb3IgaW5ib3VuZCBwb3N0ZWQgdnMuCm91dGJvdW5kIGNv bXBsZXRpb24uCgpBcyBhIHdvcmthcm91bmQgZm9yIHRoaXMgZXJyYXR1bSwgRElTX09SRF9DSEsg ZmxhZyBpbiBEZWJ1ZyBNdXggQ29udHJvbApyZWdpc3RlciBtdXN0IGJlIHNldC4gSXQgZGlzYWJs ZXMgdGhlIG9yZGVyaW5nIGNoZWNrIGluIHRoZSBjb3JlIGJldHdlZW4KQ29tcGxldGlvbnMgYW5k IFBvc3RlZCByZXF1ZXN0cyByZWNlaXZlZCBmcm9tIHRoZSBsaW5rLgoKSXQgd2FzIHJlcG9ydGVk IHRoYXQgZW5hYmxpbmcgdGhpcyB3b3JrYXJvdW5kIGZpeGVzIGluc3RhYmlsaXR5IGlzc3VlcyBh bmQKIlVuaGFuZGxlZCBmYXVsdCIgZXJyb3JzIHdoZW4gdXNpbmcgNjAgR0h6IFdpRmkgODAyLjEx YWQgY2FyZCB3aXRoIFF1YWxjb21tClFDQTYzMzUgY2hpcCB1bmRlciBzaWduaWZpY2FudCBsb2Fk IHdoaWNoIHdlcmUgY2F1c2VkIGJ5IGludGVycnVwdCBzdGF0dXMKc3R1Y2sgaW4gdGhlIG91dGJv dW5kIENNUExUIHF1ZXVlIHRyYWNlZCBiYWNrIHRvIHRoaXMgZXJyYXR1bS4KClRoaXMgd29ya2Fy b3VuZCBmaXhlcyBhbHNvIGtlcm5lbCBwYW5pYyB0cmlnZ2VyZWQgYWZ0ZXIgc29tZSBtaW51dGVz IG9mCnVzYWdlIDUgR0h6IFdpRmkgODAyLjExYXggY2FyZCB3aXRoIE1lZGlhdGVrIE1UNzkxNSBj aGlwOgoKICAgIEludGVybmFsIGVycm9yOiBzeW5jaHJvbm91cyBleHRlcm5hbCBhYm9ydDogOTYw MDAyMTAgWyMxXSBTTVAKICAgIEtlcm5lbCBwYW5pYyAtIG5vdCBzeW5jaW5nOiBGYXRhbCBleGNl cHRpb24gaW4gaW50ZXJydXB0CgpTaWduZWQtb2ZmLWJ5OiBUaG9tYXMgUGV0YXp6b25pIDx0aG9t YXMucGV0YXp6b25pQGJvb3RsaW4uY29tPgpTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOhciA8cGFs aUBrZXJuZWwub3JnPgpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwotLS0KUGF0Y2ggd2FzIG9y aWdpbmFsbHkgd3JpdHRlbiBieSBUaG9tYXMgYW5kIGlzIGFscmVhZHkgZm9yIGEgbG9uZyB0aW1l IHBhcnQKb2YgTWFydmVsbCBTREsuIEkgaGF2ZSBqdXN0IHJlLXdyaXR0ZW4vcmUtYXBwbGllZCBp dCBvbiB0b3Agb2YgbWFpbmxpbmUKa2VybmVsIGFuZCBhbHNvIHdyb3RlIGEgbmV3IHVwZGF0ZWQg Y29tbWl0IG1lc3NhZ2UuCgpQbGVhc2Ugbm90ZSB0aGF0IHRoaXMgcGF0Y2ggaXMgcXVlc3Rpb25h YmxlIGFzIEJqb3JuIGhhcyBzb21lIG9iamVjdGlvbnMKYW5kIG5vYm9keSwgaW5jbHVkaW5nIE1h cnZlbGwsIHdhcyBub3QgYWJsZSB0byBleHBsYWluIGVycmF0dW0gbm9yIHdoYXQKaXMgd29ya2Fy b3VuZCBleGFjdGx5IGRvaW5nLiBEb2N1bWVudGF0aW9uIGFib3V0IHRoaXMgdG9waWMgaXMgYmFz aWNhbGx5Cm1pc3NpbmcuCgpXZSBqdXN0IGtub3cgdGhhdCBpdCBmaXhlcyByZWFsIGtlcm5lbCBj cmFzaGVzIHdoZW4gdXNpbmcgV2lGaSBjYXJkcy4KLS0tCiBkcml2ZXJzL3BjaS9jb250cm9sbGVy L3BjaS1hYXJkdmFyay5jIHwgNyArKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYyBi L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFhcmR2YXJrLmMKaW5kZXggOWZmNjhhYmQ4ZDFl Li4yMzFmNDQ2OWQ4N2UgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpLWFh cmR2YXJrLmMKKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwpAQCAt MTY3LDYgKzE2Nyw4IEBACiAjZGVmaW5lICAgICBMVFNTTV9MMAkJCQkweDEwCiAjZGVmaW5lICAg ICBSQ19CQVJfQ09ORklHCQkJMHgzMDAKICNkZWZpbmUgVkVORE9SX0lEX1JFRwkJCQkoTE1JX0JB U0VfQUREUiArIDB4NDQpCisjZGVmaW5lIERFQlVHX01VWF9DVFJMX1JFRwkJCShMTUlfQkFTRV9B RERSICsgMHgyMDgpCisjZGVmaW5lICAgICBESVNfT1JEX0NISwkJCQlCSVQoMzApCiAKIC8qIFBD SWUgY29yZSBjb250cm9sbGVyIHJlZ2lzdGVycyAqLwogI2RlZmluZSBDVFJMX0NPUkVfQkFTRV9B RERSCQkJMHgxODAwMApAQCAtNDUwLDYgKzQ1MiwxMSBAQCBzdGF0aWMgdm9pZCBhZHZrX3BjaWVf c2V0dXBfaHcoc3RydWN0IGFkdmtfcGNpZSAqcGNpZSkKIAkJUENJRV9DT1JFX0NUUkwyX1REX0VO QUJMRTsKIAlhZHZrX3dyaXRlbChwY2llLCByZWcsIFBDSUVfQ09SRV9DVFJMMl9SRUcpOwogCisJ LyogRGlzYWJsZSBvcmRlcmluZyBjaGVja3MsIHdvcmthcm91bmQgZm9yIGVycmF0dW0gMy4xMiAi UENJZSBjb21wbGV0aW9uIHRpbWVvdXQiICovCisJcmVnID0gYWR2a19yZWFkbChwY2llLCBERUJV R19NVVhfQ1RSTF9SRUcpOworCXJlZyB8PSBESVNfT1JEX0NISzsKKwlhZHZrX3dyaXRlbChwY2ll LCByZWcsIERFQlVHX01VWF9DVFJMX1JFRyk7CisKIAkvKiBTZXQgbGFuZSBYMSAqLwogCXJlZyA9 IGFkdmtfcmVhZGwocGNpZSwgUENJRV9DT1JFX0NUUkwwX1JFRyk7CiAJcmVnICY9IH5MQU5FX0NO VF9NU0s7Ci0tIAoyLjIwLjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==